Re: [dts] [PATCH V1] tests/kni:del the ip before verify results

Re: [dts] [PATCH V1] tests/kni:del the ip before verify results

[Zhu, WenhuiX]

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, August 15, 2019 8:00 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/kni:del the ip before verify results

Remove the ip from tester before verify results; otehrwise, if the case is fail, the ip is still existing on tester.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_kni.py | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index f1f85df..630dcdd 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -579,20 +579,19 @@ class TestKni(TestCase):
 
             virtual_interface = self.virtual_interface_name(port)
 
-            out = self.dut.send_expect(
+            out1 = self.dut.send_expect(
                 "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10)
-            self.verify("64 bytes from 192.168.%d.2:" %
-                        port in out, "ping not supported")
-
-            out = self.tester.send_expect(
+            out2 = self.tester.send_expect(
                 "ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# ", 10)
-            self.verify("64 bytes from 192.168.%d.1:" %
-                        port in out, "kni cannot reply ping packet")
-
-            out = self.dut.send_expect(
+            out3 = self.dut.send_expect(
                 "ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, port), "# ", 10)
-            self.verify(
-                "0 received, 100% packet loss" in out, "ping not supported")
+
+            # remove ip from tester
+            self.tester.send_expect("ip addr del 192.168.%d.2 dev %s" % 
+ (port, tx_interface), "# ")
+
+            self.verify("64 bytes from 192.168.%d.2:" %port in out1, "ping not supported")
+            self.verify("64 bytes from 192.168.%d.1:" %port in out2, "kni cannot reply ping packet")
+            self.verify("0 received, 100% packet loss" in out3, "ping 
+ not supported")
 
             out = self.dut.send_expect(
                 "ip -family inet6 address show dev %s | awk '/inet6/ { print $2 }'| cut -d'/' -f1" % virtual_interface, "# ", 10)
--
2.17.1

[dts] [PATCH V1] tests/kni:del the ip before verify results

[Wenjie Li]

Remove the ip from tester before verify results; otehrwise, if the case
is fail, the ip is still existing on tester.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_kni.py | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index f1f85df..630dcdd 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -579,20 +579,19 @@ class TestKni(TestCase):
 
             virtual_interface = self.virtual_interface_name(port)
 
-            out = self.dut.send_expect(
+            out1 = self.dut.send_expect(
                 "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10)
-            self.verify("64 bytes from 192.168.%d.2:" %
-                        port in out, "ping not supported")
-
-            out = self.tester.send_expect(
+            out2 = self.tester.send_expect(
                 "ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# ", 10)
-            self.verify("64 bytes from 192.168.%d.1:" %
-                        port in out, "kni cannot reply ping packet")
-
-            out = self.dut.send_expect(
+            out3 = self.dut.send_expect(
                 "ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, port), "# ", 10)
-            self.verify(
-                "0 received, 100% packet loss" in out, "ping not supported")
+
+            # remove ip from tester
+            self.tester.send_expect("ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
+
+            self.verify("64 bytes from 192.168.%d.2:" %port in out1, "ping not supported")
+            self.verify("64 bytes from 192.168.%d.1:" %port in out2, "kni cannot reply ping packet")
+            self.verify("0 received, 100% packet loss" in out3, "ping not supported")
 
             out = self.dut.send_expect(
                 "ip -family inet6 address show dev %s | awk '/inet6/ { print $2 }'| cut -d'/' -f1" % virtual_interface, "# ", 10)
-- 
2.17.1