From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CC13A0471 for ; Thu, 15 Aug 2019 05:07:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44B661BE8F; Thu, 15 Aug 2019 05:07:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F3BD81BE8E for ; Thu, 15 Aug 2019 05:07:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 20:07:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,387,1559545200"; d="scan'208";a="376254079" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2019 20:07:15 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 14 Aug 2019 20:07:15 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Aug 2019 20:07:14 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 14 Aug 2019 20:07:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Thu, 15 Aug 2019 11:07:13 +0800 From: "Zhu, WenhuiX" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/kni:del the ip before verify results Thread-Index: AQHVUxZinLFwVNluK0KczvulZ/nwS6b7hqdA Date: Thu, 15 Aug 2019 03:07:12 +0000 Message-ID: References: <1565870428-29269-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1565870428-29269-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/kni:del the ip before verify results X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested-by: Zhu, WenhuiX -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li Sent: Thursday, August 15, 2019 8:00 PM To: dts@dpdk.org Cc: Li, WenjieX A Subject: [dts] [PATCH V1] tests/kni:del the ip before verify results Remove the ip from tester before verify results; otehrwise, if the case is = fail, the ip is still existing on tester. Signed-off-by: Wenjie Li --- tests/TestSuite_kni.py | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index f1f85df.= .630dcdd 100644 --- a/tests/TestSuite_kni.py +++ b/tests/TestSuite_kni.py @@ -579,20 +579,19 @@ class TestKni(TestCase): =20 virtual_interface =3D self.virtual_interface_name(port) =20 - out =3D self.dut.send_expect( + out1 =3D self.dut.send_expect( "ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port)= , "# ", 10) - self.verify("64 bytes from 192.168.%d.2:" % - port in out, "ping not supported") - - out =3D self.tester.send_expect( + out2 =3D self.tester.send_expect( "ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# = ", 10) - self.verify("64 bytes from 192.168.%d.1:" % - port in out, "kni cannot reply ping packet") - - out =3D self.dut.send_expect( + out3 =3D self.dut.send_expect( "ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, por= t), "# ", 10) - self.verify( - "0 received, 100% packet loss" in out, "ping not supported= ") + + # remove ip from tester + self.tester.send_expect("ip addr del 192.168.%d.2 dev %s" %=20 + (port, tx_interface), "# ") + + self.verify("64 bytes from 192.168.%d.2:" %port in out1, "ping= not supported") + self.verify("64 bytes from 192.168.%d.1:" %port in out2, "kni = cannot reply ping packet") + self.verify("0 received, 100% packet loss" in out3, "ping=20 + not supported") =20 out =3D self.dut.send_expect( "ip -family inet6 address show dev %s | awk '/inet6/ { pri= nt $2 }'| cut -d'/' -f1" % virtual_interface, "# ", 10) -- 2.17.1