test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code
@ 2019-08-13  5:34 yufengmx
  2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
  2019-08-13  6:39 ` [dts] [PATCH V1]framework/qemu_kvm: " Wang, Yinan
  0 siblings, 2 replies; 5+ messages in thread
From: yufengmx @ 2019-08-13  5:34 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

remove duplicate opt_settings key setting in __add_vm_virtio_user_pci method. 
L812/813 is duplicate with L816/817 

yufengmx (1):
  framework\qemu_kvm: remove duplicate source code

 framework/qemu_kvm.py | 2 --
 1 file changed, 2 deletions(-)

-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
  2019-08-13  5:34 [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code yufengmx
@ 2019-08-13  5:34 ` " yufengmx
  2019-08-13  6:39   ` Wang, Yinan
  2019-08-28  5:37   ` Tu, Lijuan
  2019-08-13  6:39 ` [dts] [PATCH V1]framework/qemu_kvm: " Wang, Yinan
  1 sibling, 2 replies; 5+ messages in thread
From: yufengmx @ 2019-08-13  5:34 UTC (permalink / raw)
  To: dts; +Cc: yufengmx


remove duplicate opt_settings key setting in __add_vm_virtio_user_pci method.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/qemu_kvm.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
index c425f41..e349517 100644
--- a/framework/qemu_kvm.py
+++ b/framework/qemu_kvm.py
@@ -813,8 +813,6 @@ class QEMUKvm(VirtBase):
             opts['opt_settings'] = options['opt_settings']
         if 'opt_legacy' in options.keys() and options['opt_legacy']:
             opts['opt_legacy'] = options['opt_legacy']
-        if 'opt_settings' in options.keys() and options['opt_settings']:
-            opts['opt_settings'] = options['opt_settings']
         self.__add_vm_virtio_net_pci(**opts)
 
     def __add_vm_virtio_cuse_pci(self, **options):
-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code
  2019-08-13  5:34 [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code yufengmx
  2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
@ 2019-08-13  6:39 ` " Wang, Yinan
  1 sibling, 0 replies; 5+ messages in thread
From: Wang, Yinan @ 2019-08-13  6:39 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: 2019^[$BG/^[(B8^[$B7n^[(B13^[$BF|^[(B 13:34
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code
> 
> remove duplicate opt_settings key setting in __add_vm_virtio_user_pci method.
> L812/813 is duplicate with L816/817
> 
> yufengmx (1):
>   framework\qemu_kvm: remove duplicate source code
> 
>  framework/qemu_kvm.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> --
> 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
  2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
@ 2019-08-13  6:39   ` Wang, Yinan
  2019-08-28  5:37   ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Wang, Yinan @ 2019-08-13  6:39 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: 2019^[$BG/^[(B8^[$B7n^[(B13^[$BF|^[(B 13:34
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
> 
> 
> remove duplicate opt_settings key setting in __add_vm_virtio_user_pci method.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/qemu_kvm.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> c425f41..e349517 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -813,8 +813,6 @@ class QEMUKvm(VirtBase):
>              opts['opt_settings'] = options['opt_settings']
>          if 'opt_legacy' in options.keys() and options['opt_legacy']:
>              opts['opt_legacy'] = options['opt_legacy']
> -        if 'opt_settings' in options.keys() and options['opt_settings']:
> -            opts['opt_settings'] = options['opt_settings']
>          self.__add_vm_virtio_net_pci(**opts)
> 
>      def __add_vm_virtio_cuse_pci(self, **options):
> --
> 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
  2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
  2019-08-13  6:39   ` Wang, Yinan
@ 2019-08-28  5:37   ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-08-28  5:37 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Tuesday, August 13, 2019 1:34 PM
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source
> code
> 
> 
> remove duplicate opt_settings key setting in __add_vm_virtio_user_pci
> method.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/qemu_kvm.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> c425f41..e349517 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -813,8 +813,6 @@ class QEMUKvm(VirtBase):
>              opts['opt_settings'] = options['opt_settings']
>          if 'opt_legacy' in options.keys() and options['opt_legacy']:
>              opts['opt_legacy'] = options['opt_legacy']
> -        if 'opt_settings' in options.keys() and options['opt_settings']:
> -            opts['opt_settings'] = options['opt_settings']
>          self.__add_vm_virtio_net_pci(**opts)
> 
>      def __add_vm_virtio_cuse_pci(self, **options):
> --
> 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13  5:34 [dts] [PATCH V1]framework/qemu_kvm: remove duplicate source code yufengmx
2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
2019-08-13  6:39   ` Wang, Yinan
2019-08-28  5:37   ` Tu, Lijuan
2019-08-13  6:39 ` [dts] [PATCH V1]framework/qemu_kvm: " Wang, Yinan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox