test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Mo, YufengX" <yufengx.mo@intel.com>
Subject: Re: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
Date: Tue, 13 Aug 2019 06:39:37 +0000	[thread overview]
Message-ID: <E0CBA5A1980F1F408E1F28F9991B5B1D50EE5255@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1565674467-21124-2-git-send-email-yufengx.mo@intel.com>

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: 2019年8月13日 13:34
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code
> 
> 
> remove duplicate opt_settings key setting in __add_vm_virtio_user_pci method.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/qemu_kvm.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> c425f41..e349517 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -813,8 +813,6 @@ class QEMUKvm(VirtBase):
>              opts['opt_settings'] = options['opt_settings']
>          if 'opt_legacy' in options.keys() and options['opt_legacy']:
>              opts['opt_legacy'] = options['opt_legacy']
> -        if 'opt_settings' in options.keys() and options['opt_settings']:
> -            opts['opt_settings'] = options['opt_settings']
>          self.__add_vm_virtio_net_pci(**opts)
> 
>      def __add_vm_virtio_cuse_pci(self, **options):
> --
> 1.9.3


  reply	other threads:[~2019-08-13  6:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  5:34 [dts] [PATCH V1]framework/qemu_kvm: " yufengmx
2019-08-13  5:34 ` [dts] [PATCH V1]framework\qemu_kvm: " yufengmx
2019-08-13  6:39   ` Wang, Yinan [this message]
2019-08-28  5:37   ` Tu, Lijuan
2019-08-13  6:39 ` [dts] [PATCH V1]framework/qemu_kvm: " Wang, Yinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E0CBA5A1980F1F408E1F28F9991B5B1D50EE5255@SHSMSX104.ccr.corp.intel.com \
    --to=yinan.wang@intel.com \
    --cc=dts@dpdk.org \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).