test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>,
	 "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test	caseblocked issue.
Date: Tue, 12 Nov 2019 14:53:06 +0000	[thread overview]
Message-ID: <E0CBA5A1980F1F408E1F28F9991B5B1D50F42DF9@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BB5D315@SHSMSX101.ccr.corp.intel.com>

Hi shuai,

Could you please send another patch to rollback below patch, as developer will fix issue by another solution.

Br,
yinan

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: 2019年11月4日 10:46
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test
> caseblocked issue.
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > Sent: Thursday, October 24, 2019 1:36 PM
> > To: dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > <shuaix.zhu@intel.com>
> > Subject: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test
> > caseblocked issue.
> >
> > Modify the code due to dpdk changes.(commit
> > id:f430bbcecf3eed93916f45654f51dd19d6955aa2)
> >
> > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > ---
> >  tests/TestSuite_vhost_virtio_user_interrupt.py | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > index 5422e04..91edcce 100644
> > --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > @@ -84,6 +84,10 @@ class TestVirtioUserInterrupt(TestCase):
> >          self.dut.send_expect("cp ./examples/l3fwd-power/main.c .", "#")
> >          self.dut.send_expect(
> >                  "sed -i '/DEV_RX_OFFLOAD_CHECKSUM/d'
> > ./examples/l3fwd- power/main.c", "#", 10)
> > +        self.dut.send_expect(
> > +                "sed -i '/if (promiscuous_on/i\#if 0'
> > + ./examples/l3fwd-
> > power/main.c", "#", 10)
> > +        self.dut.send_expect(
> > +                "sed -i '/rte_spinlock_init(&(locks/i\#endif'
> > + ./examples/l3fwd-
> > power/main.c", "#", 10)
> >          out = self.dut.build_dpdk_apps("./examples/l3fwd-power")
> >          self.verify("Error" not in out, "compilation l3fwd-power
> > error")
> >
> > --
> > 2.17.2


      reply	other threads:[~2019-11-12 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  5:35 zhu,shuai
2019-10-24  6:36 ` Wang, Yinan
2019-11-04  2:46 ` Tu, Lijuan
2019-11-12 14:53   ` Wang, Yinan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E0CBA5A1980F1F408E1F28F9991B5B1D50F42DF9@SHSMSX104.ccr.corp.intel.com \
    --to=yinan.wang@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).