test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode.
@ 2019-11-25  8:33 zhu,shuai
  2019-11-26  5:31 ` Wang, Yinan
  2019-11-27  9:26 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: zhu,shuai @ 2019-11-25  8:33 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai

Transfer some control information.Enable promiscuous mode.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vhost_virtio_user_interrupt.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py b/tests/TestSuite_vhost_virtio_user_interrupt.py
index 002588d..288da2b 100644
--- a/tests/TestSuite_vhost_virtio_user_interrupt.py
+++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
@@ -94,7 +94,7 @@ class TestVirtioUserInterrupt(TestCase):
         cmd_l3fwd = "./examples/l3fwd-power/build/l3fwd-power " + \
                     "-n %d -c %s --socket-mem 1024,1024 --legacy-mem " + \
                     "--log-level='user1,7' --no-pci --file-prefix=l3fwd-pwd " + \
-                    "--vdev=virtio_user0,path=%s -- -p 1 " + \
+                    "--vdev=virtio_user0,path=%s,cq=1 -- -p 1 " + \
                     " -P --config='(0,0,%s)' --parse-ptype "
         cmd_l3fwd = cmd_l3fwd % (self.mem_channel, self.core_mask_l3fwd,
                     path, self.core_interrupt)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode.
  2019-11-25  8:33 [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode zhu,shuai
@ 2019-11-26  5:31 ` Wang, Yinan
  2019-11-27  9:26 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Wang, Yinan @ 2019-11-26  5:31 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Sent: 2019年11月25日 16:33
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous
> mode.
> 
> Transfer some control information.Enable promiscuous mode.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_user_interrupt.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> b/tests/TestSuite_vhost_virtio_user_interrupt.py
> index 002588d..288da2b 100644
> --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> @@ -94,7 +94,7 @@ class TestVirtioUserInterrupt(TestCase):
>          cmd_l3fwd = "./examples/l3fwd-power/build/l3fwd-power " + \
>                      "-n %d -c %s --socket-mem 1024,1024 --legacy-mem "
> + \
>                      "--log-level='user1,7' --no-pci --file-prefix=l3fwd-pwd "
> + \
> -                    "--vdev=virtio_user0,path=%s -- -p 1 " + \
> +                    "--vdev=virtio_user0,path=%s,cq=1 -- -p 1 " + \
>                      " -P --config='(0,0,%s)' --parse-ptype "
>          cmd_l3fwd = cmd_l3fwd % (self.mem_channel,
> self.core_mask_l3fwd,
>                      path, self.core_interrupt)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode.
  2019-11-25  8:33 [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode zhu,shuai
  2019-11-26  5:31 ` Wang, Yinan
@ 2019-11-27  9:26 ` Tu, Lijuan
  2019-11-27  9:30   ` Zhu, ShuaiX
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2019-11-27  9:26 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Please change your comments,  ``cq`` is used to enable control queue, but not promiscuous mode.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Monday, November 25, 2019 4:33 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable
> promiscuous mode.
> 
> Transfer some control information.Enable promiscuous mode.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_user_interrupt.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> b/tests/TestSuite_vhost_virtio_user_interrupt.py
> index 002588d..288da2b 100644
> --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> @@ -94,7 +94,7 @@ class TestVirtioUserInterrupt(TestCase):
>          cmd_l3fwd = "./examples/l3fwd-power/build/l3fwd-power " + \
>                      "-n %d -c %s --socket-mem 1024,1024 --legacy-mem " + \
>                      "--log-level='user1,7' --no-pci --file-prefix=l3fwd-pwd " + \
> -                    "--vdev=virtio_user0,path=%s -- -p 1 " + \
> +                    "--vdev=virtio_user0,path=%s,cq=1 -- -p 1 " + \
>                      " -P --config='(0,0,%s)' --parse-ptype "
>          cmd_l3fwd = cmd_l3fwd % (self.mem_channel, self.core_mask_l3fwd,
>                      path, self.core_interrupt)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode.
  2019-11-27  9:26 ` Tu, Lijuan
@ 2019-11-27  9:30   ` Zhu, ShuaiX
  0 siblings, 0 replies; 4+ messages in thread
From: Zhu, ShuaiX @ 2019-11-27  9:30 UTC (permalink / raw)
  To: Tu, Lijuan, dts; +Cc: Wang, Yinan

Ok, I see. I 'll edit the comments. Thank you.

> -----Original Message-----
> From: Tu, Lijuan
> Sent: Wednesday, November 27, 2019 5:26 PM
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable
> promiscuous mode.
> 
> Please change your comments,  ``cq`` is used to enable control queue, but not
> promiscuous mode.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > Sent: Monday, November 25, 2019 4:33 PM
> > To: dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > <shuaix.zhu@intel.com>
> > Subject: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable
> > promiscuous mode.
> >
> > Transfer some control information.Enable promiscuous mode.
> >
> > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > ---
> >  tests/TestSuite_vhost_virtio_user_interrupt.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > index 002588d..288da2b 100644
> > --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > @@ -94,7 +94,7 @@ class TestVirtioUserInterrupt(TestCase):
> >          cmd_l3fwd = "./examples/l3fwd-power/build/l3fwd-power " + \
> >                      "-n %d -c %s --socket-mem 1024,1024 --legacy-mem "
> + \
> >                      "--log-level='user1,7' --no-pci --file-prefix=l3fwd-pwd
> " + \
> > -                    "--vdev=virtio_user0,path=%s -- -p 1 " + \
> > +                    "--vdev=virtio_user0,path=%s,cq=1 -- -p 1 " + \
> >                      " -P --config='(0,0,%s)' --parse-ptype "
> >          cmd_l3fwd = cmd_l3fwd % (self.mem_channel,
> self.core_mask_l3fwd,
> >                      path, self.core_interrupt)
> > --
> > 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-27  9:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25  8:33 [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Enable promiscuous mode zhu,shuai
2019-11-26  5:31 ` Wang, Yinan
2019-11-27  9:26 ` Tu, Lijuan
2019-11-27  9:30   ` Zhu, ShuaiX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).