test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4
@ 2020-07-16  7:45 xizhan4x
  2020-07-16  7:45 ` Zhang, XiX
  2020-07-24  2:18 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: xizhan4x @ 2020-07-16  7:45 UTC (permalink / raw)
  To: dts; +Cc: xizhan4x

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=a, Size: 2017 bytes --]

The maximum number of queues for springville  is 4

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_shutdown_api.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 650ccfc..3f42f93 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -793,10 +793,15 @@ class TestShutdownApi(TestCase):
         When rx_descriptor_status is used, status can be “AVAILABLE”, “DONE” or “UNAVAILABLE”.
         When tx_descriptor_status is used, status can be “FULL”, “DONE” or “UNAVAILABLE.”
         """
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --txq=16 --rxq=16 --txd=4096 --rxd=4096" % utils.create_mask(self.ports), socket=self.ports_socket)
+        queue_num=16
+        if self.nic in ["springville"]:
+            queue_num=4
+        self.pmdout.start_testpmd("Default",
+                                 "--portmask=%s --port-topology=loop --txq=%s --rxq=%s --txd=4096 --rxd=4096"
+                                 % (utils.create_mask(self.ports),queue_num,queue_num), socket=self.ports_socket)
 
         for i in range(3):
-            rxqid = randint(0, 16)
+            rxqid = randint(0, queue_num-1)
             self.desc = randint(0, 4095)
             out = self.dut.send_expect("show port %s rxq %s desc %s status" % (self.ports[0], rxqid, self.desc), "testpmd> ")
             self.verify(
@@ -805,7 +810,7 @@ class TestShutdownApi(TestCase):
             self.verify(
                 "Bad arguments" not in out and "Invalid queueid" not in out,
                 "RX descriptor status is not supported")
-            txqid = randint(0, 16)
+            txqid = randint(0, queue_num-1)
             self.desc = randint(0, 511)
             out = self.dut.send_expect("show port %s txq %s desc %s status" % (self.ports[0], txqid, self.desc), "testpmd> ")
             self.verify(
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4
  2020-07-16  7:45 [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4 xizhan4x
@ 2020-07-16  7:45 ` Zhang, XiX
  2020-07-24  2:18 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, XiX @ 2020-07-16  7:45 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]

Tested-by: Zhang, XiX <xix.zhang@intel.com>

-----Original Message-----
From: Zhang, XiX 
Sent: Thursday, July 16, 2020 3:45 PM
To: dts@dpdk.org
Cc: Zhang, XiX <xix.zhang@intel.com>
Subject: [dts][PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4

The maximum number of queues for springville  is 4

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_shutdown_api.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 650ccfc..3f42f93 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -793,10 +793,15 @@ class TestShutdownApi(TestCase):
         When rx_descriptor_status is used, status can be “AVAILABLE”, “DONE” or “UNAVAILABLE”.
         When tx_descriptor_status is used, status can be “FULL”, “DONE” or “UNAVAILABLE.”
         """
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --txq=16 --rxq=16 --txd=4096 --rxd=4096" % utils.create_mask(self.ports), socket=self.ports_socket)
+        queue_num=16
+        if self.nic in ["springville"]:
+            queue_num=4
+        self.pmdout.start_testpmd("Default",
+                                 "--portmask=%s --port-topology=loop --txq=%s --rxq=%s --txd=4096 --rxd=4096"
+                                 % 
+ (utils.create_mask(self.ports),queue_num,queue_num), 
+ socket=self.ports_socket)
 
         for i in range(3):
-            rxqid = randint(0, 16)
+            rxqid = randint(0, queue_num-1)
             self.desc = randint(0, 4095)
             out = self.dut.send_expect("show port %s rxq %s desc %s status" % (self.ports[0], rxqid, self.desc), "testpmd> ")
             self.verify(
@@ -805,7 +810,7 @@ class TestShutdownApi(TestCase):
             self.verify(
                 "Bad arguments" not in out and "Invalid queueid" not in out,
                 "RX descriptor status is not supported")
-            txqid = randint(0, 16)
+            txqid = randint(0, queue_num-1)
             self.desc = randint(0, 511)
             out = self.dut.send_expect("show port %s txq %s desc %s status" % (self.ports[0], txqid, self.desc), "testpmd> ")
             self.verify(
--
1.8.3.1


[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 730972 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4
  2020-07-16  7:45 [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4 xizhan4x
  2020-07-16  7:45 ` Zhang, XiX
@ 2020-07-24  2:18 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-07-24  2:18 UTC (permalink / raw)
  To: Zhang, XiX, dts; +Cc: Zhang, XiX

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> Sent: 2020年7月16日 15:45
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The
> maximum number of queues for springville is 4
> 
> The maximum number of queues for springville  is 4
> 
> Signed-off-by: xizhan4x <xix.zhang@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index 650ccfc..3f42f93 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -793,10 +793,15 @@ class TestShutdownApi(TestCase):
>          When rx_descriptor_status is used, status can be “AVAILABLE”, “DONE” or
> “UNAVAILABLE”.
>          When tx_descriptor_status is used, status can be “FULL”, “DONE” or
> “UNAVAILABLE.”
>          """
> -        self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --txq=16 --rxq=16 --txd=4096 --rxd=4096" %
> utils.create_mask(self.ports), socket=self.ports_socket)
> +        queue_num=16
> +        if self.nic in ["springville"]:
> +            queue_num=4
> +        self.pmdout.start_testpmd("Default",
> +                                 "--portmask=%s --port-topology=loop --txq=%s --rxq=%s --
> txd=4096 --rxd=4096"
> +                                 %
> + (utils.create_mask(self.ports),queue_num,queue_num),
> + socket=self.ports_socket)
> 
>          for i in range(3):
> -            rxqid = randint(0, 16)
> +            rxqid = randint(0, queue_num-1)
>              self.desc = randint(0, 4095)
>              out = self.dut.send_expect("show port %s rxq %s desc %s status" %
> (self.ports[0], rxqid, self.desc), "testpmd> ")
>              self.verify(
> @@ -805,7 +810,7 @@ class TestShutdownApi(TestCase):
>              self.verify(
>                  "Bad arguments" not in out and "Invalid queueid" not in out,
>                  "RX descriptor status is not supported")
> -            txqid = randint(0, 16)
> +            txqid = randint(0, queue_num-1)
>              self.desc = randint(0, 511)
>              out = self.dut.send_expect("show port %s txq %s desc %s status" %
> (self.ports[0], txqid, self.desc), "testpmd> ")
>              self.verify(
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-24  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16  7:45 [dts] [PATCH V1] TestSuite_shutdown_api/check_rxtx_desc_status:The maximum number of queues for springville is 4 xizhan4x
2020-07-16  7:45 ` Zhang, XiX
2020-07-24  2:18 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).