test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error
@ 2020-01-22  9:05 Zhou,JunX W
  2020-01-22  9:31 ` Zeng, XiaoxiaoX
  0 siblings, 1 reply; 2+ messages in thread
From: Zhou,JunX W @ 2020-01-22  9:05 UTC (permalink / raw)
  To: dts; +Cc: Zhou,JunX W

dev_strt2 is not define,dev_str2 is right;
There should be only two '%' in 'self.dut.send_expect("./%s/app/test %s %s"'

Signed-off-by: Zhou,JunX W <junx.w.zhou@intel.com>
---
 tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
index 49895a1..19abb6e 100644
--- a/tests/TestSuite_unit_tests_ringpmd.py
+++ b/tests/TestSuite_unit_tests_ringpmd.py
@@ -80,8 +80,8 @@ class TestUnitTestsRingPmd(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
 
-        eal_params = self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_strt2])
-        self.dut.send_expect("./%s/app/test %s %s" % (self.target, eal_params), "R.*T.*E.*>.*>", 10)
+        eal_params = self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_str2])
+        self.dut.send_expect("./%s/app/test %s" % (self.target, eal_params), "R.*T.*E.*>.*>", 10)
         out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Two eth_ring devices test failed")
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error
  2020-01-22  9:05 [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error Zhou,JunX W
@ 2020-01-22  9:31 ` Zeng, XiaoxiaoX
  0 siblings, 0 replies; 2+ messages in thread
From: Zeng, XiaoxiaoX @ 2020-01-22  9:31 UTC (permalink / raw)
  To: Zhou, JunX W, dts; +Cc: Zhou, JunX W

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]


Tested_by: Zeng,XiaoxiaoX<xiaoxiaox.zeng@intel.com>


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhou,JunX W
> Sent: Wednesday, January 22, 2020 5:06 PM
> To: dts@dpdk.org
> Cc: Zhou, JunX W <junx.w.zhou@intel.com>
> Subject: [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and
> string concatenation error
> 
> dev_strt2 is not define,dev_str2 is right; There should be only two '%' in
> 'self.dut.send_expect("./%s/app/test %s %s"'
> 
> Signed-off-by: Zhou,JunX W <junx.w.zhou@intel.com>
> ---
>  tests/TestSuite_unit_tests_ringpmd.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py
> b/tests/TestSuite_unit_tests_ringpmd.py
> index 49895a1..19abb6e 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -80,8 +80,8 @@ class TestUnitTestsRingPmd(TestCase):
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Default no eth_ring devices Test failed")
> 
> -        eal_params =
> self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_strt2
> ])
> -        self.dut.send_expect("./%s/app/test %s %s" % (self.target,
> eal_params), "R.*T.*E.*>.*>", 10)
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.cores,vdevs=[dev_str1,dev_str2])
> +        self.dut.send_expect("./%s/app/test %s" % (self.target,
> + eal_params), "R.*T.*E.*>.*>", 10)
>          out = self.dut.send_expect("ring_pmd_autotest", "RTE>>", 120)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Two eth_ring devices test failed")
> --
> 2.17.2


[-- Attachment #2: TestUnitTestsRingPmd.log --]
[-- Type: application/octet-stream, Size: 7556 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22  9:05 [dts] [PATCH V1] tests/unit_tests_ringpmd:Fix variable name and string concatenation error Zhou,JunX W
2020-01-22  9:31 ` Zeng, XiaoxiaoX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox