From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40054.outbound.protection.outlook.com [40.107.4.54]) by dpdk.org (Postfix) with ESMTP id 320EF5F11 for ; Fri, 2 Mar 2018 07:58:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Peh9XQim71iwmoSVJ8hYxW6rGSaDlEEB1PQSRHakvyU=; b=Dr1May7TkViYltdlUUSjLaWBtWv0FPWpwXnUMGG34pf5kqdopRIYKu9jA42X8dM1NlXkKN6NxGGS3StBGc3LUNkFKfMBY311FhlITfF2LJycGZRQpT2rs/envbaPNRcDELbN/N/JCxszUjijunqThYybLtL+xzKpEJDvzLLLQVU= Received: from HE1PR08MB2809.eurprd08.prod.outlook.com (10.170.246.148) by HE1PR08MB0907.eurprd08.prod.outlook.com (10.166.125.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Fri, 2 Mar 2018 06:57:56 +0000 Received: from HE1PR08MB2809.eurprd08.prod.outlook.com ([fe80::b1ec:c4d1:7ea4:930d]) by HE1PR08MB2809.eurprd08.prod.outlook.com ([fe80::b1ec:c4d1:7ea4:930d%13]) with mapi id 15.20.0548.014; Fri, 2 Mar 2018 06:57:56 +0000 From: Herbert Guan To: "Liu, Yong" , "dts@dpdk.org" CC: nd Thread-Topic: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AQHTscs97QlLlGAMbkG08/vzmmkiAqO8gdaw Date: Fri, 2 Mar 2018 06:57:56 +0000 Message-ID: References: <1518589716-27299-1-git-send-email-herbert.guan@arm.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62FA5E0C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62FA5E0C@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Herbert.Guan@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR08MB0907; 7:EMOo/8l2e2YL4k6J9Yi91/k+M2YOC9lIeLJ8oAYL5crpyXJxDVFU5MKz1HW1HSpK1doplKFsS5GtWo+jl0yzuT9vkHLHWOQs9B/0u2LmS7isRpaAhYTJk6kurEmpnvWJrmYwlJzzF7FYmLPAuU8N5xZIPZ2B6Wb952Gu4pA0ZlfCmwmVMJtri90wXYKgucKe22YGBM6WsFCliVwwf3T5LhBnWY9OvTgn9tAckSbPcsLKEBAsL1FA6Kts3MAvwHsR x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7619d141-fe9f-410b-3e19-08d5800aedc2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR08MB0907; x-ms-traffictypediagnostic: HE1PR08MB0907: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231220)(944501236)(52105095)(10201501046)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR08MB0907; BCL:0; PCL:0; RULEID:; SRVR:HE1PR08MB0907; x-forefront-prvs: 05991796DF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(39380400002)(199004)(189003)(13464003)(6246003)(102836004)(2950100002)(8936002)(72206003)(33656002)(97736004)(6436002)(26005)(186003)(81166006)(81156014)(6506007)(66066001)(2900100001)(9686003)(55016002)(2906002)(53546011)(305945005)(7736002)(316002)(3846002)(2501003)(5250100002)(478600001)(25786009)(6116002)(106356001)(53936002)(99286004)(7696005)(105586002)(14454004)(55236004)(4326008)(110136005)(68736007)(5660300001)(3280700002)(229853002)(59450400001)(76176011)(86362001)(3660700001)(74316002)(575784001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0907; H:HE1PR08MB2809.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: amR5a5nUOZCisIo1hxBK5N9SZXBVOfs/dTqLZPhKh0f4PqlEaqZkyOEeUS3UufDk0bVFrph7iXpJucfsGk4V6+36mm20DoZbtnLK6nCVw12df2HQYOGPymCqmg4rXs/f4+QAoUs7Mv6V+qs/DY0sERwLPMPdAKKCUAQ8K0rXWdM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7619d141-fe9f-410b-3e19-08d5800aedc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2018 06:57:56.8032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0907 Subject: Re: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 06:58:00 -0000 Marvin, When the execution config file selects driver mode to a certain mode (vfio,= igb_uio, etc.), then both host and VM NICs will use this mode in case setu= p. If some case need VM to use the igb_uio mode, regardless of the driver = mode in execution configure file, we need to ensure the required drivers ha= ve been installed. =20 If we want to restore the environment, we need to add some extra logic to t= he case script. If the uio or igb_uio driver is not installed, then instal= l it and make flag. This script need to remove installed drivers that were= not installed before running the test. Best regards, Herbert > -----Original Message----- > From: Liu, Yong [mailto:yong.liu@intel.com] > Sent: Friday, March 2, 2018 10:08 > To: Herbert Guan ; dts@dpdk.org > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failure= s in > vf_reset >=20 > Hi Herbert, > Why required driver is not insmod be previous setup? > As one principle, we want to limit the influence of environment change in= the > suite. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan > > Sent: Wednesday, February 14, 2018 2:29 PM > > To: dts@dpdk.org > > Cc: Herbert Guan > > Subject: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures > > in vf_reset > > > > 1) Clear port stats before send/recv test packets > > 2) Ensure igb_uio driver is installed if driver=3D'igb_uio' > > > > > > Signed-off-by: Herbert Guan > > --- > > tests/TestSuite_vf_packet_rxtx.py | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > b/tests/TestSuite_vf_packet_rxtx.py > > index 63f4820..f0b7721 100644 > > --- a/tests/TestSuite_vf_packet_rxtx.py > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > @@ -125,6 +125,9 @@ class TestVfPacketRxtx(TestCase): > > def packet_rx_tx(self, driver=3D'default'): > > > > if driver =3D=3D 'igb_uio': > > + # ensure igb_uio driver is installed > > + self.dut.send_expect('(lsmod | grep uio) || (modprobe > > + uio)', > > '#') > > + self.dut.send_expect('(lsmod | grep igb_uio) || > > (insmod ./%s/kmod/igb_uio.ko)' % self.target,'#') > > self.setup_2pf_2vf_1vm_env(driver=3D'igb_uio') > > else: > > self.setup_2pf_2vf_1vm_env(driver=3D'') > > @@ -279,6 +282,7 @@ class TestVfPacketRxtx(TestCase): > > rx_port =3D tx_port > > > > dst_mac =3D pmd0_vf0_mac > > + self.vm0_testpmd.execute_cmd('clear port stats all') > > self.tester.sendpkt_bg(tx_port, dst_mac) > > > > #vf port stop/start can trigger reset action > > -- > > 1.8.3.1