From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E43B4A0471 for ; Wed, 14 Aug 2019 16:20:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F2111B19; Wed, 14 Aug 2019 16:20:24 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AD2A81252 for ; Wed, 14 Aug 2019 16:20:22 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7EEKM16022215; Wed, 14 Aug 2019 07:20:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=kwxv3TiCIRWMLlvbGff0hRzvzYimRbebPbF3oXsscm0=; b=TmntjppP/OFb6Dtc0ZnCNuds0mHoQmChgckiNIFzfaTdVQsD6avR0WFVgR0H0EUWREhI 0W/DDkgcc6qPuvuOg2arg+CKkhVr1Fy+/wfHFf06GHOqZannnT8Z/S/mIJHMp7+K/n5n MqHv+kH1UQw5g8bXS2pmNfdJtZROiMYEwlb7vgLCCCYIFF2vaA49fHxdGTJKKPOd8SjD llaKX/gNu5nOMaYB3hjNU84U7GpwEd2QiuN8p7S3jSwUs4pa81pLxC6cOsC820OQ5xpy ZVSbSSffqRjxoXgFP+mn+DJkRChmk9KCXuPgJ38gFRJs0q1h3MSutnbuSU/py09hawp5 eQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2ubfabfbr1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2019 07:20:21 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 14 Aug 2019 07:20:15 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.59) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 14 Aug 2019 07:20:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQJSMKkGTVoKrMeQl0OXBI97kl8hT7G2tLvwdsd8iPoVyxCUradpfu1un7fwp2lVy95tMvjljxhduQGskIMM3iSVTbqUyaUNMAE6kyIQvRvKljLFdFG81n9LDyYMX0DNogmNOioICj0DyTm3qf0A2XSR62hC8nR/hA7eBCOhGuVkeH8KBlXD14S5TbSROYLrFIFKuFYza57os3Jqjr/fpHtGR20rKH27FAawU3VeJywlCJUNQfHFe464NR6yXu/0KnIzb4+gbzbr4P7IBt7Ji8HJfvpG3MrHNenRSeRW+VFTc3XTi+VDzvxKX0eBzzBIABPujVNm2SkRdhfues3a3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwxv3TiCIRWMLlvbGff0hRzvzYimRbebPbF3oXsscm0=; b=PCp8WYo165yGT38lmmQE8zUlFPPl8Nb+M8OHx3xoStvaxiXVntXYEuIQM0LP3qv4eFKcPMYoQ+VgIaMfPDXNHk/zyf1twJ8CZ0PtbnsglimlFUaltrK8YIs7S6qVRCNVQrSPiZgstL1bulGZn0UhJjAEXd7PT7AOlxYSKN2EaPJUU7zBLOS9sKKPIcxBmmuExzIwuqxNx3RpK9WyGSYXnuPRqmWqbWC+J/f6Cz8lMqn1Lyy7ksID6c0r/2/5tCcGEtSAxM6K+ZS6rWiA5QT3s0mDcINRKbARN8MqG9vntWVja2kXRYNADXRR0rImNx3gfh5dkLOazRIzoWbxYodKNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwxv3TiCIRWMLlvbGff0hRzvzYimRbebPbF3oXsscm0=; b=b3eNmhEfgmE3v69Lf86sHHpbkDUtlbVk9yDhCB/X8jcm4Pgjno+Wtm8tVTmaEpapiUoavrXVFvDW75S2HQxxFuuqOpUsAow7fvW5kucbiD22kKKEQnnNjz2olC1fsphSSR8emjZ9/8oKa9484yjwsWkf1r7ba2kTIl0LYPBBdO0= Received: from MN2PR18MB2704.namprd18.prod.outlook.com (20.178.255.93) by MN2PR18MB2575.namprd18.prod.outlook.com (20.179.82.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Wed, 14 Aug 2019 14:20:11 +0000 Received: from MN2PR18MB2704.namprd18.prod.outlook.com ([fe80::6068:2e30:5b5:7c07]) by MN2PR18MB2704.namprd18.prod.outlook.com ([fe80::6068:2e30:5b5:7c07%5]) with mapi id 15.20.2157.022; Wed, 14 Aug 2019 14:20:11 +0000 From: Phanendra Vukkisala To: "Chen, Zhaoyan" , "Tu, Lijuan" , "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood , "Mo, YufengX" Thread-Topic: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership Thread-Index: AQHVTrElwGBuCPlDJU2NgECm2FckVqb3GZ+AgAAIGoCAA5ZIMA== Date: Wed, 14 Aug 2019 14:20:10 +0000 Message-ID: References: <1565355071-16059-1-git-send-email-pvukkisala@marvell.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BB018CE@SHSMSX101.ccr.corp.intel.com> <9DEEADBC57E43F4DA73B571777FECECA41D7D35B@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <9DEEADBC57E43F4DA73B571777FECECA41D7D35B@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6a29f1e-26e7-42d3-c343-08d720c28462 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2575; x-ms-traffictypediagnostic: MN2PR18MB2575: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 01294F875B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(13464003)(199004)(189003)(186003)(2501003)(74316002)(305945005)(7696005)(26005)(14444005)(256004)(2906002)(76176011)(66476007)(64756008)(3846002)(66946007)(76116006)(66556008)(66446008)(86362001)(8676002)(52536014)(5660300002)(7736002)(6116002)(229853002)(55016002)(71200400001)(6246003)(53936002)(33656002)(9686003)(478600001)(14454004)(6436002)(25786009)(99286004)(71190400001)(4326008)(110136005)(54906003)(66066001)(53546011)(6506007)(55236004)(102836004)(316002)(476003)(11346002)(446003)(8936002)(81166006)(81156014)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2575; H:MN2PR18MB2704.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gc+9E2tDu5yZbgQwzh2BUaRLu8MxnxKDw53LweUUgd29q6tsnz/LhvWGzBacHXdMKLPLHq+4OJbG4aAUxfbK9BXY6c0iXfWO4kiAMdd0dh5j8tqgsunAQ4ywvZXI24y1m8AciP+cb68vjTLSCtoEGMY7PWABcA8VHTaqDAfirszd2BR+ukUFoT0LlG1JBIZasrNWMjE6O0b3xCuSQs+OwNrvlYbHNRX2Ku+MC1Rl5eG+K3Eu4QrK3XbEdaQLVHZtD+SmVIZ3ROrpRL3Qpo/eH/KfZBLmlZ7apczey7J85CW+TfwbX4CURPHR0Vg/b+ptjRJGeIwZADUF9HMm3iotSU92A+OlRiOUWgXeMGZYBydSk3af3DBC8QnQhIYQAVRSzyya3CIQdHqRtTzOOavKTw72sig+LSjOg3MIoJimWFs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d6a29f1e-26e7-42d3-c343-08d720c28462 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2019 14:20:11.0935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ondF6R+WIJFlVIsMQh1VT7YY26XucvxlO8LU4kJnbvLCTiaF1RIlP62X/qnP1qXELV9SpRPN6re7z6f20xbYqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2575 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-14_05:2019-08-14,2019-08-14 signatures=0 Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi Zhaoyan Chen, Thanks, submitted the patch to fix in new pktgen API.=20 I'm aware of changes in Introduction of new pktgen APIs in DTS. I yet to sw= itch to new DTS source base, so I'm still using etgen.=20 Regards, Phanendra -----Original Message----- From: Chen, Zhaoyan =20 Sent: Monday, August 12, 2019 12:59 PM To: Tu, Lijuan ; Phanendra Vukkisala ; dts@dpdk.org Cc: Vijaya Bhaskar Annayyolla ; Faisal Masood ; Mo, YufengX ; Chen, Zhaoyan Subject: [EXT] RE: [dts] [PATCH] IXIA: Exit on failure of clear/take port o= wnership External Email ---------------------------------------------------------------------- Thanks, Vukkisala, Good fixing on etgen.py, however, we are going to remove the etgen API in f= uture.=20 Because there is a new pktgen API developed in DTS framework, which support= not only IXIA but also TREX (SW). They have unified packet generator API, = so you need to modify nothing in the test suite, if you change the packet g= enerator in test environment. So we encourage you to try this new unified API for your performance test s= uite. We have several documents for you to migrate from old etgen API under doc f= older - migrate_from_etgen_to_pktgen.rst - pktgen_prog_guide.rst - trex_known_issue.rst Furthermore, your fixing seems also valid for the new pktgen API. Could you= please generate 1 more patch for it? BTW, how many test suite you are using with etgen in DTS? What are they? Any problem, please let me know. Thanks. Regards, Zhaoyan Chen > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan > Sent: Monday, August 12, 2019 3:00 PM > To: pvukkisala@marvell.com; dts@dpdk.org > Cc: avijay@marvell.com; fmasood@marvell.com > Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port=20 > ownership >=20 > Applied, thanks >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of=20 > > pvukkisala@marvell.com > > Sent: Friday, August 9, 2019 8:51 PM > > To: dts@dpdk.org > > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala=20 > > > > Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port=20 > > ownership > > > > From: Phanendra Vukkisala > > > > Signed-off-by: Phanendra Vukkisala > > --- > > framework/etgen.py | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/framework/etgen.py b/framework/etgen.py index=20 > > 212b9c2..a47d8cd 100644 > > --- a/framework/etgen.py > > +++ b/framework/etgen.py > > @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection): > > out =3D self.send_expect("set chasId [ixGetChassisID %s]" %=20 > > self.tclServerIP, "% ") > > self.chasId =3D int(out.strip()) > > > > - self.send_expect("ixClearOwnership [list %s]" % string.join( > > + out =3D self.send_expect("ixClearOwnership [list %s]" %=20 > > + string.join( > > ['[list %d %d %d]' % (self.chasId, item['card'], > > item['port']) for item in self.ports], ' '), "% ", 10) > > - self.send_expect("ixTakeOwnership [list %s] force" % string.jo= in( > > + if out.strip()[-1] !=3D '0': > > + return False > > + out =3D self.send_expect("ixTakeOwnership [list %s] force" %=20 > > + string.join( > > ['[list %d %d %d]' % (self.chasId, item['card'], > > item['port']) for item in self.ports], ' '), "% ", 10) > > + if out.strip()[-1] !=3D '0': > > + return False > > > > return True > > > > -- > > 1.7.9.5