From: Phanendra Vukkisala <pvukkisala@marvell.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>,
Faisal Masood <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
Date: Mon, 7 Jan 2019 09:38:38 +0000 [thread overview]
Message-ID: <MN2PR18MB270440B14469D4E9D9F3E83DDD890@MN2PR18MB2704.namprd18.prod.outlook.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDF6B@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 8852 bytes --]
Hi Lijuan,
I can add these tests in "test_case_checklist.json" as these are not supported on cavium devices.
But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in supportlist.json
For instance: the syn_filter test is supported by Niantic, kawela_4, bartonhills, powerville. I have taken this reference from test scripts.
Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.
def test_syn_filter(self):
"""
Enable receipt of SYN packets
"""
self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support syn filter" % self.nic)
If you fell I should update in "test_case_checklist.json" for cavium device only, please let me know I will do the same.
Regards,
Phanendra
________________________________
From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Monday, January 7, 2019 2:13:59 PM
To: Phanendra Vukkisala; dts@dpdk.org
Cc: Vijaya Bhaskar Annayyolla; Faisal Masood
Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
External Email
----------------------------------------------------------------------
Hi phanendra,
If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.
For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.
"syn_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "kawela_4",
> + "bartonhills",
> + "powerville"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case not support on this NIC"
> + }
> + ],
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
>
> From: pvukkisala <pvukkisala@marvell.com>
>
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
> conf/test_case_supportlist.json | 201
> +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 201 insertions(+)
>
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
> "Bug ID": "",
> "Comments": "This case only support on FVL"
> }
> + ],
> + "syn_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "kawela_4",
> + "bartonhills",
> + "powerville"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case not support on this NIC"
> + }
> + ],
> + "priority_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "kawela_4",
> + "bartonhills",
> + "powerville"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case not support on this NIC"
> + }
> + ],
> + "five_tuple_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "kawela_4"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case only support only on Niantic and
> kawela_4"
> + }
> + ],
> + "ethertype_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "kawela_4",
> + "bartonhills",
> + "powerville",
> + "fortville_eagle",
> + "fortville_spirit",
> + "fortville_spirit_single",
> + "fortpark_TLV",
> + "fortville_25g"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> + ],
> + "multiple_filters_10GB": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case only support with Niantic NIC"
> + }
> + ],
> + "twotuple_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "powerville",
> + "bartonhills"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> + ],
> + "flex_filter": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "powerville",
> + "bartonhills"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> + ],
> + "multiple_filters_1GB": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "powerville",
> + "kawela_4",
> + "bartonhills"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> + ],
> + "128_queues": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "niantic",
> + "ironpond",
> + "twinpond",
> + "twinville",
> + "sageville",
> + "sagepond",
> + "magnolia_park",
> + "springfountain"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case only support with ixgbe driver"
> + }
> + ],
> + "rss_key_size": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "fortville_eagle",
> + "fortville_spirit",
> + "fortville_spirit_single",
> + "fortville_25g",
> + "niantic",
> + "redrockcanyou",
> + "atwood",
> + "boulderrapid",
> + "fortpark_TLV"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> + ],
> + "vlan_qinq_tpid": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "fortville_eagle",
> + "fortville_spirit",
> + "fortville_spirit_single"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "This case is not supported on this NIC"
> + }
> ]
> }
> --
> 1.7.9.5
[-- Attachment #2: Type: text/html, Size: 32335 bytes --]
next prev parent reply other threads:[~2019-01-07 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 8:59 Phanendra Vukkisala
2019-01-07 8:43 ` Tu, Lijuan
2019-01-07 9:38 ` Phanendra Vukkisala [this message]
2019-01-07 10:42 ` Tu, Lijuan
2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
2019-01-09 11:08 ` Lijuan Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB270440B14469D4E9D9F3E83DDD890@MN2PR18MB2704.namprd18.prod.outlook.com \
--to=pvukkisala@marvell.com \
--cc=avijay@marvell.com \
--cc=dts@dpdk.org \
--cc=fmasood@marvell.com \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).