From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0EBFA034F; Tue, 30 Mar 2021 04:19:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A686140F35; Tue, 30 Mar 2021 04:19:26 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 30CAD406B4 for ; Tue, 30 Mar 2021 04:19:24 +0200 (CEST) IronPort-SDR: uN9zR2oveLhamD94xfXUHXSApYq/FkXl+4z/tm1eiO99Ndfraphp8cZPHrD1USnZ30QkzIoYLD gWX2/YSaWNjg== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="171071049" X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="171071049" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 19:19:22 -0700 IronPort-SDR: VEC9sX4lMP8fM2jg0AbVoYvtG+SlaRFL1JjSeK/UVIw2EmVmLKTW47N3MWUjS9omurpOPDSOGJ UwwnJCT2hCBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="445014646" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 29 Mar 2021 19:19:22 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 29 Mar 2021 19:19:22 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 29 Mar 2021 19:19:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 29 Mar 2021 19:19:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 29 Mar 2021 19:19:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7SsgICX5IDfoC2Cj2xtDZdyDSyMBrj25nU+CCQDPOSjxlnbIe7cs3FihmCgXs1gI5iFkf1/EhCrV5TesIPxClr4LBS5b2gXDIH6muHkme1up9BTlk+f6xvLn83kyRuRthWCFFXVSTSXiPo3gWu8VerEEim3i9MlzoptrZiAdhKV1kJ6h1R8fOJqA3uX9xbni4yNYKQClxUUQ1/gQ+jbbZXeFIix6KixP9KEB33JuYtF/vUsXu1eBbqyrwSj18zri8lbwn0hOk0gLEbZwoUtIsfvxXdde8KLwkvAkbO0ylHlCUu4pWtJjNYawOmUKDx+uTvll79Wb2jIW6gUcJtHLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/zQO1+r/wSmXd5INpJP4YRYlqlULRDwSzbebF6kYSw=; b=I3vvLN+PsMYog/3Vzpys0G/No2oFC9lg77A6ed/N880n6KdGAEfW8oxei3Mpf/yAYarvA+o2R/fjbnbRtwHgOx9d1ladHn7sMmo10Ij8CMk9zxU/mmHEYEWgyx5QnBZB5Vi4TqwyNJNw4cpVynSTCDJQrXY0f7dnoEIzJR8MJ+pmvwPlKlhJkmA2hL8rRFF/CoKwixDl96kWlcC+kc4sWlrsKzsgbVH3cRbhILLC2k8sZPbHF6BmXWR2Q6c4FtSLELDpq+APlMt5Y1cBEuMY6io1/lphCf0lIygLLg/BLw/Qidtss8vQFSjztnt/p87Ek2XscGJyAgXwzSftqEamPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/zQO1+r/wSmXd5INpJP4YRYlqlULRDwSzbebF6kYSw=; b=FHpvWKcIDJYmDWWJxczw5wc1t9IHuaMSbDpBsWicd4k7pSw0KPmt4LOyF64c/e/XuVMb2g7kkOKcu93pCkkIESnAlH0hxcFvGz0xVabzwW8Yc5TZqWZtEIr8KeuLS6oTTOuf/lsmCC7DwKnUX9qISt/jJdotlhLX9k5xvPujRRo= Received: from MWHPR11MB1328.namprd11.prod.outlook.com (2603:10b6:300:2b::19) by CO1PR11MB4865.namprd11.prod.outlook.com (2603:10b6:303:9c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Tue, 30 Mar 2021 02:19:19 +0000 Received: from MWHPR11MB1328.namprd11.prod.outlook.com ([fe80::ec53:b804:e1fa:32bd]) by MWHPR11MB1328.namprd11.prod.outlook.com ([fe80::ec53:b804:e1fa:32bd%10]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 02:19:19 +0000 From: "Huang, ZhiminX" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1 1/2] remove reload ice code Thread-Index: AQHXIf/IpSht+sZRuE211/JRJYzigqqbxvEAgAAC41A= Date: Tue, 30 Mar 2021 02:19:18 +0000 Message-ID: References: <1616735292-74549-1-git-send-email-zhiminx.huang@intel.com> <1616735292-74549-2-git-send-email-zhiminx.huang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.56] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 533ffd7e-ce64-439d-32f0-08d8f3223996 x-ms-traffictypediagnostic: CO1PR11MB4865: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:372; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OFP4S5Ho5XbL/q3GRjcpYG/MYUYwlRQdur3WWDlzBeP8pViwpCIGbbXgJBFWFopgmwTSBfGaReFy5NYKJnqK7pWTisx74wAxo7Z97+oNO4qC/2yn6VIT9/mEtvxeeJuXFiJnQ8Nj7GlQFy614zfJbkNWtkoKI7qSFUQ8X6AN8nJcVgHsq1wxzeNeyakOMY3qiy+Fyu4NsIOFD8Y+pUPftR+vcIPcA7zckPOq9njm2zNUyxjSCLAlIp6FxcabzlTdW5BJ5kYtJAc/SZyh+CUcCOMMqd+fyq5q2JEIGjkjD/YWWVVQmndXvACYqyjwwtoCQf3HYjbQkFiI5Za0mUiqPeBsLJuPIGfXr7qgAocUuHoc1Qhbp9H53YlgblyEKceVG6FEfAuMmI2hcOarDw/eGGNeKtyh+nn7+cW0c6zjX6wAIsQaw8cqOR0T3wT8htMcIru/gjHCswKArvUhMogT56Vqb0wT0DkGlwr/TWqseUpfqJFjmnBC4LSXtp53RKBhX5QgW9+Lwzsk6bAcE7BO4mIIzwQmmMGBSOmFYmvEYvnXfhW9mNmGrURSxgr9Kbkwrd26d2g3IxpOrkm/Z373ggCUsQR4NHopoQi2on7zi+sbmldBFvrUU6J9qHRQj6nGjz3JtTerpnFby4L1XE8IeJJGFMLnDU5JCPTissatsgU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1328.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(396003)(136003)(366004)(346002)(316002)(66556008)(2906002)(76116006)(66476007)(53546011)(9686003)(186003)(6506007)(38100700001)(110136005)(7696005)(33656002)(478600001)(8676002)(71200400001)(52536014)(83380400001)(26005)(5660300002)(55016002)(64756008)(66446008)(8936002)(66946007)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?VXplcnhnbEJYK3NsTDl6dm5seStrZDR2WUVQbXlEV1NueHVpZE1vMDVq?= =?iso-2022-jp?B?Z3RXTjVSeDVrTjltb1EwTEFvWWpNeUN4ckQxOWNENjNBbDdESzJSSkhk?= =?iso-2022-jp?B?NzBCRzZLdXZDeDZjTDNEWmg1eVcvM2RyMjlKMnc4OXE2OGFmSDl1UENB?= =?iso-2022-jp?B?VjYramlaL1pEaWlrUEIyMXFuNTd2L3dhaGhhZFhZWmdMcitiR3BDVngy?= =?iso-2022-jp?B?a0QxeWx5N3dNc3A3VW9VelRxeW1pc0hSbG1UMVNoeVl1VHhFaDhEbXZ3?= =?iso-2022-jp?B?SnRFVldsVXpITkpucUhTRStJMGVHcnlYUmNvL0c3OHpuREJoZWF3NVBV?= =?iso-2022-jp?B?b21ud29LN0JwY241ZFh5SWIvS2lkcjVUQU51d1VRS0QrR3NXYThIUGlR?= =?iso-2022-jp?B?YmhuT0dIcW1vY0NQWU9oVHBZcFA1SkRvQWlSd0o5TFI5WUV4aThaK3Ry?= =?iso-2022-jp?B?Ykc2bG5mQ3pwei8raUF0OTNhdFlIdDJ6dEk5SS9waEdjUDlCanMxazFR?= =?iso-2022-jp?B?N1RIYjBGVklzQTN0cVFxbHc4c082U0tIak90bW9qeWIreWZ0V2VBcWVq?= =?iso-2022-jp?B?cjFKajBzU3pQZnVYTmg2N2JUOHVQTUVDNkxMMCtwMFR2bG1SWk5FQ1FN?= =?iso-2022-jp?B?RE9wZlFPZ1VJdjk0SGpJWnV2WmVGeG5vL1dmdzQySU5SOEdzek5OK1Ey?= =?iso-2022-jp?B?QWtWK0VvMDBjaElXVk1FdmJVSDNHcDlOeVhaY2FqV0xoeCtTVmhRUHlh?= =?iso-2022-jp?B?N2JaYW1DampFdktqRTJxbmxtbC9vY3J3Vm93cTdCc0x0TG4reDljcDA1?= =?iso-2022-jp?B?MjZOTEgyN21KZUFJRWJHMGlYVGNLWGZnRmlUOU5CekJTUUdYME5XSFpa?= =?iso-2022-jp?B?SjVQWUc5WSt4d29qTXM0OFBRcGw2cHNnTkNqemt6a08xb09EUG1NTTlR?= =?iso-2022-jp?B?SkpDTTBxKy9jTWthanM2Zm5tb0RxeElaYlI0Mm96SFBJRzdGT2ZRS3hV?= =?iso-2022-jp?B?YjAyY3M4dlZkdlpCWjd4THRkaFlKdjIzZXN5U1JIcnRUVEF2TXB6Mjha?= =?iso-2022-jp?B?SnE3dnpKeExENllUNThMbytnY1h5VnZ4dnlETHNEcDZobk9hQUw0enQy?= =?iso-2022-jp?B?cnhCMUk2bzB0Q3dCT2FMVHJDS0M5M0M3RnMzWTV5YlFCblIxWTlSN1lx?= =?iso-2022-jp?B?eFVNcy9KYVVvVS9YY1g2ME5rZWNOU29VUmQ4R0VwWVdNVDZZQzE4ZmRy?= =?iso-2022-jp?B?dDFNWlBHZ01oRS85SXBDZ3h5SFpLOWZtK0k1dlQ5UFJ3b1NMR3czTUwx?= =?iso-2022-jp?B?OU1aeW8wK0RxNTRKcXc2Z3Fza3Bqb2NCR1NyNHNpRitCR3VGR21ReEYy?= =?iso-2022-jp?B?WGJMUWtIT2R1NXQwMDBCK0tpMzlBa25vTEVlNXRsSTdHbEJ5ZFJ1cXdj?= =?iso-2022-jp?B?aGhWUmdueTIxSHVqZHhrQUJERE9WaG9rR1ZZR1NNZmowWjQwb2FtYWhF?= =?iso-2022-jp?B?QVpoTnZMcGNJMlgxTFI2emZSM0YyaUMrd0NrTVBLMmVJdHBJaFM0dERw?= =?iso-2022-jp?B?UTZPTGtFcko4NVA5UDAvQTB0SWNQdlBIbVlXSEYrOWNhUEl0SnRYK1Na?= =?iso-2022-jp?B?cGFpbVMwSW1HejQ5WFA2eDlkTlJNbHVaL2NmRjFBNUd6RVp1NHFzNktw?= =?iso-2022-jp?B?NEVnbWljNlo2V2JxWEcrN3ZVSmZmcFFpNHlYOFhTR1hpajRYbEx6QVpJ?= =?iso-2022-jp?B?alZpQzhRcnA5SzhJTU5Wb09LYzc3NC9aRnFDWVZRSWd2djhLNFZxenhR?= =?iso-2022-jp?B?UUs3SkhnRUxBQWVZd1B4aDQ3SVBpak5xNGZhRCt0eER1OG8vZVhxQkZa?= =?iso-2022-jp?B?dnFNNlFkNHNwVWhCSVYrczFlOFlNPQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1328.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 533ffd7e-ce64-439d-32f0-08d8f3223996 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 02:19:19.1448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V4x22AZmcFANFh17oGrXpeWxl9EYTf5cOCF1JR3bbMgHSAq+d8Hm2btoeMdhFVK9gygi4pgNDaWDRrbipYEtBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4865 X-OriginatorOrg: intel.com Subject: Re: [dts] [PATCH V1 1/2] remove reload ice code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" For the current framework design, the dts not to replace pkg for regression= . After we tested, cvl_limit_value_test and cvl_dcf_acl_filter suites support= os/comms/wireless pkg. so remove it. > -----Original Message----- > From: Tu, Lijuan > Sent: Tuesday, March 30, 2021 9:39 AM > To: Huang, ZhiminX ; dts@dpdk.org > Cc: Huang, ZhiminX > Subject: RE: [dts] [PATCH V1 1/2] remove reload ice code >=20 >=20 >=20 > > -----Original Message----- > > From: dts On Behalf Of Zhimin Huang > > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B26=1B$BF|=1B(B 13:08 > > To: dts@dpdk.org > > Cc: Huang, ZhiminX > > Subject: [dts] [PATCH V1 1/2] remove reload ice code > > > > *.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code > > > > Signed-off-by: Zhimin Huang > > --- > > tests/TestSuite_cvl_dcf_acl_filter.py | 16 ---------------- > > tests/TestSuite_cvl_limit_value_test.py | 15 --------------- > > 2 files changed, 31 deletions(-) > > > > diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py > > b/tests/TestSuite_cvl_dcf_acl_filter.py > > index 826da9c..1d516fc 100644 > > --- a/tests/TestSuite_cvl_dcf_acl_filter.py > > +++ b/tests/TestSuite_cvl_dcf_acl_filter.py > > @@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase): > > self.testpmd_status =3D "close" > > #bind pf to kernel > > self.bind_nics_driver(self.dut_ports, driver=3D"ice") > > - #move comms package to package folder > > - self.suite_config =3D rfc.get_suite_config(self) > > - comms_package_location =3D > > self.suite_config["comms_package_file_location"] > > - package_location =3D self.suite_config["package_file_location"= ] > > - self.dut.send_expect("cp %s %s" % (comms_package_location, > > package_location), "# ") > > - self.re_load_ice_driver() >=20 > this is part of set_up_all, so I thought the suite is designed for comms > package, but I saw you remove the replace, is that mean, the suite is als= o > qualified to test other ddp packages, e.g. OS package. > Could you please explain, why do the changes. Thanks. >=20 > > #set vf driver > > self.vf_driver =3D 'vfio-pci' > > self.dut.send_expect("modprobe uio", "# ") @@ -784,16 > +778,6 > > @@ class > > CVLDCFACLFilterTest(TestCase): > > port.bind_driver(self.vf_driver) > > time.sleep(15) > > > > - def re_load_ice_driver(self): > > - """ > > - remove and reload the ice driver > > - """ > > - ice_driver_file_location =3D > self.suite_config["ice_driver_file_location"] > > - self.dut.send_expect("rmmod ice", "# ", 60) > > - self.dut.send_expect("insmod %s" % ice_driver_file_location, > "# ", 60) > > - self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 1= 5) > > - self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "#= ", > 15) > > - > > def set_up(self): > > """ > > Run before each test case. > > diff --git a/tests/TestSuite_cvl_limit_value_test.py > > b/tests/TestSuite_cvl_limit_value_test.py > > index 77ce016..b806474 100644 > > --- a/tests/TestSuite_cvl_limit_value_test.py > > +++ b/tests/TestSuite_cvl_limit_value_test.py > > @@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase): > > self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0]) > > self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1]) > > > > - def re_load_ice_driver(self): > > - """ > > - remove and reload the ice driver > > - """ > > - ice_driver_file_location =3D > self.suite_config["ice_driver_file_location"] > > - self.dut.send_expect("rmmod ice", "# ", 15) > > - self.dut.send_expect("insmod %s" % ice_driver_file_location, > "# ", 60) > > - time.sleep(5) > > - > > def config_testpmd(self): > > self.pmd_output.execute_cmd("set fwd rxonly") > > self.pmd_output.execute_cmd("set verbose 1") @@ -813,12 > > +804,6 @@ class TestCvlLimitValue(TestCase): > > def test_max_rule_number(self): > > #bind pf to kernel > > self.bind_nics_driver(self.dut_ports, driver=3D"ice") > > - #move comms package to package folder > > - self.suite_config =3D rfc.get_suite_config(self) > > - comms_package_location =3D > > self.suite_config["comms_package_file_location"] > > - package_location =3D self.suite_config["package_file_location"= ] > > - self.dut.send_expect("cp %s %s" % (comms_package_location, > > package_location), "# ") > > - self.re_load_ice_driver() > > #set vf driver > > self.vf_driver =3D 'vfio-pci' > > self.dut.send_expect('modprobe vfio-pci', '#') > > -- > > 1.8.3.1 >=20