test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule
  2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
@ 2021-07-28  6:33   ` Huang, ZhiminX
  2021-08-04  2:21   ` Fu, Qi
  1 sibling, 0 replies; 9+ messages in thread
From: Huang, ZhiminX @ 2021-07-28  6:33 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Wednesday, July 28, 2021 11:04 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply
> ipfragment rule

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >



[-- Attachment #2: TestCvlIavfIpFragmentRteFlow.log --]
[-- Type: application/octet-stream, Size: 253428 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule
@ 2021-07-28 15:03 Zhimin Huang
  2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Zhimin Huang @ 2021-07-28 15:03 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.according to the change of dpdk, simply ipfragment rule

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 ...vl_iavf_ip_fragment_rte_flow_test_plan.rst | 38 +++++++++----------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/test_plans/cvl_iavf_ip_fragment_rte_flow_test_plan.rst b/test_plans/cvl_iavf_ip_fragment_rte_flow_test_plan.rst
index 6b2f82c9..9813b53c 100644
--- a/test_plans/cvl_iavf_ip_fragment_rte_flow_test_plan.rst
+++ b/test_plans/cvl_iavf_ip_fragment_rte_flow_test_plan.rst
@@ -111,9 +111,9 @@ take 'MAC_IPV4_FRAG fdir queue index' for fdir example
 ------------------------------------------------------
 1. validate and create rule::
 
-      flow validate 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 1 / mark / end
+      flow validate 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / mark / end
       Flow rule validated
-      flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 1 / mark / end
+      flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / mark / end
       Flow rule #0 created
 
 2. send matched pkts and check two pkts distributed to queue 1, `RSS hash=0x261a7deb - RSS queue=0x1` in output::
@@ -245,7 +245,7 @@ Subcase 1: MAC_IPV4_FRAG fdir queue index
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 1 / mark / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / mark / end
 
 2. matched packets::
 
@@ -260,7 +260,7 @@ Subcase 2: MAC_IPV4_FRAG fdir rss queues
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions rss queues 2 3 end / mark / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions rss queues 2 3 end / mark / end
 
 2. matched packets::
 
@@ -275,7 +275,7 @@ Subcase 3: MAC_IPV4_FRAG fdir passthru
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions passthru / mark / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions passthru / mark / end
 
 2. matched packets::
 
@@ -290,7 +290,7 @@ Subcase 4: MAC_IPV4_FRAG fdir drop
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions drop / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions drop / end
 
 2. matched packets::
 
@@ -305,7 +305,7 @@ Subcase 5: MAC_IPV4_FRAG fdir mark+rss
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions mark / rss / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions mark / rss / end
 
 2. matched packets::
 
@@ -320,7 +320,7 @@ Subcase 6: MAC_IPV4_FRAG fdir mark
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions mark id 1 / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions mark id 1 / end
 
 2. matched packets::
 
@@ -338,7 +338,7 @@ Subcase 1: MAC_IPV6_FRAG fdir queue index
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions queue index 1 / mark / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions queue index 1 / mark / end
 
 2. matched packets::
 
@@ -353,7 +353,7 @@ Subcase 2: MAC_IPV6_FRAG fdir rss queues
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions rss queues 2 3 / mark / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions rss queues 2 3 end / mark / end
 
 2. matched packets::
 
@@ -368,7 +368,7 @@ Subcase 3: MAC_IPV6_FRAG fdir passthru
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions passthru / mark / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions passthru / mark / end
 
 2. matched packets::
 
@@ -383,7 +383,7 @@ Subcase 4: MAC_IPV6_FRAG fdir drop
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions drop / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions drop / end
 
 2. matched packets::
 
@@ -398,7 +398,7 @@ Subcase 5: MAC_IPV6_FRAG fdir mark+rss
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions mark / rss / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions mark / rss / end
 
 2. matched packets::
 
@@ -413,7 +413,7 @@ Subcase 6: MAC_IPV6_FRAG fdir mark
 
 1. rules::
 
-     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions mark id 1 / end
+     flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions mark id 1 / end
 
 2. matched packets::
 
@@ -446,7 +446,7 @@ take 'mac_ipv4_frag_l3src_fdir_queue_index' example::
 
    1.rules:
 
-   flow create 0 ingress pattern eth / ipv4 src is 192.168.1.1 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 1 / mark / end
+   flow create 0 ingress pattern eth / ipv4 src is 192.168.1.1 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / mark / end
 
    2.matched packets:
 
@@ -473,7 +473,7 @@ take 'mac_ipv6_frag_l3src_fdir_queue_index' example::
 
    1.rules:
 
-   flow create 0 ingress pattern eth / ipv6 src is 2001::1 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions queue index 1 / mark / end
+   flow create 0 ingress pattern eth / ipv6 src is 2001::1 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions queue index 1 / mark / end
 
    2.matched packets:
 
@@ -544,7 +544,7 @@ Subcase 1: exclusive validation fdir rule
 1. create fdir filter rules::
 
      flow create 0 ingress pattern eth / ipv4 src is 192.168.0.20 / end actions queue index 1 / end
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 2 / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / end actions queue index 2 / end
 
 2. hit pattern/defined input set id, the pkt received for queue 2::
 
@@ -554,7 +554,7 @@ Subcase 2: exclusive validation fdir rule
 -----------------------------------------
 1. create fdir filter rules::
 
-     flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 2 / end
+     flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / end actions queue index 2 / end
      flow create 0 ingress pattern eth / ipv4 src is 192.168.0.20 / end actions queue index 1 / end
 
 2. hit pattern/defined input set id, the pkt received for queue 2::
@@ -568,7 +568,7 @@ Subcase 3: exclusive validation rss rule
      flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4 end key_len 0 queues end / end
      flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-frag end key_len 0 queues end / end
 
-2. hit pattern/defined input set id, the pkt received for rss diffent queue::
+2. hit pattern/defined input set id, the pkt received for rss same queue::
 
      p=Ether()/IP(id=47750)/Raw('X'*666); pkts=fragment6(p, 500)
      p=Ether()/IP(id=47751)/Raw('X'*666); pkts=fragment6(p, 500)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule
  2021-07-28 15:03 [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Zhimin Huang
@ 2021-07-28 15:04 ` Zhimin Huang
  2021-07-28  6:33   ` Huang, ZhiminX
  2021-08-04  2:21   ` Fu, Qi
  2021-08-04  2:23 ` [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Fu, Qi
  2021-09-13  4:39 ` Tu, Lijuan
  2 siblings, 2 replies; 9+ messages in thread
From: Zhimin Huang @ 2021-07-28 15:04 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.according to the change of dpdk code, simply ipfragment rule

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 ...TestSuite_cvl_iavf_ip_fragment_rte_flow.py | 38 +++++++++----------
 1 file changed, 18 insertions(+), 20 deletions(-)

diff --git a/tests/TestSuite_cvl_iavf_ip_fragment_rte_flow.py b/tests/TestSuite_cvl_iavf_ip_fragment_rte_flow.py
index b0e41a1b..3866fe72 100644
--- a/tests/TestSuite_cvl_iavf_ip_fragment_rte_flow.py
+++ b/tests/TestSuite_cvl_iavf_ip_fragment_rte_flow.py
@@ -43,7 +43,7 @@ LAUNCH_QUEUE = 16
 
 tv_mac_ipv4_frag_fdir_queue_index = {
     "name": "tv_mac_ipv4_frag_fdir_queue_index",
-    "rule": "flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 1 / mark / end",
+    "rule": "flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 1 / mark / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
@@ -52,8 +52,7 @@ tv_mac_ipv4_frag_fdir_queue_index = {
 
 tv_mac_ipv4_frag_fdir_rss_queues = {
     "name": "tv_mac_ipv4_frag_fdir_rss_queues",
-    "rule": ["flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions rss queues 2 3 end / mark / end",
-            "flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-frag end key_len 0 queues end / end"],
+    "rule": ["flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions rss queues 2 3 end / mark / end",],
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
@@ -62,16 +61,16 @@ tv_mac_ipv4_frag_fdir_rss_queues = {
 
 tv_mac_ipv4_frag_fdir_passthru = {
     "name": "tv_mac_ipv4_frag_fdir_passthru",
-    "rule": "flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions passthru / mark / end",
+    "rule": "flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions passthru / mark / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
-    "check_param": {"port_id": 0, "rxq": LAUNCH_QUEUE, "mark_id": 0}
+    "check_param": {"port_id": 0, "rxq": LAUNCH_QUEUE, "mark_id": 0, "rss": True}
 }
 
 tv_mac_ipv4_frag_fdir_drop = {
     "name": "tv_mac_ipv4_frag_fdir_drop",
-    "rule": "flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions drop / end",
+    "rule": "flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions drop / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
@@ -80,7 +79,7 @@ tv_mac_ipv4_frag_fdir_drop = {
 
 tv_mac_ipv4_frag_fdir_mark_rss = {
     "name": "tv_mac_ipv4_frag_fdir_mark_rss",
-    "rule": "flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions mark / rss / end",
+    "rule": "flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions mark / rss / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
@@ -89,7 +88,7 @@ tv_mac_ipv4_frag_fdir_mark_rss = {
 
 tv_mac_ipv4_frag_fdir_mark = {
     "name": "tv_mac_ipv4_frag_fdir_mark",
-    "rule": "flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions mark id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions mark id 1 / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"]
                   },
@@ -106,12 +105,12 @@ tvs_mac_ipv4_fragment_fdir = [
 ]
 
 tvs_mac_ipv4_fragment_fdir_l3src = [eval(str(element).replace('mac_ipv4_frag', 'mac_ipv4_frag_l3src')
-                                                     .replace('ipv4 packet_id', 'ipv4 src is 192.168.1.1 packet_id')
+                                                     .replace('ipv4 fragment_offset', 'ipv4 src is 192.168.1.1 fragment_offset')
                                                      .replace("IP(id=47750)", "IP(id=47750, src='192.168.1.1')"))
                                     for element in tvs_mac_ipv4_fragment_fdir]
 
 tvs_mac_ipv4_fragment_fdir_l3dst = [eval(str(element).replace('mac_ipv4_frag', 'mac_ipv4_frag_l3dst')
-                                                     .replace('ipv4 packet_id', 'ipv4 dst is 192.168.1.2 packet_id')
+                                                     .replace('ipv4 fragment_offset', 'ipv4 dst is 192.168.1.2 fragment_offset')
                                                      .replace("IP(id=47750)", "IP(id=47750, dst='192.168.1.2')"))
                                     for element in tvs_mac_ipv4_fragment_fdir]
 
@@ -119,7 +118,7 @@ tvs_mac_ipv4_frag_fdir_with_l3 = tvs_mac_ipv4_fragment_fdir_l3src + tvs_mac_ipv4
 
 tv_mac_ipv6_frag_fdir_queue_index = {
     "name": "tv_mac_ipv6_frag_fdir_queue_index",
-    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions queue index 1 / mark / end",
+    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions queue index 1 / mark / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
@@ -128,8 +127,7 @@ tv_mac_ipv6_frag_fdir_queue_index = {
 
 tv_mac_ipv6_frag_fdir_rss_queues = {
     "name": "tv_mac_ipv6_frag_fdir_rss_queues",
-    "rule": ["flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions rss queues 2 3 end / mark / end",
-            "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext / end actions rss types ipv6-frag end key_len 0 queues end / end"],
+    "rule": ["flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions rss queues 2 3 end / mark / end",],
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
@@ -138,16 +136,16 @@ tv_mac_ipv6_frag_fdir_rss_queues = {
 
 tv_mac_ipv6_frag_fdir_passthru = {
     "name": "tv_mac_ipv6_frag_fdir_passthru",
-    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions passthru / mark / end",
+    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions passthru / mark / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
-    "check_param": {"port_id": 0, "rxq": LAUNCH_QUEUE, "mark_id": 0}
+    "check_param": {"port_id": 0, "rxq": LAUNCH_QUEUE, "mark_id": 0, "rss": True}
 }
 
 tv_mac_ipv6_frag_fdir_drop = {
     "name": "tv_mac_ipv6_frag_fdir_drop",
-    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions drop / end",
+    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions drop / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
@@ -156,7 +154,7 @@ tv_mac_ipv6_frag_fdir_drop = {
 
 tv_mac_ipv6_frag_fdir_mark_rss = {
     "name": "tv_mac_ipv6_frag_fdir_mark_rss",
-    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions mark / rss / end",
+    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions mark / rss / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
@@ -165,7 +163,7 @@ tv_mac_ipv6_frag_fdir_mark_rss = {
 
 tv_mac_ipv6_frag_fdir_mark = {
     "name": "tv_mac_ipv6_frag_fdir_mark",
-    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext packet_id spec 0 packet_id last 0xffffffff packet_id mask 0xffffffff frag_data spec 0x0001 frag_data last 0xffff frag_data mask 0xffff / end actions mark id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / ipv6 / ipv6_frag_ext frag_data spec 0x0001 frag_data mask 0x0001 / end actions mark id 1 / end",
     "scapy_str": {"matched": ["Ether(dst='00:11:22:33:55:66')/IPv6()/IPv6ExtHdrFragment(id=47750)/Raw('X'*666)"],
                   "unmatched": ["Ether(dst='00:11:22:33:55:66')/IP(id=47750)/Raw('X'*666)"]
                   },
@@ -372,7 +370,7 @@ class TestCvlIavfIpFragmentRteFlow(TestCase):
         result_list = []
         rule_list_fdir = [
             'flow create 0 ingress pattern eth / ipv4 src is 192.168.0.20 / end actions queue index 1 / end',
-            'flow create 0 ingress pattern eth / ipv4 packet_id spec 0 packet_id last 0xffff packet_id mask 0xffff fragment_offset spec 0x2000 fragment_offset last 0x1fff fragment_offset mask 0xffff / end actions queue index 2 / end']
+            'flow create 0 ingress pattern eth / ipv4 fragment_offset spec 0x2000 fragment_offset mask 0x2000 / end actions queue index 2 / end']
         pkt_fdir = "Ether()/IP(src='192.168.0.20', id=47750)/Raw('X'*666)"
 
         self.logger.info('Subcase 1: exclusive validation fdir rule')
@@ -447,7 +445,7 @@ class TestCvlIavfIpFragmentRteFlow(TestCase):
         if hashes1[0] != hashes1[1] and hashes2[0] != hashes2[1]:
             result = False
             self.logger.error("hash value is incorrect")
-        if hashes1[0] != hashes2[0]:
+        if hashes1[0] == hashes2[0]:
             result = False
             self.logger.error("hash value is incorrect")
         result_list.append(result)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule
  2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
  2021-07-28  6:33   ` Huang, ZhiminX
@ 2021-08-04  2:21   ` Fu, Qi
  2021-09-14  8:14     ` Tu, Lijuan
  1 sibling, 1 reply; 9+ messages in thread
From: Fu, Qi @ 2021-08-04  2:21 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX

Acked-by: Fu, Qi <qi.fu@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: Wednesday, July 28, 2021 11:04 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply
> ipfragment rule
> 
> *.according to the change of dpdk code, simply ipfragment rule
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule
  2021-07-28 15:03 [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Zhimin Huang
  2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
@ 2021-08-04  2:23 ` Fu, Qi
  2021-09-13  4:39 ` Tu, Lijuan
  2 siblings, 0 replies; 9+ messages in thread
From: Fu, Qi @ 2021-08-04  2:23 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX

Acked-by: Fu, Qi <qi.fu@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: Wednesday, July 28, 2021 11:04 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> ipfargment rule
> 
> *.according to the change of dpdk, simply ipfragment rule
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule
  2021-07-28 15:03 [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Zhimin Huang
  2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
  2021-08-04  2:23 ` [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Fu, Qi
@ 2021-09-13  4:39 ` Tu, Lijuan
  2021-09-13  5:12   ` Huang, ZhiminX
  2 siblings, 1 reply; 9+ messages in thread
From: Tu, Lijuan @ 2021-09-13  4:39 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年7月28日 23:04
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> ipfargment rule
> 
> *.according to the change of dpdk, simply ipfragment rule
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Could please provide which commit?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule
  2021-09-13  4:39 ` Tu, Lijuan
@ 2021-09-13  5:12   ` Huang, ZhiminX
  2021-09-14  8:13     ` Tu, Lijuan
  0 siblings, 1 reply; 9+ messages in thread
From: Huang, ZhiminX @ 2021-09-13  5:12 UTC (permalink / raw)
  To: Tu, Lijuan, dts

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, September 13, 2021 12:40 PM
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: RE: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> ipfargment rule
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> > Sent: 2021年7月28日 23:04
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> > ipfargment rule
> >
> > *.according to the change of dpdk, simply ipfragment rule
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> 
> Could please provide which commit?

Hi lijuan,

Add dpdk commit for simply iavf ip fragment code:
00af17037d99fbe626d43b8b594544cf2c8599ce

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule
  2021-09-13  5:12   ` Huang, ZhiminX
@ 2021-09-14  8:13     ` Tu, Lijuan
  0 siblings, 0 replies; 9+ messages in thread
From: Tu, Lijuan @ 2021-09-14  8:13 UTC (permalink / raw)
  To: Huang, ZhiminX, dts



> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: 2021年9月13日 13:13
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> ipfargment rule
> 
> > -----Original Message-----
> > From: Tu, Lijuan <lijuan.tu@intel.com>
> > Sent: Monday, September 13, 2021 12:40 PM
> > To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: RE: [dts] [PATCH V1]
> test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> > ipfargment rule
> >
> > > -----Original Message-----
> > > From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> > > Sent: 2021年7月28日 23:04
> > > To: dts@dpdk.org
> > > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > > Subject: [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply
> > > ipfargment rule
> > >
> > > *.according to the change of dpdk, simply ipfragment rule
> > >
> > > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> >
> > Could please provide which commit?
> 
> Hi lijuan,
> 
> Add dpdk commit for simply iavf ip fragment code:
> 00af17037d99fbe626d43b8b594544cf2c8599ce

Applied with commit message changed.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule
  2021-08-04  2:21   ` Fu, Qi
@ 2021-09-14  8:14     ` Tu, Lijuan
  0 siblings, 0 replies; 9+ messages in thread
From: Tu, Lijuan @ 2021-09-14  8:14 UTC (permalink / raw)
  To: Fu, Qi, Huang, ZhiminX, dts; +Cc: Huang, ZhiminX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Fu, Qi
> Sent: 2021年8月4日 10:21
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply
> ipfragment rule
> 
> Acked-by: Fu, Qi <qi.fu@intel.com>
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> > Sent: Wednesday, July 28, 2021 11:04 PM
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply
> > ipfragment rule
> >
> > *.according to the change of dpdk code, simply ipfragment rule
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Applied with commit message changed.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-09-14  8:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 15:03 [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Zhimin Huang
2021-07-28 15:04 ` [dts] [PATCH V1] tests/cvl_iavf_ip_fragment_rte_flow:simply ipfragment rule Zhimin Huang
2021-07-28  6:33   ` Huang, ZhiminX
2021-08-04  2:21   ` Fu, Qi
2021-09-14  8:14     ` Tu, Lijuan
2021-08-04  2:23 ` [dts] [PATCH V1] test_plans/cvl_iavf_ip_fragment_rte_flow:simply ipfargment rule Fu, Qi
2021-09-13  4:39 ` Tu, Lijuan
2021-09-13  5:12   ` Huang, ZhiminX
2021-09-14  8:13     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).