Re: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage

[Ali Alnubani <alialnu@nvidia.com>]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lijuan Tu
> Sent: Thursday, March 11, 2021 12:48 PM
> To: dpdklab@iol.unh.edu
> Cc: dts@dpdk.org; Lijuan Tu <lijuan.tu@intel.com>
> Subject: [dts] [PATCH] tests/nic_single_core_perf: modify
> accepted_tolerance to percentage
> 
> * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to
> percentage, e.g.
> 	accepted_tolerance = '1%%'
> 	if not set, it will be set to 2% by default.
> * delat in json are chagned to percentage too, e.g.
> 	'delta': '1.5%'
> * expected_throughput will be forced to 1Mpps for compute delat in
> percentage
> * add new conf test_interval in conf/nic_single_core_perf.cfg, which
> indicates interval of getting throughput statistics in second, e.g.
> 	test_interval = 10
> 	if not set, it will be set to 5 seconds by default.
> * collect better statistics , get multiple throughput statistics during
> the test run, and compute the average as the final results.
> 
> Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
> ---
<snipped>
> +accepted_tolerance = '1%%'
<snipped>
> +                    diff = (self.throughput[fwd_config][frame_size][nb_desc] -
> +
> self.expected_throughput[fwd_config][frame_size][nb_desc])/ \
> +
> self.expected_throughput[fwd_config][frame_size][nb_desc]

The value of `diff` here is still a decimal, and needs to be multiplied by a 100 before it can be compared to `accepted_tolerance`.

I suggest splitting this patch into multiple ones. One for making the percentage change and one for taking the mean for multiple readings since they are unrelated changes.
I also see other unrelated changes not explained in the commit message.

Thanks,
Ali