From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E91DA0562; Tue, 23 Mar 2021 09:43:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 257EB40689; Tue, 23 Mar 2021 09:43:54 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by mails.dpdk.org (Postfix) with ESMTP id F29904069E for ; Tue, 23 Mar 2021 09:43:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gbQl3ffvIASFc6VxErXHbfnnc7YrGMsBXGLg2Iks1UX2RdOmDvQTa6cQda38Dpkcgc1qx0OOV4mdM84pKRaVMf1dO2tTr7TrT4M0mk89s6jmO7m8QJq85kT8srpvnp8SGg3Kn7U9iYm5L2hx7AQio5tLKGc58PIwg8ovh5pZ7IxycFlPtn2g6n0TbMr8RwCT6cE87sEXrbI5a/6sFBS1sHdtev/wJpKH0UUyGdlY9ss0YbznU8c2aAD17cKtM8GhG8INH+IFdmPvpF5OshUJtEFTLgoKavDYily1b2hais4ASvrzcPirymn2zXOTTZeWloRfTJSVAYbo4HN7TnCNnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0u8oMxzF8vk/h9EKS1xEDemRFL33cNH156VNwQF2Vx8=; b=mpV9EGdz+YcbNkvSB8DpZ5QQNU/tqo6GoTwTjB8cwXC3m9GB65hm6Tnclx7iufNF8A15FuD6wLvw/pHi5bKzeUuOjXCu8cB3ciJWC+pbN08qTipP8sBkkT6IuJpJ2H7vQo4/ZFozGLzP619cx0XoAunyctGo0F6H3OqEGH5rtxzO141pYNiGGASayDA9ILkrz5oOEQksMUPVO9bKc9x9NHwRm5l4l42uOjfAREQGnUskNL/tb/4kBgE1fageKTLzBD47lFCydi40/+H5kMaEATh+pV2BSQfxVAGKSCAv57re3z/L1ZHSsUyG76KW4POOdb8l7xHHq9X4qQ1ns2m4HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0u8oMxzF8vk/h9EKS1xEDemRFL33cNH156VNwQF2Vx8=; b=rWsJ7Au+13MNKPkJWIImeDNJGAzZkgdA2Pvr6B/t3TQok/rr1M9zcQJc8wCc/ydSLVkQ+fJFl2ceJliDzg4jHvmR+mTtfm5bu3YHRL6+iRrIzn6xpg/QAQedEixgf0+sbA7EFr4aMdx03DBub3kwc4Ndqzm4XnjHdfu5fj7bsKJdSbaS4zsKxArcjqZslnMy+2UW9becqDG4hRwCKX5hwfbetU7iGKfiXD6gMGX7HddBz729cs0k7xIw7IfDHyFYm3BLHISdfObA+J+VPq95BPBf5SWjyvrn31SRzR9EBKEg/KK3lPMaxYjDbCYw8C+Mupkvg7KPES2EC9qjZ9395g== Received: from MWHPR12MB1472.namprd12.prod.outlook.com (2603:10b6:301:11::19) by MW2PR12MB4668.namprd12.prod.outlook.com (2603:10b6:302:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 08:43:51 +0000 Received: from MWHPR12MB1472.namprd12.prod.outlook.com ([fe80::9ce1:aa3f:9f8d:f692]) by MWHPR12MB1472.namprd12.prod.outlook.com ([fe80::9ce1:aa3f:9f8d:f692%10]) with mapi id 15.20.3955.025; Tue, 23 Mar 2021 08:43:50 +0000 From: Ali Alnubani To: Lijuan Tu CC: "dts@dpdk.org" , "dpdklab@iol.unh.edu" Thread-Topic: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage Thread-Index: AQHXFiEXG4FiK1v55UmYNqA7CbVTO6qRSStQ Date: Tue, 23 Mar 2021 08:43:50 +0000 Message-ID: References: <20210311104800.243752-1-lijuan.tu@intel.com> In-Reply-To: <20210311104800.243752-1-lijuan.tu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [87.252.108.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a66ed7dd-6ceb-429a-fde4-08d8edd7c875 x-ms-traffictypediagnostic: MW2PR12MB4668: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vXMVWtZrTWrAgEOv+oPrddu2Wv7OuLhNn7VBFJZoGCWJirNb32c2/B496zHBJ7BXvopc7KwWKhFKaWSKot/o/C/tz5ciI1hHQnTslpcj5mgx1AsZnEEI0h4EzFzGMzyxowTbb3OcGq5gWRZUHBOIUmM0afU4LE11wv3sgeBl+9fvjtjZaSXzBFbmBZfFaNgoywRNatDXuFR3CRrj3pNtPPw0V67ZjH+llAop+5qKpWJNuaXjuQDSrQ2aXln1J/anugDKYR4t32U7xIIq6GmxjEh2KL6atopK988LNIGM8S/9Qgzsy7NZA5F6TSF9zuFAcweQgd4ToImdQwqNHhZZFMb7HGFYdGNr90YvwnCDaone4F3V1NAqC0GgKt0d5KsOtNAdGZHSC+c+xXCVc02mBNkwI98M3EEo96BmHOpPISQcyMpJukeg6UoDRrY7laCTKWd0WqlBCpwY6dhAxge9tQ32DSrYhjKqb3FXgjCLlCj1ImoB6GorHFU7tj2p+yxyHgT9opjdCW/Gb6tyAYZDLeu1vdwwU1R/bjUxKULAs3iSWUZtAcVbnTif3v0AZigAPrL1MDHXJ+I5FrlUVkv7+rNDYB95oyA/3h8NIIFCDoUoZ49kFXZTOi3smhaeB/yY2H1RaHhKiozIgPq/PrjHmtkah8+cmeTJCTwo3xeWdR0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1472.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(26005)(2906002)(4326008)(66446008)(52536014)(86362001)(66556008)(316002)(8676002)(8936002)(186003)(5660300002)(64756008)(66946007)(66476007)(71200400001)(478600001)(83380400001)(6916009)(9686003)(76116006)(54906003)(53546011)(7696005)(6506007)(33656002)(38100700001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jUED8WK+cj1JPmI4yWBiBJnwdcLEt99mvZ4KauMhr7pNzbAmnJeaNliAMlkl?= =?us-ascii?Q?kVyG+tB/TS1ZB6zZLQes3B/oysqy7wxFk6zFuuAUX1wrvOQN3iSatMF8aOea?= =?us-ascii?Q?BhFGm+3XT8NakMo2cMqrIBlSu19RvSRcPtPgeJ9pD1KhlF1mD8Ft1/3S/P1R?= =?us-ascii?Q?3zUs1Io/rLQXR0MRGMtQjL1Idl9TkU8Tybj+G0DTHumx9PUMeT1DjFc+tQg6?= =?us-ascii?Q?FuI+nEVJfS695TB7zIImNOSFrYTrg517s9gQeagSZ8v9r3pWi6nZeQ1lQguI?= =?us-ascii?Q?Yb9dh+PPH+kpoxS2q18MdR1bV/Au+WFhlUnuypN2z5Dm6VFIPrLWEoRoIO1C?= =?us-ascii?Q?lEt8hk5H0plXnjdhmLTRimm3yaxN2/j2Ryu0Ub0ch5R77AGas5DZXi+yi/yB?= =?us-ascii?Q?xLII+IbeUbnmBjUWw5UNTw7NygDLCnaTLU8BPT7nW8GpcLRV3mVGD06gOiTH?= =?us-ascii?Q?mKTVWrZ69IfE285+hfBvuQZrCIbXXu40SLuB2q7g3pGfdcEl68GnOShnwtoE?= =?us-ascii?Q?bEqpMAHNBaY3MJR103Gm714s8SiwBxPOWHsn01qZf+y92z4s4HCHV26cp/qo?= =?us-ascii?Q?1yq+VZF85FtYMVGsS8jl57Mp3VmVIYrQOIVvW5EpOsptF/r5ch4Eydk89OsZ?= =?us-ascii?Q?yZVnjJ98vsEeaMXynT3fB0L3Wipn7Oz9wq4VtfaWCWas6eX96bRQxgjouIla?= =?us-ascii?Q?G10YGGIplJ8RQM5qC1vgu55G9MXRQdIrabEDrIa1+eusfnsz0kZ/C90WJmOQ?= =?us-ascii?Q?yMi7s1RrxQ31Cqi0WmLKVr6n4gTCNXCIWTGJKN25CPKWn5SQ7YjlFui3g5H2?= =?us-ascii?Q?LrZUoParv33OPo7h95ZEV3ni5AL/006JN4VkKfQWw9Ds1Ip6wuzoeT5RuKE1?= =?us-ascii?Q?hkdMMYKQMr3SscSPmC/mJtWHovC7QRxmjqL+B/X0gJJf2J3RjMpDTO9X9ZFQ?= =?us-ascii?Q?GQGFe2huf0dwitYTpjJ8bcwFtSVdiC6it70mUqyUK98IAfQedJyLYsFnH2HG?= =?us-ascii?Q?Iem2lzzSOgYLzMctI+TQRLaXIvCeFj/MLHxqvP1/WX4oUNrIJUJ3PQZn9p5U?= =?us-ascii?Q?wsdRx0XFMvuce2PZHFR06sulMhaQm2z04A5QzcWPAINd+XWn7uN8xig2G8Ly?= =?us-ascii?Q?Emz9WROJfaQS8Mjt1BYzZ/caKRtw93kA+xtpVVNL+mCoKetv/0SPFo0gy/P0?= =?us-ascii?Q?XQYkUMLX2FakFKYMdcc5ZHI7mqG08qIgEJT9XZCZcDFCkRPSzmrFMSORR6F/?= =?us-ascii?Q?8Yafaw7qjZn/AIo8llKmw+iN0ka6iqoInOzhJd3336VVeMCMeYll/hcoxv6h?= =?us-ascii?Q?MG8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1472.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a66ed7dd-6ceb-429a-fde4-08d8edd7c875 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 08:43:50.8743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NyFnFM4NNoevCDNXlmY3Ee2c++jSW2yZ1F/iW+aXDMWR7BKH9XlQmt1Fkv5VIMdYPFrXm/7JqTikmbIuo1lRvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB4668 Subject: Re: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of Lijuan Tu > Sent: Thursday, March 11, 2021 12:48 PM > To: dpdklab@iol.unh.edu > Cc: dts@dpdk.org; Lijuan Tu > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify > accepted_tolerance to percentage >=20 > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to > percentage, e.g. > accepted_tolerance =3D '1%%' > if not set, it will be set to 2% by default. > * delat in json are chagned to percentage too, e.g. > 'delta': '1.5%' > * expected_throughput will be forced to 1Mpps for compute delat in > percentage > * add new conf test_interval in conf/nic_single_core_perf.cfg, which > indicates interval of getting throughput statistics in second, e.g. > test_interval =3D 10 > if not set, it will be set to 5 seconds by default. > * collect better statistics , get multiple throughput statistics during > the test run, and compute the average as the final results. >=20 > Signed-off-by: Lijuan Tu > --- > +accepted_tolerance =3D '1%%' > + diff =3D (self.throughput[fwd_config][frame_size][nb= _desc] - > + > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \ > + > self.expected_throughput[fwd_config][frame_size][nb_desc] The value of `diff` here is still a decimal, and needs to be multiplied by = a 100 before it can be compared to `accepted_tolerance`. I suggest splitting this patch into multiple ones. One for making the perce= ntage change and one for taking the mean for multiple readings since they a= re unrelated changes. I also see other unrelated changes not explained in the commit message. Thanks, Ali