From: "Xu, Ke1" <ke1.xu@intel.com>
To: "Li, WeiyuanX" <weiyuanx.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WeiyuanX" <weiyuanx.li@intel.com>
Subject: RE: [dts][PATCH V2] tests/vf_offload: fix syntax errors
Date: Tue, 10 Jan 2023 09:51:41 +0000 [thread overview]
Message-ID: <PH7PR11MB6056012CAC3B3801CA5679E0D3FF9@PH7PR11MB6056.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230110093013.9449-1-weiyuanx.li@intel.com>
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, January 10, 2023 5:30 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2] tests/vf_offload: fix syntax errors
>
> Scapy send package count can't have quotation marks. Otherwise, send the
> packet fails.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
This patch is to fix some potential bugs.
Line 752: Fix wrong packet checking that only checked packet No.0.
Line 887: Fix long verbose that may crash the buffer causing timeout.
Line 934: Remove white space that format check does not check for the string-ed
command line format where we prefer not adding extra white space for kwargs.
Line 952: The payload_size_list is not index-ed, may cause bugs. Adding extra int()
may help prevent wrong type input though the new method ensures an int return.
Line 994: Add log. Add missed packet count.
Acked-by: Ke Xu <ke1.xu@intel.com>
>
> v2:
> -Modify the traversal comparison and expectation of the captured packet
> results.
>
> tests/TestSuite_vf_offload.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2023-01-10 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 9:30 Weiyuan Li
2023-01-10 9:51 ` Xu, Ke1 [this message]
2023-01-11 2:00 ` Jiale, SongX
2023-01-11 5:27 ` lijuan.tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6056012CAC3B3801CA5679E0D3FF9@PH7PR11MB6056.namprd11.prod.outlook.com \
--to=ke1.xu@intel.com \
--cc=dts@dpdk.org \
--cc=weiyuanx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).