[dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action

test suite reviews and discussions
 help / color / mirror / Atom feed

* [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action
@ 2023-04-13  2:04 Yu Jiang
  2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Yu Jiang @ 2023-04-13  2:04 UTC (permalink / raw)
  To: ke1.xu, dts; +Cc: Yu Jiang

According to dpdk22.11 commit id:
    776c119736 net/ice: remove deprecated VF flow action
    c0444f6273 net/ice: support represented port flow action
update test plan to support represented port action from deprecated RTE_FLOW TO_VF action

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 test_plans/ice_dcf_switch_filter_test_plan.rst | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/test_plans/ice_dcf_switch_filter_test_plan.rst b/test_plans/ice_dcf_switch_filter_test_plan.rst
index 10364c38..b4d9b968 100644
--- a/test_plans/ice_dcf_switch_filter_test_plan.rst
+++ b/test_plans/ice_dcf_switch_filter_test_plan.rst
@@ -4303,7 +4303,7 @@ Subcase 1:  MAC_IPV4_UDP + L4 MASK + single vf
 ----------------------------------------------
 1. validate a rule::
 
-     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 / udp src spec 2152 src mask 0xff00 dst spec 1281 dst mask 0x00ff / end actions vf id 1 / end
+     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 / udp src spec 2152 src mask 0xff00 dst spec 1281 dst mask 0x00ff / end actions represented_port ethdev_port_id 1 / end
 
    get the message::
 
@@ -4317,7 +4317,7 @@ Subcase 1:  MAC_IPV4_UDP + L4 MASK + single vf
 
 2. create MAC_IPV4_L2TP_PAY rule::
 
-     testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 / udp src spec 2152 src mask 0xff00 dst spec 1281 dst mask 0x00ff / end actions vf id 1 / end
+     testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 / udp src spec 2152 src mask 0xff00 dst spec 1281 dst mask 0x00ff / end actions represented_port ethdev_port_id 1 / end
      testpmd> flow list 0
 
    check the rule exists in the list.
@@ -4347,7 +4347,7 @@ Subcase 2:  MAC_IPV6_TCP + L4 MASK + single vf
 ----------------------------------------------
 1. validate a rule::
 
-     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv6 / tcp dst spec 3333 dst mask 0x0ff0 / end actions vf id 1 / end
+     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv6 / tcp dst spec 3333 dst mask 0x0ff0 / end actions represented_port ethdev_port_id 1 / end
 
    get the message::
 
@@ -4361,7 +4361,7 @@ Subcase 2:  MAC_IPV6_TCP + L4 MASK + single vf
 
 2. create MAC_IPV4_L2TP_PAY rule::
 
-     testpmd> flow create 0 priority 0 ingress pattern eth / ipv6 / tcp dst spec 3333 dst mask 0x0ff0 / end actions vf id 1 / end
+     testpmd> flow create 0 priority 0 ingress pattern eth / ipv6 / tcp dst spec 3333 dst mask 0x0ff0 / end actions represented_port ethdev_port_id 1 / end
      testpmd> flow list 0
 
    check the rule exists in the list.
@@ -4391,7 +4391,7 @@ Subcase 3:  MAC_IPV4_UDP_VXLAN_MAC_IPV4_UDP + L4 MASK + single vf
 1. validate a rule::
 
      testpmd> rx_vxlan_port add 4789 0
-     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4 / udp src spec 32 src mask 0x0f / end actions vf id 1 / end
+     testpmd> flow validate 0 priority 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4 / udp src spec 32 src mask 0x0f / end actions represented_port ethdev_port_id 1 / end
 
    get the message::
 
@@ -4405,7 +4405,7 @@ Subcase 3:  MAC_IPV4_UDP_VXLAN_MAC_IPV4_UDP + L4 MASK + single vf
 
 2. create MAC_IPV4_L2TP_PAY rule::
 
-     testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4 / udp src spec 32 src mask 0x0f / end actions vf id 1 / end
+     testpmd> flow create 0 priority 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4 / udp src spec 32 src mask 0x0f / end actions represented_port ethdev_port_id 1 / end
      testpmd> flow list 0
 
    check the rule exists in the list.
@@ -4434,7 +4434,7 @@ Subcase 4:  MAC_IPV4_NVGRE_MAC_IPV4_UDP + L4 MASK + single vf
 -------------------------------------------------------------
 1. validate a rule::
 
-     testpmd> flow validate 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 0x8 / eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 / udp src spec 1280 src mask 0x00ff / end actions vf id 1 / end
+     testpmd> flow validate 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 0x8 / eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 / udp src spec 1280 src mask 0x00ff / end actions represented_port ethdev_port_id 1 / end
 
    get the message::
 
@@ -4448,7 +4448,7 @@ Subcase 4:  MAC_IPV4_NVGRE_MAC_IPV4_UDP + L4 MASK + single vf
 
 2. create MAC_IPV4_L2TP_PAY rule::
 
-     testpmd> flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 0x8 / eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 / udp src spec 1280 src mask 0x00ff / end actions vf id 1 / end
+     testpmd> flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 0x8 / eth / ipv4 src is 192.168.0.2 dst is 192.168.0.3 / udp src spec 1280 src mask 0x00ff / end actions represented_port ethdev_port_id 1 / end
      testpmd> flow list 0
 
    check the rule exists in the list.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan
  2023-04-13  2:04 [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Yu Jiang
@ 2023-04-13  2:04 ` Yu Jiang
  2023-04-13  4:00   ` Xu, Ke1
  2023-04-23  8:53   ` lijuan.tu
  2023-04-13  3:57 ` [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Xu, Ke1
  2023-04-26  2:53 ` lijuan.tu
  2 siblings, 2 replies; 6+ messages in thread
From: Yu Jiang @ 2023-04-13  2:04 UTC (permalink / raw)
  To: ke1.xu, dts; +Cc: Yu Jiang

1, sync test_negative_case with testplan, add two subcases:
  Subcase 4: can not create to vf rule to self dcf
  Subcase 17: deprecated action
2, format.sh script

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_ice_dcf_switch_filter.py | 26 ++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_ice_dcf_switch_filter.py b/tests/TestSuite_ice_dcf_switch_filter.py
index 0731199a..f9e5cbf3 100644
--- a/tests/TestSuite_ice_dcf_switch_filter.py
+++ b/tests/TestSuite_ice_dcf_switch_filter.py
@@ -2107,7 +2107,7 @@ tv_mac_ipv4_vxlan_ipv4_udp_pay = {
     ],
     "matched": {
         "scapy_str": [
-            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether()/IP(src="192.168.0.2", dst="192.168.0.3")/UDP(sport=50,dport=23) /Raw("x"*80)',
+            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether()/IP(src="192.168.0.2", dst="192.168.0.3")/UDP(sport=50,dport=23) /Raw("x"*80)'
         ],
         "check_func": {
             "func": rfc.check_vf_rx_packets_number,
@@ -2136,7 +2136,7 @@ tv_mac_ipv4_vxlan_ipv4_tcp = {
     ],
     "matched": {
         "scapy_str": [
-            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether()/IP(src="192.168.0.2", dst="192.168.0.3")/TCP(sport=50,dport=23)/Raw("x"*80)',
+            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether()/IP(src="192.168.0.2", dst="192.168.0.3")/TCP(sport=50,dport=23)/Raw("x"*80)'
         ],
         "check_func": {
             "func": rfc.check_vf_rx_packets_number,
@@ -2233,7 +2233,7 @@ tv_mac_ipv4_vxlan_mac_ipv4_udp_pay = {
     ],
     "matched": {
         "scapy_str": [
-            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether(dst="68:05:ca:8d:ed:a8")/IP(src="192.168.0.2", dst="192.168.0.3")/UDP(sport=50,dport=23)/Raw("x" * 80)',
+            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether(dst="68:05:ca:8d:ed:a8")/IP(src="192.168.0.2", dst="192.168.0.3")/UDP(sport=50,dport=23)/Raw("x" * 80)'
         ],
         "check_func": {
             "func": rfc.check_vf_rx_packets_number,
@@ -2262,7 +2262,7 @@ tv_mac_ipv4_vxlan_mac_ipv4_tcp = {
     ],
     "matched": {
         "scapy_str": [
-            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether(dst="68:05:ca:8d:ed:a8")/IP(src="192.168.0.2", dst="192.168.0.3")/TCP(sport=25,dport=23)/Raw("x" * 80)',
+            'Ether()/IP(dst="192.168.0.1")/UDP()/VXLAN(vni=2)/Ether(dst="68:05:ca:8d:ed:a8")/IP(src="192.168.0.2", dst="192.168.0.3")/TCP(sport=25,dport=23)/Raw("x" * 80)'
         ],
         "check_func": {
             "func": rfc.check_vf_rx_packets_number,
@@ -2819,6 +2819,7 @@ class ICEDCFSwitchFilterTest(TestCase):
             "cannot create to vf rule on a representor": "flow create 1 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
             "cannot create to vf rule on a vf": "flow create 3 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
             "cannot create to vf rule to a vf": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 3 / end",
+            "cannot create to vf rule to self dcf": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 0 / end",
             "cannot create to vf rule to another dcf": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 4 / end",
             "cannot create to vf rule to a representor of another pf": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions represented_port ethdev_port_id 5 / end",
             "cannot create vf original rule on a representor": "flow create 1 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions port_representor port_id 1 / end",
@@ -2828,6 +2829,7 @@ class ICEDCFSwitchFilterTest(TestCase):
             "cannot create vf original rule to another dcf": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / udp src is 25 dst is 23 / end actions port_representor port_id 4 / end",
             "unsupported input set": "flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.1 / nvgre tni is 2 / eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.1.2 dst is 192.168.1.3 tos is 4 / end actions port_representor port_id 1 / end",
             "invalid port id": "flow create 0 ingress pattern eth dst is 68:05:ca:8d:ed:a8 / ipv4 src is 192.168.0.1 dst is 192.168.0.2 tos is 4 ttl is 3 / tcp src is 25 dst is 23 / end actions represented_port ethdev_port_id 20 / end",
+            "deprecated action": "flow create 0 ingress pattern eth / ipv4 src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / end actions vf id 1 / end",
             "void action": "flow create 0 ingress pattern eth / ipv4 / udp src is 25 dst is 23 / end actions end",
             "void input set value": "flow create 0 ingress pattern eth / ipv4 / end actions represented_port ethdev_port_id 1 end",
         }
@@ -2861,6 +2863,16 @@ class ICEDCFSwitchFilterTest(TestCase):
         )
         self.check_switch_filter_rule_list(0, [])
 
+        self.logger.info("Subcase 4: can not create to vf rule to self dcf")
+        self.validate_switch_filter_rule(
+            rules["cannot create to vf rule to self dcf"], check_stats=False
+        )
+        self.check_switch_filter_rule_list(0, [])
+        self.create_switch_filter_rule(
+            rules["cannot create to vf rule to self dcf"], check_stats=False
+        )
+        self.check_switch_filter_rule_list(0, [])
+
         # cannot create to vf rule to another dcf
         self.validate_switch_filter_rule(
             rules["cannot create to vf rule to another dcf"], check_stats=False
@@ -2923,6 +2935,12 @@ class ICEDCFSwitchFilterTest(TestCase):
         )
         self.check_switch_filter_rule_list(0, [])
 
+        self.logger.info("Subcase 17: deprecated action")
+        self.validate_switch_filter_rule(rules["deprecated action"], check_stats=False)
+        self.check_switch_filter_rule_list(0, [])
+        self.create_switch_filter_rule(rules["deprecated action"], check_stats=False)
+        self.check_switch_filter_rule_list(0, [])
+
         # unsupported input set
         self.validate_switch_filter_rule(
             rules["unsupported input set"], check_stats=False
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan
  2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
@ 2023-04-13  4:00   ` Xu, Ke1
  2023-04-23  8:53   ` lijuan.tu
  1 sibling, 0 replies; 6+ messages in thread
From: Xu, Ke1 @ 2023-04-13  4:00 UTC (permalink / raw)
  To: Jiang, YuX, dts


> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Thursday, April 13, 2023 10:04 AM
> To: Xu, Ke1 <ke1.xu@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1] tests/ice_dcf_switch_filter: sync
> test_negative_case with testplan
> 
> 1, sync test_negative_case with testplan, add two subcases:
>   Subcase 4: can not create to vf rule to self dcf
>   Subcase 17: deprecated action
> 2, format.sh script
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>

This patch fixes missed modification in commit 90498b5.

Acked-by: Ke Xu <ke1.xu@intel.com>

> ---
>  tests/TestSuite_ice_dcf_switch_filter.py | 26 ++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan
  2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
  2023-04-13  4:00   ` Xu, Ke1
@ 2023-04-23  8:53   ` lijuan.tu
  1 sibling, 0 replies; 6+ messages in thread
From: lijuan.tu @ 2023-04-23  8:53 UTC (permalink / raw)
  To: ke1.xu, dts, Yu Jiang; +Cc: Yu Jiang

On Thu, 13 Apr 2023 10:04:17 +0800, Yu Jiang <yux.jiang@intel.com> wrote:
> 1, sync test_negative_case with testplan, add two subcases:
>   Subcase 4: can not create to vf rule to self dcf
>   Subcase 17: deprecated action
> 2, format.sh script
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action
  2023-04-13  2:04 [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Yu Jiang
  2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
@ 2023-04-13  3:57 ` Xu, Ke1
  2023-04-26  2:53 ` lijuan.tu
  2 siblings, 0 replies; 6+ messages in thread
From: Xu, Ke1 @ 2023-04-13  3:57 UTC (permalink / raw)
  To: Jiang, YuX, dts


> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: Thursday, April 13, 2023 10:04 AM
> To: Xu, Ke1 <ke1.xu@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan
> to support represented port action from deprecated vf action
> 
> According to dpdk22.11 commit id:
>     776c119736 net/ice: remove deprecated VF flow action
>     c0444f6273 net/ice: support represented port flow action update test plan
> to support represented port action from deprecated RTE_FLOW TO_VF
> action
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>

This patch fixes missed replacement in commit 2e1facd.

Acked-by: Ke Xu <ke1.xu@intel.com>

> ---
>  test_plans/ice_dcf_switch_filter_test_plan.rst | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action
  2023-04-13  2:04 [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Yu Jiang
  2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
  2023-04-13  3:57 ` [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Xu, Ke1
@ 2023-04-26  2:53 ` lijuan.tu
  2 siblings, 0 replies; 6+ messages in thread
From: lijuan.tu @ 2023-04-26  2:53 UTC (permalink / raw)
  To: ke1.xu, dts, Yu Jiang; +Cc: Yu Jiang

On Thu, 13 Apr 2023 10:04:16 +0800, Yu Jiang <yux.jiang@intel.com> wrote:
> According to dpdk22.11 commit id:
>     776c119736 net/ice: remove deprecated VF flow action
>     c0444f6273 net/ice: support represented port flow action
> update test plan to support represented port action from deprecated RTE_FLOW TO_VF action
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-04-26  2:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-13  2:04 [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Yu Jiang
2023-04-13  2:04 ` [dts][PATCH V1] tests/ice_dcf_switch_filter: sync test_negative_case with testplan Yu Jiang
2023-04-13  4:00   ` Xu, Ke1
2023-04-23  8:53   ` lijuan.tu
2023-04-13  3:57 ` [dts][PATCH V1] test_plans/ice_dcf_switch_filter: update test plan to support represented port action from deprecated vf action Xu, Ke1
2023-04-26  2:53 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).