test suite reviews and discussions
 help / color / mirror / Atom feed
* [DTS][PATCH V2 0/2] update test plans and tests to support represented port action and port representor action from deprecated vf action in ice_qinq
@ 2022-12-07 11:18 Ke Xu
  2022-12-07 11:18 ` [DTS][PATCH V2 1/2] test_plans/ice_qinq: update test plan to support represented port action from deprecated vf action Ke Xu
  2022-12-07 11:18 ` [DTS][PATCH V2 2/2] tests/ice_qinq: " Ke Xu
  0 siblings, 2 replies; 5+ messages in thread
From: Ke Xu @ 2022-12-07 11:18 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, qi.fu, ke1.xu

A new API is introduced to replace the VF actions in DPDK 22.11.

New API covers deprecated TO_VF action on DCFs by port representor and
 represented port actions. These patches checks the existing use of vf id
 action and vf original action and replace them with new API.

Method calling of launch_testpmd is updated to enable representor.

Testpmd args are modified to support appyling representors for the new API.

Rules are modified for the old API being deprecated, changing to the new API.

Ports id are modified corresponding to the port representors and modified API.

File names of packet capturing is renamed to .pcap to fix a no-reason
 failure when using .cap

Ke Xu (2):
  test_plans/ice_qinq: update test plan to support represented port
    action from deprecated vf action
  tests/ice_qinq: update test plan to support represented port action
    from deprecated vf action

 test_plans/ice_qinq_test_plan.rst | 106 +++++++++++++++---------------
 tests/TestSuite_ice_qinq.py       | 104 ++++++++++++++---------------
 2 files changed, 105 insertions(+), 105 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [DTS][PATCH V2 1/2] test_plans/ice_qinq: update test plan to support represented port action from deprecated vf action
  2022-12-07 11:18 [DTS][PATCH V2 0/2] update test plans and tests to support represented port action and port representor action from deprecated vf action in ice_qinq Ke Xu
@ 2022-12-07 11:18 ` Ke Xu
  2022-12-07 11:18 ` [DTS][PATCH V2 2/2] tests/ice_qinq: " Ke Xu
  1 sibling, 0 replies; 5+ messages in thread
From: Ke Xu @ 2022-12-07 11:18 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, qi.fu, ke1.xu

Testpmd args are modified to support appyling representors for the new API. Rules
 are modified for the old API being deprecated, changing to the new API. Ports id
 are modified corresponding to the port representors and modified API.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 test_plans/ice_qinq_test_plan.rst | 106 +++++++++++++++---------------
 1 file changed, 53 insertions(+), 53 deletions(-)

diff --git a/test_plans/ice_qinq_test_plan.rst b/test_plans/ice_qinq_test_plan.rst
index 37396f41..b3981829 100644
--- a/test_plans/ice_qinq_test_plan.rst
+++ b/test_plans/ice_qinq_test_plan.rst
@@ -1,5 +1,5 @@
 .. SPDX-License-Identifier: BSD-3-Clause
-   Copyright(c) 2021 Intel Corporation
+   Copyright(c) 2021-2022 Intel Corporation
 
 =========================
 ICE support QinQ protocol
@@ -80,7 +80,7 @@ Prerequisites
 
 12. For test cases for DCF switch filter(01-06), use below cmd to launch testpmd::
 
-     ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:18:01.0,cap=dcf -a 0000:18:01.1 -a 0000:18:01.2 -a 0000:18:01.3 -- -i
+     ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:18:01.0,cap=dcf,representor=[1] -a 0000:18:01.1 -a 0000:18:01.2 -a 0000:18:01.3 -- -i
      testpmd> set fwd rxonly
      testpmd> set verbose 1
      testpmd> start
@@ -139,7 +139,7 @@ subcase: dest mac
 -----------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -170,7 +170,7 @@ subcase: src ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 src is 196.222.232.221 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 src is 196.222.232.221 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -201,7 +201,7 @@ subcase: dst ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 dst is 196.222.232.221 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 dst is 196.222.232.221 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -235,7 +235,7 @@ subcase: dest mac
 -----------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -266,7 +266,7 @@ subcase: src ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -297,7 +297,7 @@ subcase: dst ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -330,7 +330,7 @@ Test case 03: DCF switch for MAC_QINQ_PPPOE_PAY
 
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -368,7 +368,7 @@ Test case 04: DCF switch for MAC_QINQ_PPPOE_PAY_Proto
 
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / pppoe_proto_id is 0x0057 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -403,7 +403,7 @@ subcase: dest mac
 -----------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -435,7 +435,7 @@ subcase: src ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 src is 196.222.232.221 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 src is 196.222.232.221 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -467,7 +467,7 @@ subcase: dst ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 dst is 196.222.232.221 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 dst is 196.222.232.221 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -502,7 +502,7 @@ subcase: dest mac
 -----------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -534,7 +534,7 @@ subcase: src ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -566,7 +566,7 @@ subcase: dst ip
 ---------------
 1. create a rule::
 
-    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end
+    testpmd> flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id1 / end
     testpmd> flow list 0
 
    check the rule exists in the list.
@@ -1577,7 +1577,7 @@ Common Steps
 ..note:: 
 
     For <EAL options>, you can use "-c 0x6 -n 4", you can also refer to testpmd doc for other setings.
-    For <DUT port pci device id>, you can use "0000:3b:01.0,cap=dcf -a 0000:3b:01.1" for this test plan.
+    For <DUT port pci device id>, you can use "0000:3b:01.0,cap=dcf,representor=[1] -a 0000:3b:01.1" for this test plan.
 
 2. Set verbose::
     
@@ -1622,7 +1622,7 @@ Test Steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 src is <ipv4 src> dst is <ipv4 dst> / end actions vf id 1 / end
+     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 src is <ipv4 src> dst is <ipv4 dst> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1630,7 +1630,7 @@ Test Steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 src is <ipv4 src> dst is <ipv4 dst> / end actions vf id 1 / end
+     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 src is <ipv4 src> dst is <ipv4 dst> / end actions represented_port ethdev_port_id1 / end
      
    Get the message::
 
@@ -1643,7 +1643,7 @@ Test Steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV4 => VF
 
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1651,11 +1651,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=A4:BF:01:4D:6F:32 - dst=00:11:22:33:44:55 - type=0x8100 - length=122 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV4  - l2_len=18 - inner_l2_len=4 - inner_l3_len=20 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -1680,7 +1680,7 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 Test Case 2: MAC_QINQ_IPV6
 --------------------------
@@ -1690,7 +1690,7 @@ Test Steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / end actions vf id 1 / end
+     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1698,7 +1698,7 @@ Test Steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / end actions vf id 1 / end
+     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1711,7 +1711,7 @@ Test Steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV6 => VF
 
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1719,11 +1719,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=00:00:00:00:00:00 - dst=00:11:22:33:44:55 - type=0x8100 - length=142 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV6_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV6  - l2_len=18 - inner_l2_len=4 - inner_l3_len=40 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -1748,7 +1748,7 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 Test Case 3: MAC_QINQ_IPV4_UDP
 ------------------------------
@@ -1758,7 +1758,7 @@ Test steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / udp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / udp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1766,7 +1766,7 @@ Test steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / udp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / udp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1779,7 +1779,7 @@ Test steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV4 UDP => VF
 
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1787,11 +1787,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=00:00:00:00:00:00 - dst=00:11:22:33:44:55 - type=0x8100 - length=130 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV4 INNER_L4_UDP  - l2_len=18 - inner_l2_len=4 - inner_l3_len=20 - inner_l4_len=8 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -1816,7 +1816,7 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 Test Case 4: MAC_QINQ_IPV4_TCP
 ------------------------------
@@ -1826,7 +1826,7 @@ Test Steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / tcp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow validate 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / tcp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1834,7 +1834,7 @@ Test Steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / tcp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow create 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv4 / tcp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1847,7 +1847,7 @@ Test Steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV4 TCP => VF
 
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1855,11 +1855,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=00:00:00:00:00:00 - dst=00:11:22:33:44:55 - type=0x8100 - length=142 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_TCP  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV4 INNER_L4_TCP  - l2_len=18 - inner_l2_len=4 - inner_l3_len=20 - inner_l4_len=20 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -1884,7 +1884,7 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 #Pipeline mode
 
@@ -1896,7 +1896,7 @@ Test Steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / udp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow validate 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / udp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1904,7 +1904,7 @@ Test Steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / udp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow create 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / udp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1917,7 +1917,7 @@ Test Steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV6 UDP => VF
 
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1925,11 +1925,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=00:00:00:00:00:00 - dst=00:11:22:33:44:55 - type=0x8100 - length=150 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV6_EXT_UNKNOWN L4_UDP  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV6 INNER_L4_UDP  - l2_len=18 - inner_l2_len=4 - inner_l3_len=40 - inner_l4_len=8 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -1954,7 +1954,7 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 Test case 6: MAC_QINQ_IPV6_TCP
 ------------------------------
@@ -1964,7 +1964,7 @@ Test steps
 ~~~~~~~~~~
 1. Validate a rule::
    
-     testpmd> flow validate 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / tcp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow validate 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / tcp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1972,7 +1972,7 @@ Test steps
 
 2. Create a rule and list rules::
 
-     testpmd> flow create 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / tcp src is <sport> dst is <dport> / end actions vf id 1 / end
+     testpmd> flow create 0 priority 0 ingress pattern eth dst is <dst mac> / vlan tci is <outer vlan tci> / vlan tci is <inner vlan tci> / ipv6 dst is <ipv6 dst> / tcp src is <sport> dst is <dport> / end actions represented_port ethdev_port_id1 / end
 
    Get the message::
 
@@ -1985,7 +1985,7 @@ Test steps
    ID      Group   Prio    Attr    Rule
    0       0       0       i--     ETH VLAN VLAN IPV6 TCP => VF
    
-3. Send matched packet in scapy on tester, check the port 1 of DUT received this packet.
+3. Send matched packet in scapy on tester, check the port 2 of DUT received this packet.
 
 Tester::
 
@@ -1993,11 +1993,11 @@ Tester::
 
 DUT::
 
-    testpmd> port 1/queue 0: received 1 packets
+    testpmd> port 2/queue 0: received 1 packets
   src=00:00:00:00:00:00 - dst=00:11:22:33:44:55 - type=0x8100 - length=162 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV6_EXT_UNKNOWN L4_TCP  - sw ptype: L2_ETHER_VLAN INNER_L2_ETHER_VLAN INNER_L3_IPV6 INNER_L4_TCP  - l2_len=18 - inner_l2_len=4 - inner_l3_len=40 - inner_l4_len=20 - Receive queue=0x0
   ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN
 
-4. Send mismatched packet in scapy on tester, check the port 1 of DUT could not receive this packet.
+4. Send mismatched packet in scapy on tester, check the port 2 of DUT could not receive this packet.
 
 Tester::
 
@@ -2022,6 +2022,6 @@ Tester::
      testpmd> flow list 0
 
    Check the rule not exists in the list.
-   Send matched packets in step 3, check the packets are not to port 1.
+   Send matched packets in step 3, check the packets are not to port 2.
 
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [DTS][PATCH V2 2/2] tests/ice_qinq: update test plan to support represented port action from deprecated vf action
  2022-12-07 11:18 [DTS][PATCH V2 0/2] update test plans and tests to support represented port action and port representor action from deprecated vf action in ice_qinq Ke Xu
  2022-12-07 11:18 ` [DTS][PATCH V2 1/2] test_plans/ice_qinq: update test plan to support represented port action from deprecated vf action Ke Xu
@ 2022-12-07 11:18 ` Ke Xu
  2022-12-12  9:56   ` Li, HongboX
  2022-12-13  6:14   ` lijuan.tu
  1 sibling, 2 replies; 5+ messages in thread
From: Ke Xu @ 2022-12-07 11:18 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, qi.fu, ke1.xu

Method calling of launch_testpmd is updated to enable representor.

Testpmd args are modified to support appyling representors for the
 new API. Rules are modified for the old API being deprecated, changing
 to the new API. Ports id are modified corresponding to the port
  representors and modified API.

File names of packet capturing is renamed to .pcap to fix a no-reason
 failure when using .cap

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_ice_qinq.py | 104 ++++++++++++++++++------------------
 1 file changed, 52 insertions(+), 52 deletions(-)

diff --git a/tests/TestSuite_ice_qinq.py b/tests/TestSuite_ice_qinq.py
index c6123643..345477bf 100644
--- a/tests/TestSuite_ice_qinq.py
+++ b/tests/TestSuite_ice_qinq.py
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2021 Intel Corporation
+# Copyright(c) 2021-2022 Intel Corporation
 #
 
 import random
@@ -15,7 +15,7 @@ from .rte_flow_common import RssProcessing
 
 mac_qinq_ipv4_pay_src_ip = {
     "name": "mac_qinq_ipv4_pay_src_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 src is 196.222.232.221 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 src is 196.222.232.221 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP(src="196.222.232.221")/("X"*480)'
@@ -27,12 +27,12 @@ mac_qinq_ipv4_pay_src_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x0800)/IP(src="196.222.232.221")/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv4_pay_dst_ip = {
     "name": "mac_qinq_ipv4_pay_dst_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 dst is 196.222.232.221 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv4 dst is 196.222.232.221 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP(dst="196.222.232.221")/("X"*480)'
@@ -44,12 +44,12 @@ mac_qinq_ipv4_pay_dst_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x0800)/IP(dst="196.222.232.221")/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv4_pay_dest_mac = {
     "name": "mac_qinq_ipv4_pay_dest_mac",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP()/("X"*480)'
@@ -60,7 +60,7 @@ mac_qinq_ipv4_pay_dest_mac = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x0800)/IP()/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv4_pay = [
@@ -71,7 +71,7 @@ mac_qinq_ipv4_pay = [
 
 mac_qinq_ipv6_pay_src_ip = {
     "name": "mac_qinq_ipv6_pay_src_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(src="1111:2222:3333:4444:5555:6666:7777:8888")/("X"*480)'
@@ -83,12 +83,12 @@ mac_qinq_ipv6_pay_src_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x86DD)/IPv6(src="1111:2222:3333:4444:5555:6666:7777:8888")/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv6_pay_dst_ip = {
     "name": "mac_qinq_ipv6_pay_dst_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="1111:2222:3333:4444:5555:6666:7777:8888")/("X"*480)'
@@ -100,12 +100,12 @@ mac_qinq_ipv6_pay_dst_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x86DD)/IPv6(dst="1111:2222:3333:4444:5555:6666:7777:8888")/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv6_pay_dest_mac = {
     "name": "mac_qinq_ipv6_pay_dest_mac",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6()/("X"*480)'
@@ -116,7 +116,7 @@ mac_qinq_ipv6_pay_dest_mac = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x86DD)/IPv6()/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_ipv6_pay = [
@@ -128,7 +128,7 @@ mac_qinq_ipv6_pay = [
 mac_qinq_pppoe_pay = [
     {
         "name": "mac_qinq_pppoe_pay",
-        "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / end actions vf id 1 / end",
+        "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / end actions represented_port ethdev_port_id 1 / end",
         "scapy_str": {
             "matched": [
                 'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6()/("X"*480)',
@@ -145,14 +145,14 @@ mac_qinq_pppoe_pay = [
                 'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP()/("X"*480)',
             ],
         },
-        "check_param": {"port_id": 1},
+        "check_param": {"port_id": 2},
     }
 ]
 
 mac_qinq_pppoe_proto = [
     {
         "name": "mac_qinq_pppoe_proto",
-        "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end",
+        "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / pppoe_proto_id is 0x0057 / end actions represented_port ethdev_port_id 1 / end",
         "scapy_str": {
             "matched": [
                 'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6()/("X"*480)'
@@ -165,13 +165,13 @@ mac_qinq_pppoe_proto = [
                 'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6()/("X"*480)',
             ],
         },
-        "check_param": {"port_id": 1},
+        "check_param": {"port_id": 2},
     }
 ]
 
 mac_qinq_pppoe_ipv4_src_ip = {
     "name": "mac_qinq_pppoe_ipv4_src_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 src is 196.222.232.221 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 src is 196.222.232.221 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP(src="196.222.232.221")/UDP(dport=23)/("X"*480)'
@@ -184,12 +184,12 @@ mac_qinq_pppoe_ipv4_src_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP(src="196.222.232.221")/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv4_dst_ip = {
     "name": "mac_qinq_pppoe_ipv4_dst_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 dst is 196.222.232.221 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 dst is 196.222.232.221 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP(dst="196.222.232.221")/UDP(dport=23)/("X"*480)'
@@ -202,12 +202,12 @@ mac_qinq_pppoe_ipv4_dst_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP(dst="196.222.232.221")/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv4_dest_mac = {
     "name": "mac_qinq_pppoe_ipv4_dest_mac",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv4 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP()/UDP(dport=23)/("X"*480)'
@@ -220,7 +220,7 @@ mac_qinq_pppoe_ipv4_dest_mac = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x21\')/IP()/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv4 = [
@@ -231,7 +231,7 @@ mac_qinq_pppoe_ipv4 = [
 
 mac_qinq_pppoe_ipv6_src_ip = {
     "name": "mac_qinq_pppoe_ipv6_src_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 src is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6(src="1111:2222:3333:4444:5555:6666:7777:8888")/UDP(dport=23)/("X"*480)'
@@ -244,12 +244,12 @@ mac_qinq_pppoe_ipv6_src_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6(src="1111:2222:3333:4444:5555:6666:7777:8888")/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv6_dst_ip = {
     "name": "mac_qinq_pppoe_ipv6_dst_ip",
-    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 dst is 1111:2222:3333:4444:5555:6666:7777:8888 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6(dst="1111:2222:3333:4444:5555:6666:7777:8888")/UDP(dport=23)/("X"*480)'
@@ -262,12 +262,12 @@ mac_qinq_pppoe_ipv6_dst_ip = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6(dst="1111:2222:3333:4444:5555:6666:7777:8888")/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv6_dest_mac = {
     "name": "mac_qinq_pppoe_ipv6_dest_mac",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / pppoes seid is 1 / ipv6 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6()/UDP(dport=23)/("X"*480)'
@@ -280,7 +280,7 @@ mac_qinq_pppoe_ipv6_dest_mac = {
             'Ether(dst="00:11:22:33:44:33",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x8864)/PPPoE(sessionid=0x1)/PPP(b\'\\x00\\x57\')/IPv6()/UDP(dport=23)/("X"*480)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 mac_qinq_pppoe_ipv6 = [
@@ -292,7 +292,7 @@ mac_qinq_pppoe_ipv6 = [
 # Non-pipeline mode
 tv_mac_qinq_ipv4 = {
     "name": "tv_mac_qinq_ipv4",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 src is 192.168.1.1 dst is 192.168.1.2 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 src is 192.168.1.1 dst is 192.168.1.2 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP(src="192.168.1.1", dst="192.168.1.2")/("X"*80)'
@@ -304,12 +304,12 @@ tv_mac_qinq_ipv4 = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP(src="192.168.1.3", dst="192.168.1.2")/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tv_mac_qinq_ipv6 = {
     "name": "tv_mac_qinq_ipv6",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2020")/("X"*80)'
@@ -321,12 +321,12 @@ tv_mac_qinq_ipv6 = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2023")/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tv_mac_qinq_ipv4_udp = {
     "name": "tv_mac_qinq_ipv4_udp",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / udp src is 50 dst is 23 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / udp src is 50 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP()/UDP(sport=50,dport=23)/("X"*80)'
@@ -338,12 +338,12 @@ tv_mac_qinq_ipv4_udp = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP()/UDP(sport=50,dport=22)/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tv_mac_qinq_ipv4_tcp = {
     "name": "tv_mac_qinq_ipv4_tcp",
-    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / tcp src is 50 dst is 23 / end actions vf id 1 / end",
+    "rule": "flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv4 / tcp src is 50 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP()/TCP(sport=50,dport=23)/("X"*80)'
@@ -355,7 +355,7 @@ tv_mac_qinq_ipv4_tcp = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x0800)/IP()/TCP(sport=50,dport=22)/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tvs_mac_l4_qinq_dcf_non_pipeline_mode = [
@@ -368,7 +368,7 @@ tvs_mac_l4_qinq_dcf_non_pipeline_mode = [
 # Pipeline mode
 tv_mac_qinq_ipv6_udp = {
     "name": "tv_mac_qinq_ipv6_udp",
-    "rule": "flow create 0 priority 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / udp src is 50 dst is 23 / end actions vf id 1 / end",
+    "rule": "flow create 0 priority 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / udp src is 50 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2020")/UDP(sport=50,dport=23)/("X"*80)'
@@ -380,12 +380,12 @@ tv_mac_qinq_ipv6_udp = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2023")/UDP(sport=50,dport=22)/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tv_mac_qinq_ipv6_tcp = {
     "name": "tv_mac_qinq_ipv6_tcp",
-    "rule": "flow create 0 priority 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / tcp src is 50 dst is 23 / end actions vf id 1 / end",
+    "rule": "flow create 0 priority 0 ingress pattern eth dst is 00:11:22:33:44:55 / vlan tci is 2 / vlan tci is 1 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 / tcp src is 50 dst is 23 / end actions represented_port ethdev_port_id 1 / end",
     "scapy_str": {
         "matched": [
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2020")/TCP(sport=50,dport=23)/("X"*80)'
@@ -397,7 +397,7 @@ tv_mac_qinq_ipv6_tcp = {
             'Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=2,type=0x8100)/Dot1Q(vlan=0x1,type=0x86DD)/IPv6(dst="CDCD:910A:2222:5498:8475:1111:3900:2023")/TCP(sport=50,dport=22)/("X"*80)',
         ],
     },
-    "check_param": {"port_id": 1},
+    "check_param": {"port_id": 2},
 }
 
 tvs_mac_l4_qinq_dcf_pipeline_mode = [tv_mac_qinq_ipv6_udp, tv_mac_qinq_ipv6_tcp]
@@ -703,9 +703,9 @@ class TestICEQinq(TestCase):
         self.verify(all(test_results.values()), "{} failed.".format(failed_cases))
 
     def start_tcpdump(self, rxItf):
-        self.tester.send_expect("rm -rf getPackageByTcpdump.cap", "#")
+        self.tester.send_expect("rm -rf getPackageByTcpdump.pcap", "#")
         self.tester.send_expect(
-            "tcpdump -A -nn -e -vv -w getPackageByTcpdump.cap -i %s 2> /dev/null& "
+            "tcpdump -A -nn -e -vv -w getPackageByTcpdump.pcap -i %s 2> /dev/null& "
             % rxItf,
             "#",
         )
@@ -715,7 +715,7 @@ class TestICEQinq(TestCase):
         time.sleep(1)
         self.tester.send_expect("killall tcpdump", "#")
         return self.tester.send_expect(
-            "tcpdump -A -nn -e -vv -r getPackageByTcpdump.cap", "#"
+            "tcpdump -A -nn -e -vv -r getPackageByTcpdump.pcap", "#"
         )
 
     def test_mac_qinq_ipv4_pay(self):
@@ -723,7 +723,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_IPV4_PAY
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_ipv4_pay)
 
     def test_mac_qinq_ipv6_pay(self):
@@ -731,7 +731,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_IPV6_PAY
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_ipv6_pay)
 
     @skip_unsupported_pkg("os default")
@@ -740,7 +740,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_PPPOE_PAY
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_pppoe_pay)
 
     @skip_unsupported_pkg("os default")
@@ -749,7 +749,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_PPPOE_PAY_Proto
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_pppoe_proto)
 
     @skip_unsupported_pkg("os default")
@@ -758,7 +758,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_PPPOE_IPV4
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_pppoe_ipv4)
 
     @skip_unsupported_pkg("os default")
@@ -767,7 +767,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_QINQ_PPPOE_IPV6
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(mac_qinq_pppoe_ipv6)
 
     def test_mac_l4_qinq_dcf_non_pipeline_mode(self):
@@ -775,7 +775,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_L4_QINQ
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(tvs_mac_l4_qinq_dcf_non_pipeline_mode)
 
     def test_mac_l4_qinq_dcf_pipeline_mode(self):
@@ -783,7 +783,7 @@ class TestICEQinq(TestCase):
         DCF switch for MAC_L4_QINQ_IPV6
         """
         self.setup_pf_vfs_env()
-        self.launch_testpmd()
+        self.launch_testpmd(dcf_param=True)
         self._rte_flow_validate_pattern(tvs_mac_l4_qinq_dcf_pipeline_mode)
 
     def reset_vf(self):
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [DTS][PATCH V2 2/2] tests/ice_qinq: update test plan to support represented port action from deprecated vf action
  2022-12-07 11:18 ` [DTS][PATCH V2 2/2] tests/ice_qinq: " Ke Xu
@ 2022-12-12  9:56   ` Li, HongboX
  2022-12-13  6:14   ` lijuan.tu
  1 sibling, 0 replies; 5+ messages in thread
From: Li, HongboX @ 2022-12-12  9:56 UTC (permalink / raw)
  To: Xu, Ke1, dts; +Cc: Huang, ZhiminX

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]



> -----Original Message-----
> From: Ke Xu <ke1.xu@intel.com>
> Sent: 2022年12月7日 19:18
> To: dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Fu, Qi <qi.fu@intel.com>; Xu, Ke1
> <ke1.xu@intel.com>
> Subject: [DTS][PATCH V2 2/2] tests/ice_qinq: update test plan to support
> represented port action from deprecated vf action
> 
> Method calling of launch_testpmd is updated to enable representor.
> 
> Testpmd args are modified to support appyling representors for the  new API.
> Rules are modified for the old API being deprecated, changing  to the new
> API. Ports id are modified corresponding to the port
>   representors and modified API.
> 
> File names of packet capturing is renamed to .pcap to fix a no-reason  failure
> when using .cap
> 
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
> ---
Tested-by: Hongbo Li < hongbox.li@intel.com>

[-- Attachment #2: TestICEQinq.log --]
[-- Type: application/octet-stream, Size: 2098234 bytes --]

[-- Attachment #3: TestICEQinq_os.log --]
[-- Type: application/octet-stream, Size: 868845 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [DTS][PATCH V2 2/2] tests/ice_qinq: update test plan to support represented port action from deprecated vf action
  2022-12-07 11:18 ` [DTS][PATCH V2 2/2] tests/ice_qinq: " Ke Xu
  2022-12-12  9:56   ` Li, HongboX
@ 2022-12-13  6:14   ` lijuan.tu
  1 sibling, 0 replies; 5+ messages in thread
From: lijuan.tu @ 2022-12-13  6:14 UTC (permalink / raw)
  To: dts, Ke Xu; +Cc: lijuan.tu, qi.fu, ke1.xu

On Wed,  7 Dec 2022 19:18:10 +0800, Ke Xu <ke1.xu@intel.com> wrote:
> Method calling of launch_testpmd is updated to enable representor.
> 
> Testpmd args are modified to support appyling representors for the
>  new API. Rules are modified for the old API being deprecated, changing
>  to the new API. Ports id are modified corresponding to the port
>   representors and modified API.
> 
> File names of packet capturing is renamed to .pcap to fix a no-reason
>  failure when using .cap
> 
> Signed-off-by: Ke Xu <ke1.xu@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-13  6:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 11:18 [DTS][PATCH V2 0/2] update test plans and tests to support represented port action and port representor action from deprecated vf action in ice_qinq Ke Xu
2022-12-07 11:18 ` [DTS][PATCH V2 1/2] test_plans/ice_qinq: update test plan to support represented port action from deprecated vf action Ke Xu
2022-12-07 11:18 ` [DTS][PATCH V2 2/2] tests/ice_qinq: " Ke Xu
2022-12-12  9:56   ` Li, HongboX
2022-12-13  6:14   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).