test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Jiang, YuX" <yux.jiang@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>,
	"Peng,  Yuan" <yuan.peng@intel.com>
Subject: Re: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove global configurations of hash filter case
Date: Wed, 15 Sep 2021 01:52:32 +0000	[thread overview]
Message-ID: <SJ0PR11MB5150A3A5A4243A3C9B153D96FEDB9@SJ0PR11MB5150.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9a77e18fbf3f4a0082a1db96be5e6ea5@intel.com>

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, September 14, 2021 3:57 PM
> To: Jiang, YuX <yux.jiang@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: RE: [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan:
> remove global configurations of hash filter case
> 
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Yu Jiang
> > Sent: 2021年8月19日 19:35
> > To: dts@dpdk.org
> > Cc: Jiang, YuX <yux.jiang@intel.com>
> > Subject: [dts] [PATCH V1 1/2]
> > test_plans/fortville_rss_input_test_plan: remove global configurations
> > of hash filter case
> >
> > According to dpdk commit 81db321da ethdev: remove legacy HASH filter
> > type support, remove case test_global_hash_configuration
> >
> > Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> 
> dpdk commit 81db321da says "Instead of HASH filter RTE flow API should be
> used"
> Is the RTE flow API for HASH filter already in dts ? if yes, could you provide
> the position.
> 
I check this suite has one case: Test Case: test query RSS rule  includes "testpmd> flow create 0 ingress pattern end actions rss types end queues end func simple_xor / end" and verify rule's hash function.
And get_hash_global_config 0 Is not supported due to commit id, only can use " testpmd> flow query 0 0 rss" to query rss  hash function. If no, rss rule, it can not query rss hash. 
So this is why i remove this case. @Peng, Yuan Do you have any good suggestion about this?

> > ---
> >  test_plans/fortville_rss_input_test_plan.rst | 29
> > ----------------------------
> >  1 file changed, 29 deletions(-)
> >
> > diff --git a/test_plans/fortville_rss_input_test_plan.rst
> > b/test_plans/fortville_rss_input_test_plan.rst
> > index 1f249ac..a73b1b5 100644
> > --- a/test_plans/fortville_rss_input_test_plan.rst
> > +++ b/test_plans/fortville_rss_input_test_plan.rst
> > @@ -58,35 +58,6 @@ Prerequisites
> >      testpmd>set verbose 1
> >      testpmd>start
> >
> > -Test Case: test global configurations of hash filter -
> > ====================================================
> > -
> > -create a rule that set global configurations of hash filters is toeplitz::
> > -
> > -    testpmd> flow create 0 ingress pattern end actions rss types end
> queues end
> > func simple_xor / end
> > -    testpmd> flow list 0
> > -
> > -verify the Rule is RSS.
> > -
> > -get the status of hash configuration::
> > -
> > -    testpmd> get_hash_global_config 0
> > -
> > -verify Hash function is simple_xor.
> > -
> > -delete the rule::
> > -
> > -    testpmd> flow flush 0
> > -    testpmd> flow list 0
> > -
> > -verify the rules have been destroyed.
> > -
> > -get the status of hash configuration::
> > -
> > -    testpmd> get_hash_global_config 0
> > -
> > -verify Hash function is toeplitz.
> > -
> >  Test Case: test symmetric hash configuration
> > ============================================
> >
> > --
> > 2.7.4
> 


  reply	other threads:[~2021-09-15  1:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 11:35 [dts] [PATCH V1 0/2] remove fortville_rss_input/global_hash_configuration Yu Jiang
2021-08-19 11:35 ` [dts] [PATCH V1 1/2] test_plans/fortville_rss_input_test_plan: remove global configurations of hash filter case Yu Jiang
2021-09-14  7:57   ` Tu, Lijuan
2021-09-15  1:52     ` Jiang, YuX [this message]
2021-08-19 11:35 ` [dts] [PATCH V1 2/2] tests/fortville_rss_input: " Yu Jiang
2021-09-14  6:06   ` Jiang, YuX
2021-09-14  6:30     ` Peng, Yuan
2021-09-15  3:47       ` Tu, Lijuan
2021-09-14  5:54 ` [dts] [PATCH V1 0/2] remove fortville_rss_input/global_hash_configuration Jiang, YuX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR11MB5150A3A5A4243A3C9B153D96FEDB9@SJ0PR11MB5150.namprd11.prod.outlook.com \
    --to=yux.jiang@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).