From: "Lin, Xueqin" <xueqin.lin@intel.com>
To: "Xia, YanX" <yanx.xia@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xia, YanX" <yanx.xia@intel.com>
Subject: Re: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case design is unreasonable
Date: Mon, 25 Oct 2021 01:59:54 +0000 [thread overview]
Message-ID: <SJ0PR11MB55995EAE2FCC16618D3060FA94839@SJ0PR11MB5599.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211022155933.62573-3-yanx.xia@intel.com>
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Yan Xia
> Sent: Saturday, October 23, 2021 12:00 AM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/kernelpf_iavf: modify dts because case
> design is unreasonable
>
> validate strip function need to enable vlan filter and received the packets, in
> addition, strip function has nothing to do with driver version.
>
> Signed-off-by: Yan Xia <yanx.xia@intel.com>
Acked-by: Xueqin Lin <xueqin.lin@intel.com>
> ---
> tests/TestSuite_kernelpf_iavf.py | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index 6a858fc5..ff1f83a6 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -529,29 +529,31 @@ class TestKernelpfIavf(TestCase):
> random_vlan = random.randint(1, MAX_VLAN)
> self.vm_testpmd.start_testpmd("all")
> self.vm_testpmd.execute_cmd("port stop all")
> - self.vm_testpmd.execute_cmd("vlan set filter off 0")
> + self.vm_testpmd.execute_cmd("vlan set filter on 0")
> + self.vm_testpmd.execute_cmd("rx_vlan add %s 0" % random_vlan)
> self.vm_testpmd.execute_cmd("vlan set strip off 0")
> - self.vm_testpmd.execute_cmd("vlan set strip on 0")
> self.vm_testpmd.execute_cmd("port start all")
> self.vm_testpmd.execute_cmd("set fwd mac")
> self.vm_testpmd.execute_cmd("set verbose 1")
> self.vm_testpmd.execute_cmd("start")
> +
> + #enable strip
> + self.vm_testpmd.execute_cmd("vlan set strip on 0")
> self.start_tcpdump(self.tester_intf)
> self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
> tcpdump_out = self.get_tcpdump_package()
> - receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> - self.verify(len(receive_pkt) == 1, 'Failed to received vlan packet!!!')
> + self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac
> in tcpdump_out, 'Failed to received packet!!!')
> + receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> + self.verify(len(receive_vlan_pkt) == 1, 'Failed to received
> + vlan packet!!!')
>
> # disable strip
> self.vm_testpmd.execute_cmd("vlan set strip off 0")
> self.start_tcpdump(self.tester_intf)
> self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
> tcpdump_out = self.get_tcpdump_package()
> - receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> - if self.driver_version < "2.13.10" or self.kdriver == 'ice':
> - self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
> - else:
> - self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
> + self.verify('> %s' % self.vf_mac in tcpdump_out and '%s >' % self.vf_mac
> in tcpdump_out, 'Failed to received packet!!!')
> + receive_vlan_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> + self.verify(len(receive_vlan_pkt) == 2, 'Failed to not received
> + vlan packet!!!')
>
> def test_vf_vlan_filter(self):
> random_vlan = random.randint(2, MAX_VLAN)
> --
> 2.33.1
next prev parent reply other threads:[~2021-10-25 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 15:59 [dts] [PATCH V2 0/2] *** modify dts because case design is unreasonable *** Yan Xia
2021-10-22 15:59 ` [dts] [PATCH V2 1/2] test_plans/kernelpf_iavf : modify dts because case design is unreasonable Yan Xia
2021-10-22 15:59 ` [dts] [PATCH V2 2/2] tests/kernelpf_iavf: " Yan Xia
2021-10-22 8:37 ` Chen, LingliX
2021-10-25 1:59 ` Lin, Xueqin [this message]
2021-10-25 8:45 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB55995EAE2FCC16618D3060FA94839@SJ0PR11MB5599.namprd11.prod.outlook.com \
--to=xueqin.lin@intel.com \
--cc=dts@dpdk.org \
--cc=yanx.xia@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).