From: "Zhao, HaiyangX" <haiyangx.zhao@intel.com>
To: "Ling, WeiX" <weix.ling@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ling, WeiX" <weix.ling@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid code
Date: Tue, 16 Mar 2021 02:30:57 +0000 [thread overview]
Message-ID: <SN6PR11MB28941E9A9E553EBB4C749ADBF46B9@SN6PR11MB2894.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210315100136.27966-1-weix.ling@intel.com>
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling Wei
> Sent: Monday, March 15, 2021 18:02
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid
> code
>
> Delete self.stop_send_pkts_on_tester() step in tear_down, because of
> framework will auto stop pktgen.
>
> Signed-off-by: Ling Wei <weix.ling@intel.com>
> ---
> tests/TestSuite_vhost_user_live_migration.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_vhost_user_live_migration.py
> b/tests/TestSuite_vhost_user_live_migration.py
> index 915fa596..d5d1af65 100644
> --- a/tests/TestSuite_vhost_user_live_migration.py
> +++ b/tests/TestSuite_vhost_user_live_migration.py
> @@ -449,7 +449,7 @@ class TestVhostUserLiveMigration(TestCase):
> def tear_down(self):
> self.destroy_vm_env()
> # stop send packet on tester
> - self.stop_send_pkts_on_tester()
> + # self.stop_send_pkts_on_tester()
Hi, wei,
If the code should removed, just delete it instead of commentting it, and the comments should be removed too.
prev parent reply other threads:[~2021-03-16 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:01 Ling Wei
2021-03-16 1:37 ` Ling, WeiX
2021-03-16 2:30 ` Zhao, HaiyangX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB28941E9A9E553EBB4C749ADBF46B9@SN6PR11MB2894.namprd11.prod.outlook.com \
--to=haiyangx.zhao@intel.com \
--cc=dts@dpdk.org \
--cc=weix.ling@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).