[dts] [PATCH V1] framework/crb: optimize code

[dts] [PATCH V1] framework/crb: optimize code

[Haiyang Zhao]

when the param dut_arch in conf/crbs.cfg not exist, dts will generate
a keyerror exception and terminate the test, but this param could not
be set actually.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/crb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/crb.py b/framework/crb.py
index cd29b8e3..e7c1cc1c 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -666,7 +666,7 @@ class Crb(object):
             if self.crb['bypass core0'] and core == '0' and socket == '0':
                 self.logger.info("Core0 bypassed")
                 continue
-            if self.crb['dut arch'] == "arm64":
+            if self.crb.get('dut arch') == "arm64":
                 self.cores.append(
                         {'thread': thread, 'socket': node, 'core': coremap[core]})
             else:
-- 
2.17.1

Re: [dts] [PATCH V1] framework/crb: optimize code

[Zhao, HaiyangX]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]



> -----Original Message-----
> From: Haiyang Zhao <haiyangx.zhao@intel.com>
> Sent: Friday, March 26, 2021 11:20
> To: dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>
> Subject: [dts][PATCH V1] framework/crb: optimize code

Tested-by: Haiyang Zhao <haiyangx.zhao@intel.com>

[-- Attachment #2: TestUnitTestsCmdline.log --]
[-- Type: application/octet-stream, Size: 2200 bytes --]

26/03/2021 11:17:52                            dts: 
TEST SUITE : TestUnitTestsCmdline
26/03/2021 11:17:52                            dts: NIC :        fortville_25g
26/03/2021 11:17:52              dut.10.240.183.72: 
26/03/2021 11:17:52                         tester: 
26/03/2021 11:17:52           TestUnitTestsCmdline: Test Case test_cmdline Begin
26/03/2021 11:17:52              dut.10.240.183.72: 
26/03/2021 11:17:52                         tester: 
26/03/2021 11:17:52              dut.10.240.183.72: x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87 -n 4   --file-prefix=dpdk_25594_20210326111736  
26/03/2021 11:17:54              dut.10.240.183.72: EAL: Detected 88 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/dpdk_25594_20210326111736/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL:   using IOMMU type 1 (Type 1)
EAL: Ignore mapping IO port bar(1)
EAL: Ignore mapping IO port bar(4)
EAL: Probe PCI driver: net_i40e (8086:158b) device: 0000:81:00.0 (socket 1)
EAL: Ignore mapping IO port bar(1)
EAL: Ignore mapping IO port bar(4)
EAL: Probe PCI driver: net_i40e (8086:158b) device: 0000:81:00.1 (socket 1)
APP: HPET is not enabled, using TSC as default timer
26/03/2021 11:17:54              dut.10.240.183.72: cmdline_autotest
26/03/2021 11:17:54              dut.10.240.183.72: 
Testind parsing ethernet addresses...
Testind parsing port lists...
Testind parsing numbers...
Testing parsing IP addresses...
Testing parsing strings...
Testing circular buffer...
Testing library functions...
Test OK
26/03/2021 11:17:54              dut.10.240.183.72: quit
26/03/2021 11:17:54              dut.10.240.183.72: 
26/03/2021 11:17:54           TestUnitTestsCmdline: Test Case test_cmdline Result PASSED:
26/03/2021 11:17:54                            dts: 
TEST SUITE ENDED: TestUnitTestsCmdline

Re: [dts] [PATCH V1] framework/crb: optimize code

[Tu, Lijuan]

> -----Original Message-----
> From: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Sent: 2021年3月26日 11:31
> To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>
> Subject: RE: [dts][PATCH V1] framework/crb: optimize code
> 
> 
> 
> > -----Original Message-----
> > From: Haiyang Zhao <haiyangx.zhao@intel.com>
> > Sent: Friday, March 26, 2021 11:20
> > To: dts@dpdk.org
> > Cc: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> > <haiyangx.zhao@intel.com>
> > Subject: [dts][PATCH V1] framework/crb: optimize code
> 
> Tested-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Applied