From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0075.outbound.protection.outlook.com [104.47.2.75]) by dpdk.org (Postfix) with ESMTP id 6A3485592 for ; Mon, 5 Mar 2018 03:14:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Rd6CjszfBjotBYFrJUzkfyQkSfZ2wbvK/7j3jAf7nnY=; b=Z9qPb3zHobJxB1u/E170zZYX6pjHqmrSPdCq2fgzwTT/CsQw9aitpne+6BDfMGES/bYUdJS31UuGzOgl1c2ZD2XNVw3hN7bKRBohFS9uj6sEm2OGxXpqXy+SO8WosuGvYt2d+PW6E/+VEgSh47Fq+PJ0lM/Gk5+xYAA9SSGgdiM= Received: from VI1PR08MB2813.eurprd08.prod.outlook.com (10.170.236.150) by VI1PR08MB3087.eurprd08.prod.outlook.com (52.133.15.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 5 Mar 2018 02:14:07 +0000 Received: from VI1PR08MB2813.eurprd08.prod.outlook.com ([fe80::c847:9446:6ec7:4952]) by VI1PR08MB2813.eurprd08.prod.outlook.com ([fe80::c847:9446:6ec7:4952%13]) with mapi id 15.20.0548.014; Mon, 5 Mar 2018 02:14:07 +0000 From: Herbert Guan To: "Liu, Yong" , "dts@dpdk.org" CC: nd Thread-Topic: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AQHTscs97QlLlGAMbkG08/vzmmkiAqO8gdawgAATpACABFTk0A== Date: Mon, 5 Mar 2018 02:14:07 +0000 Message-ID: References: <1518589716-27299-1-git-send-email-herbert.guan@arm.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62FA5E0C@SHSMSX103.ccr.corp.intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62FA71F5@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62FA71F5@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Herbert.Guan@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3087; 7:2J3VTnBdzKlFDr2A33HExMU5Dd26BkK1w4E6ObCoKN5k0Nhzt3WNtc+1r5EQ4OWqXxll9A1CzxkUaDlAzobGb9dK4ScrkNxK+paNUdzjeyPJ3mEXJWoi2L1FTenXnFLB5SUaybydT9w02obXqL2LtLxMsatdHnDapyifRLSF8NHpqHwLF1IKanjXpxxH2pUnSI015OFOLewNi3Vz5QwNk8cFxad+f9tPsHka/xl9VWzMYxVpl4y3PDvPk18DNfaH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d1d5dc98-3a19-4f45-1532-08d5823ec6e2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:VI1PR08MB3087; x-ms-traffictypediagnostic: VI1PR08MB3087: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR08MB3087; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3087; x-forefront-prvs: 06022AA85F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(366004)(396003)(39860400002)(13464003)(199004)(189003)(2501003)(26005)(5250100002)(3660700001)(478600001)(59450400001)(66066001)(7736002)(305945005)(106356001)(72206003)(110136005)(229853002)(93886005)(6436002)(99286004)(316002)(5660300001)(86362001)(575784001)(97736004)(76176011)(6506007)(105586002)(14454004)(53936002)(25786009)(53546011)(33656002)(9686003)(2900100001)(3280700002)(2950100002)(55236004)(6116002)(3846002)(55016002)(102836004)(6246003)(81166006)(81156014)(186003)(8936002)(68736007)(7696005)(2906002)(4326008)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3087; H:VI1PR08MB2813.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qPDR7ajmjlhk3hnWX3cnsBD3LOqmVQrPyR4E6Oqawhbh4nPMIWLpzIrTXjxzrWxx1kp1BGHx4y41zLKGGmP+2abWKxURBfVAfXv0mP4Gej3cIz1IsEWrv9P8khHLtJRdNpvTxBNz0ng6pE3iLd1K3m+XgvrpA7KmOnhV9C5Zyq0I5QY1AKcfLrRvkC0MEDHAImGQYDuliX8ln6ZEeytHbU6lsVi4ahi96IkoHw6BRGXJXZM8EECSktI1/d2gyd8nnMQYloIUCTg0LzZZogDnBvhJcYyT8uQhKZN/RU7IQS5samor8TZN3fjG0JgS5I1n+iG/0QjrU9QIvQO2jWFCaQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1d5dc98-3a19-4f45-1532-08d5823ec6e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2018 02:14:07.7831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3087 Subject: Re: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 02:14:12 -0000 Hi Marvin, This seems to the right approach. Let's abandon this patch, and a new patc= h dedicated for "Clear port stats before send/recv test packets" will be submitted later. Best regards, Herbert > -----Original Message----- > From: Liu, Yong [mailto:yong.liu@intel.com] > Sent: Friday, March 2, 2018 16:01 > To: Herbert Guan ; dts@dpdk.org > Cc: nd > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failure= s in > vf_reset >=20 > Herbert, > We have also incurred your problem in some VF related cases. Look like mo= st > VF related cases need one default module (igb_uio or vfio noiommu) in VM. > As default module should be bound with VM, I'd like to add one global opt= ion > for this default module. > Meanwhile test suite can change the default value in their own configurat= ion. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: Herbert Guan [mailto:Herbert.Guan@arm.com] > > Sent: Friday, March 02, 2018 2:58 PM > > To: Liu, Yong ; dts@dpdk.org > > Cc: nd > > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case > > failures in vf_reset > > > > Marvin, > > > > When the execution config file selects driver mode to a certain mode > > (vfio, igb_uio, etc.), then both host and VM NICs will use this mode > > in case setup. If some case need VM to use the igb_uio mode, > > regardless of the driver mode in execution configure file, we need to > > ensure the required drivers have been installed. > > > > If we want to restore the environment, we need to add some extra logic > > to the case script. If the uio or igb_uio driver is not installed, > > then install it and make flag. This script need to remove installed > > drivers that were not installed before running the test. > > > > Best regards, > > Herbert > > > > > -----Original Message----- > > > From: Liu, Yong [mailto:yong.liu@intel.com] > > > Sent: Friday, March 2, 2018 10:08 > > > To: Herbert Guan ; dts@dpdk.org > > > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case > > failures in > > > vf_reset > > > > > > Hi Herbert, > > > Why required driver is not insmod be previous setup? > > > As one principle, we want to limit the influence of environment > > > change > > in the > > > suite. > > > > > > Thanks, > > > Marvin > > > > > > > -----Original Message----- > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan > > > > Sent: Wednesday, February 14, 2018 2:29 PM > > > > To: dts@dpdk.org > > > > Cc: Herbert Guan > > > > Subject: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case > > > > failures in vf_reset > > > > > > > > 1) Clear port stats before send/recv test packets > > > > 2) Ensure igb_uio driver is installed if driver=3D'igb_uio' > > > > > > > > > > > > Signed-off-by: Herbert Guan > > > > --- > > > > tests/TestSuite_vf_packet_rxtx.py | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > > > b/tests/TestSuite_vf_packet_rxtx.py > > > > index 63f4820..f0b7721 100644 > > > > --- a/tests/TestSuite_vf_packet_rxtx.py > > > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > > > @@ -125,6 +125,9 @@ class TestVfPacketRxtx(TestCase): > > > > def packet_rx_tx(self, driver=3D'default'): > > > > > > > > if driver =3D=3D 'igb_uio': > > > > + # ensure igb_uio driver is installed > > > > + self.dut.send_expect('(lsmod | grep uio) || (modprobe > > > > + uio)', > > > > '#') > > > > + self.dut.send_expect('(lsmod | grep igb_uio) || > > > > (insmod ./%s/kmod/igb_uio.ko)' % self.target,'#') > > > > self.setup_2pf_2vf_1vm_env(driver=3D'igb_uio') > > > > else: > > > > self.setup_2pf_2vf_1vm_env(driver=3D'') > > > > @@ -279,6 +282,7 @@ class TestVfPacketRxtx(TestCase): > > > > rx_port =3D tx_port > > > > > > > > dst_mac =3D pmd0_vf0_mac > > > > + self.vm0_testpmd.execute_cmd('clear port stats all') > > > > self.tester.sendpkt_bg(tx_port, dst_mac) > > > > > > > > #vf port stop/start can trigger reset action > > > > -- > > > > 1.8.3.1