Re: [dts] [PATCH V1 0/2] adapt to CVL NIC

Re: [dts] [PATCH V1 0/2] adapt to CVL NIC

[Xie, WeiX]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

> -----Original Message-----
> From: Xie, WeiX <weix.xie@intel.com>
> Sent: Thursday, April 1, 2021 12:47 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 0/2] adapt to CVL NIC

Tested-by: Xie Wei <weix.xie@intel.com>

[-- Attachment #2: TestRxTx_Offload.log --]
[-- Type: application/octet-stream, Size: 2106919 bytes --]

[dts] [PATCH V1 0/2] adapt to CVL NIC

[xiewei]

modify suite and test_plan to support CVL.

xiewei (2):
  test_plans/rxtx_offload_test_plan: adapt to CVL NIC
  tests/rxtx_offload: adapt to CVL NIC

 test_plans/rxtx_offload_test_plan.rst | 14 ++++++++++++++
 tests/TestSuite_rxtx_offload.py       |  8 ++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.17.1

[dts] [PATCH V1 1/2] test_plans/rxtx_offload_test_plan: adapt to CVL NIC

[xiewei]

for ice NIC, it failed to enable mbuf_fast_free per_queue.

Signed-off-by: xiewei <weix.xie@intel.com>
---
 test_plans/rxtx_offload_test_plan.rst | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/test_plans/rxtx_offload_test_plan.rst b/test_plans/rxtx_offload_test_plan.rst
index 246e1e16..b107aba7 100644
--- a/test_plans/rxtx_offload_test_plan.rst
+++ b/test_plans/rxtx_offload_test_plan.rst
@@ -643,6 +643,20 @@ Test case: FVL Tx offload per-queue setting
 
    The port fwd can be started normally.
 
+Note:
+
+But for ice NIC, it failed to enable mbuf_fast_free per_queue::
+
+    testpmd> port stop 0
+    testpmd> port 0 txq 0 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 1 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 2 tx_offload mbuf_fast_free on
+    testpmd> port 0 txq 3 tx_offload mbuf_fast_free on
+    testpmd> port start 0
+    Configuring Port 0 (socket 0)
+    Ethdev port_id=0 tx_queue_id=0, new added offloads 0x10000 must be within per-queue offload capabilities 0x0 in rte_eth_tx_queue_setup()
+    Fail to configure port 0 tx queues
+
 4. Disable mbuf_fast_free per_queue::
 
     testpmd> port stop 0
-- 
2.17.1

[dts] [PATCH V1 2/2] tests/rxtx_offload: adapt to CVL NIC

[xiewei]

rxtx_offload/txoffload_queue: it failed to enable mbuf_fast_free per_queue.

Signed-off-by: xiewei <weix.xie@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index 0e70526f..6b121ade 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -698,8 +698,12 @@ class TestRxTx_Offload(TestCase):
         self.dut.send_expect("port 0 txq 1 tx_offload mbuf_fast_free on", "testpmd> ")
         self.dut.send_expect("port 0 txq 2 tx_offload mbuf_fast_free on", "testpmd> ")
         self.dut.send_expect("port 0 txq 3 tx_offload mbuf_fast_free on", "testpmd> ")
-        offload = ["mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free"]
-        self.check_queue_config("tx", offload)
+        if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            out = self.dut.send_expect("port start 0", "testpmd> ")
+            self.verify("Fail to configure port 0 tx queues" in out, "mbuf_fast_free can be set by queue.")
+        else:
+            offload = ["mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free", "mbuf_fast_free"]
+            self.check_queue_config("tx", offload)
 
         # Disable mbuf_fast_free per_queue.
         self.dut.send_expect("port stop 0", "testpmd> ")
-- 
2.17.1

Re: [dts] [PATCH V1 1/2] test_plans/rxtx_offload_test_plan: adapt to CVL NIC

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xiewei
> Sent: 2021年4月1日 0:47
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1 1/2] test_plans/rxtx_offload_test_plan: adapt to CVL
> NIC
> 
> for ice NIC, it failed to enable mbuf_fast_free per_queue.
> 
> Signed-off-by: xiewei <weix.xie@intel.com>
> ---
>  test_plans/rxtx_offload_test_plan.rst | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/test_plans/rxtx_offload_test_plan.rst
> b/test_plans/rxtx_offload_test_plan.rst
> index 246e1e16..b107aba7 100644
> --- a/test_plans/rxtx_offload_test_plan.rst
> +++ b/test_plans/rxtx_offload_test_plan.rst
> @@ -643,6 +643,20 @@ Test case: FVL Tx offload per-queue setting
> 
>     The port fwd can be started normally.
> 
> +Note:
> +
> +But for ice NIC, it failed to enable mbuf_fast_free per_queue::
> +
> +    testpmd> port stop 0
> +    testpmd> port 0 txq 0 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 1 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 2 tx_offload mbuf_fast_free on
> +    testpmd> port 0 txq 3 tx_offload mbuf_fast_free on
> +    testpmd> port start 0
> +    Configuring Port 0 (socket 0)
> +    Ethdev port_id=0 tx_queue_id=0, new added offloads 0x10000 must be
> within per-queue offload capabilities 0x0 in rte_eth_tx_queue_setup()
> +    Fail to configure port 0 tx queues

Seems it is a bug on cvl, at least a feature gap.


>  4. Disable mbuf_fast_free per_queue::
> 
>      testpmd> port stop 0
> --
> 2.17.1