test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version
@ 2021-01-18  7:35 Xie wei
  2021-01-18  7:36 ` Xie, WeiX
  2021-01-21  8:03 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Xie wei @ 2021-01-18  7:35 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

In set_up_all func, the device can't be used which is bound to vfio-pci.
So adjust the order of getting nic driver version.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 68f16096..2fed9b7f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -94,10 +94,6 @@ class TestKernelpfIavf(TestCase):
         self.tester_intf1 = self.tester.get_interface(tester_port1)
         self.l3fwdpower_name = self.dut.apps_name['l3fwd-power'].strip().split('/')[-1]
 
-        # get driver version
-        out = self.dut.send_expect("ethtool -i %s | awk -F':' 'NR==2{print $2}'" % self.host_intf, "# ")
-        self.driver_version = out.replace(" ", "")
-
     def set_up(self):
 
         if self.running_case == "test_vf_mac_filter":
@@ -159,6 +155,10 @@ class TestKernelpfIavf(TestCase):
             self.dut.send_expect("ip link set %s vf 0 mac %s" %
                                  (self.host_intf, self.vf_mac), "# ")
 
+        # get driver version
+        out = self.dut.send_expect("ethtool -i %s | awk -F':' 'NR==2{print $2}'" % self.host_intf, "# ")
+        self.driver_version = out.replace(" ", "")
+
         try:
 
             for port in self.sriov_vfs_port:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version
  2021-01-18  7:35 [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version Xie wei
@ 2021-01-18  7:36 ` Xie, WeiX
  2021-01-19  9:02   ` Zhao, HaiyangX
  2021-01-21  8:03 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Xie, WeiX @ 2021-01-18  7:36 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Monday, January 18, 2021 3:36 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC
> driver version

[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 65379 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version
  2021-01-18  7:36 ` Xie, WeiX
@ 2021-01-19  9:02   ` Zhao, HaiyangX
  0 siblings, 0 replies; 4+ messages in thread
From: Zhao, HaiyangX @ 2021-01-19  9:02 UTC (permalink / raw)
  To: Xie, WeiX, dts

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie, WeiX
> Sent: Monday, January 18, 2021 15:36
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting
> NIC driver version
> 
> Tested-by:  Xie,WeiX < weix.xie@intel.com>
> 
> Regards,
> Xie Wei
> 
> 
> > -----Original Message-----
> > From: Xie wei [mailto:weix.xie@intel.com]
> > Sent: Monday, January 18, 2021 3:36 PM
> > To: dts@dpdk.org
> > Cc: Xie, WeiX <weix.xie@intel.com>
> > Subject: [PATCH V1] tests/kernelpf_iavf: adjust the order of getting
> > NIC driver version

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version
  2021-01-18  7:35 [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version Xie wei
  2021-01-18  7:36 ` Xie, WeiX
@ 2021-01-21  8:03 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-01-21  8:03 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> In set_up_all func, the device can't be used which is bound to vfio-pci.
> So adjust the order of getting nic driver version.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-21  8:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18  7:35 [dts] [PATCH V1] tests/kernelpf_iavf: adjust the order of getting NIC driver version Xie wei
2021-01-18  7:36 ` Xie, WeiX
2021-01-19  9:02   ` Zhao, HaiyangX
2021-01-21  8:03 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git