From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDF28A0577; Wed, 15 Apr 2020 02:55:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EAA51D40F; Wed, 15 Apr 2020 02:55:55 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1B33B1D40E for ; Wed, 15 Apr 2020 02:55:52 +0200 (CEST) IronPort-SDR: 4z9P84ZUp/1YLal0IwYiOl/do3h13JKBeq1wQj8WBfrdh+UFoOagB2QJETzoHbjGzf5AVgLDGb bsBf+s5AgymA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 17:55:52 -0700 IronPort-SDR: Ab7FQAjhNuzqcA5C8LcFOdFDeUtCOFFko1NwnvBkGsMcI99xLrt+8P6On/FNcwOA/FEEOMC2U+ J4NXvnfRl9HA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,385,1580803200"; d="scan'208";a="427256887" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 14 Apr 2020 17:55:47 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 17:55:47 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 15 Apr 2020 08:55:45 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Wed, 15 Apr 2020 08:55:45 +0800 From: "Wang, Yinan" To: "Xiao, QimaiX" , "dts@dpdk.org" CC: "Xiao, QimaiX" Thread-Topic: [dts] [PATCH V1]pvp_vhost_user_built_in_net_driver: allocate memory for vhost-switch manually Thread-Index: AQHWEkFUPC5UBv26EUK/79+jmCR/Fqh5WeZw Date: Wed, 15 Apr 2020 00:55:44 +0000 Message-ID: References: <1586857093-450522-1-git-send-email-qimaix.xiao@intel.com> In-Reply-To: <1586857093-450522-1-git-send-email-qimaix.xiao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]pvp_vhost_user_built_in_net_driver: allocate memory for vhost-switch manually X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi Qimai, The patch comment is not correct, vhost-switch can support new memory alloc= ation, but need memory pre-allocation when enabling "builtin-net-driver". BR, Yinan > -----Original Message----- > From: dts On Behalf Of Xiao Qimai > Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B14=1B$BF|=1B(B 17:38 > To: dts@dpdk.org > Cc: Xiao, QimaiX > Subject: [dts] [PATCH V1]pvp_vhost_user_built_in_net_driver: allocate mem= ory > for vhost-switch manually >=20 > *. vhost-switch not support new memory allocation, add --socket-mem > parameter for it >=20 > Signed-off-by: Xiao Qimai > --- > tests/TestSuite_pvp_vhost_user_built_in_net_driver.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_pvp_vhost_user_built_in_net_driver.py > b/tests/TestSuite_pvp_vhost_user_built_in_net_driver.py > index cfdd704..3f55e7a 100644 > --- a/tests/TestSuite_pvp_vhost_user_built_in_net_driver.py > +++ b/tests/TestSuite_pvp_vhost_user_built_in_net_driver.py > @@ -171,7 +171,7 @@ class TestPVPVhostUserBuiltInNetDriver(TestCase): > start vhost-switch on vhost > """ > self.dut.send_expect("rm -rf ./vhost.out", "#") > - eal_param =3D self.dut.create_eal_parameters(socket=3Dself.ports= _socket, > cores=3Dself.core_list_vhost_user, prefix=3D'vhost') > + eal_param =3D > self.dut.create_eal_parameters(cores=3Dself.core_list_vhost_user, prefix= =3D'vhost') > command_line_client =3D "./examples/vhost/build/vhost-switch " + > eal_param + ' -- -p 0x1 --mergeable 0 --vm2vm 1 --builtin-net-driver --so= cket- > file ./vhost-net> ./vhost.out &' > self.vhost_switch.send_expect(command_line_client, "# ", 120) > time.sleep(15) > @@ -193,12 +193,13 @@ class TestPVPVhostUserBuiltInNetDriver(TestCase): > """ > start testpmd on virtio > """ > - eal_param =3D self.dut.create_eal_parameters(socket=3Dself.ports= _socket, > cores=3Dself.core_list_virtio_user, prefix=3D'virtio', > + eal_param =3D > self.dut.create_eal_parameters(cores=3Dself.core_list_virtio_user, prefix= =3D'virtio', > no_pci=3DTrue, vdevs= =3D[ > 'net_virtio_user0,mac=3D%s,path=3D./vhost-net,queues=3D1= ' % > self.virtio_mac]) > if self.check_2M_env: > eal_param +=3D " --single-file-segments" > - command_line_user =3D "./%s/app/testpmd " % self.target + eal_pa= ram + " -- > -i --rxq=3D1 --txq=3D1" > + # since vhost-switch not support new memory allocation, so add -= -socket- > mem parameter to testpmd to handle it > + command_line_user =3D "./%s/app/testpmd " % self.target + eal_pa= ram + " - > -socket-mem " + self.mem_size + " -- -i --rxq=3D1 --txq=3D1" > self.virtio_user.send_expect(command_line_user, "testpmd> ", 120= ) > self.virtio_user.send_expect("set fwd mac", "testpmd> ", 120) > self.virtio_user.send_expect("start tx_first", "testpmd> ", 120) > -- > 1.8.3.1