test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH v1] framework/pmd_output: fix pylama errors
@ 2021-11-24 14:12 Juraj Linkeš
  2022-01-14  8:00 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Juraj Linkeš @ 2021-11-24 14:12 UTC (permalink / raw)
  To: lijuan.tu, ohilyard; +Cc: dts, Juraj Linkeš

Pylama found the following errors:
framework/pmd_output.py:80: [E] E0704 The raise statement is not inside an except clause [pylint]

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
Lijuan, please add additional people to review if needed.
---
 framework/pmd_output.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index e2bf3687..113e85f6 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -77,7 +77,7 @@ class PmdOutput():
         """
         core_number = len(self.dut.cores)
         if core_number < 2:
-            raise
+            raise ValueError(f'Not enough cores on DUT {self.dut}')
         else:
             self.default_cores = "1S/2C/1T"
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v1] framework/pmd_output: fix pylama errors
  2021-11-24 14:12 [PATCH v1] framework/pmd_output: fix pylama errors Juraj Linkeš
@ 2022-01-14  8:00 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2022-01-14  8:00 UTC (permalink / raw)
  To: Juraj Linkeš, ohilyard; +Cc: dts

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: 2021年11月24日 22:13
> To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] framework/pmd_output: fix pylama errors
> 
> Pylama found the following errors:
> framework/pmd_output.py:80: [E] E0704 The raise statement is not inside an
> except clause [pylint]
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-14  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 14:12 [PATCH v1] framework/pmd_output: fix pylama errors Juraj Linkeš
2022-01-14  8:00 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git