test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error
@ 2020-09-23  5:16 xizhan4x
  2020-09-23  5:35 ` Zhang, XiX
  2020-10-12  8:15 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: xizhan4x @ 2020-09-23  5:16 UTC (permalink / raw)
  To: dts; +Cc: xizhan4x

Fix package error and add vxlan Tunnel

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_checksum_offload.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 8f212cb..c917a15 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -129,6 +129,7 @@ class TestChecksumOffload(TestCase):
 
     def checksum_enablehw(self, port):
         self.dut.send_expect("port stop all", "testpmd>")
+        self.dut.send_expect("rx_vxlan_port add 4789 0 ", "testpmd>")
         self.dut.send_expect("csum set ip hw %d" % port, "testpmd>")
         self.dut.send_expect("csum set udp hw %d" % port, "testpmd>")
         self.dut.send_expect("csum set tcp hw %d" % port, "testpmd>")
@@ -685,7 +686,6 @@ class TestChecksumOffload(TestCase):
             self.result_table_print()
 
     def test_hardware_checksum_check_ip_rx(self):
-        self.dut.send_expect("start", "testpmd>")
         self.tester.send_expect("scapy", ">>>")
         self.checksum_enablehw(self.dut_ports[0])
         self.dut.send_expect("start", "testpmd>")
@@ -791,8 +791,9 @@ class TestChecksumOffload(TestCase):
 
         # Tunneled
         # VXLAN
+        VXLAN_l4_protos=['UDP']
         for l3 in l3_protos:
-            for l4 in l4_protos:
+            for l4 in VXLAN_l4_protos:
                 for outer_arg in "", "chksum=0xf":
                     for inner_arg in "", "chksum=0xf":
                         for flag in "PKT_RX_L4_CKSUM_", "PKT_RX_OUTER_L4_CKSUM_":
@@ -801,8 +802,8 @@ class TestChecksumOffload(TestCase):
                             else:  # flag == PKT_RX_OUTER_L4_CKSUM_
                                 should_pass = outer_arg == ""
                             vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                                f"eth/{l3}()/{l4}({outer_arg})/VXLAN()/{l3}()/"
-                                f"{l4}(chksum={inner_arg})/('X'*50)",
+                                f"eth/{l3}()/{l4}(dport=4789,{outer_arg})/VXLAN()/eth/{l3}()/"
+                                f"{l4}({inner_arg})/('X'*50)",
                                 flag, f"{l3}/{l4}/VXLAN/{l3}/{l4}",
                                 should_pass=should_pass)
 
@@ -846,7 +847,7 @@ class TestChecksumOffload(TestCase):
         #                             if vf is not None:
         #                                 verification_errors.append(vf)
 
-        self.tester.send_expect("quit", "#")
+        self.tester.send_expect("quit()", "#")
         self.dut.send_expect("stop", "testpmd>")
 
         for err in verification_errors:
@@ -871,7 +872,7 @@ class TestChecksumOffload(TestCase):
         packet_file_path = "/tmp/test_hardware_checksum_check_l4_tx_packets.pcap"
         capture_file_path = "/tmp/tester/" + capture_file_name
 
-        self.tester.send_expect(f"tcpdump -i {iface} -s 65535 -w {capture_file_path} &", "# ")
+        self.tester.send_expect(f"tcpdump -i '{iface}' -s 65535 -w {capture_file_path} &", "# ")
 
         wrpcap(packet_file_path, packets)
         self.tester.session.copy_file_to(packet_file_path, packet_file_path)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error
  2020-09-23  5:16 [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error xizhan4x
@ 2020-09-23  5:35 ` Zhang, XiX
  2020-09-29  1:29   ` Ma, LihongX
  2020-10-12  8:15 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Zhang, XiX @ 2020-09-23  5:35 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Tested-by: Zhang, XiX <xix.zhang@intel.com>


Regards,
Zhang, Xi

> -----Original Message-----
> From: Zhang, XiX
> Sent: Wednesday, September 23, 2020 1:17 PM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts][PATCH V1] tests/TestSuite_checksum_offload:Fix package error


[-- Attachment #2: TestChecksumOffload.log --]
[-- Type: application/octet-stream, Size: 21749 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error
  2020-09-23  5:35 ` Zhang, XiX
@ 2020-09-29  1:29   ` Ma, LihongX
  0 siblings, 0 replies; 4+ messages in thread
From: Ma, LihongX @ 2020-09-29  1:29 UTC (permalink / raw)
  To: Zhang, XiX, dts

Acked-by: Lihong Ma<lihongx.ma@intel.com>

Regards,
Ma,lihong

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhang, XiX
> Sent: Wednesday, September 23, 2020 1:35 PM
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package
> error


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error
  2020-09-23  5:16 [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error xizhan4x
  2020-09-23  5:35 ` Zhang, XiX
@ 2020-10-12  8:15 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2020-10-12  8:15 UTC (permalink / raw)
  To: Zhang, XiX, dts; +Cc: Zhang, XiX

> Fix package error and add vxlan Tunnel
> 
> Signed-off-by: xizhan4x <xix.zhang@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23  5:16 [dts] [PATCH V1] tests/TestSuite_checksum_offload:Fix package error xizhan4x
2020-09-23  5:35 ` Zhang, XiX
2020-09-29  1:29   ` Ma, LihongX
2020-10-12  8:15 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox