From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3ACCA034F; Tue, 30 Mar 2021 03:39:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF3D1140EAB; Tue, 30 Mar 2021 03:39:11 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6B103406B4 for ; Tue, 30 Mar 2021 03:39:10 +0200 (CEST) IronPort-SDR: Fbdq1pyBeYY6PoCQlYFiZaQ54jbdbi9FsIjDizRHD1FtgoUpRkhOE6a64QXG9O35gobHqs8gDp byxkxMBvxlCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="253003965" X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="253003965" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 18:39:08 -0700 IronPort-SDR: ZQmwHWS9xt0dyF3gWtcPOggooC3YSOF/JAjkd5C2BDa334iVdckxDu5q0m7pgMS9ipVIAGIEMr gicsZDX0Osng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="411366983" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2021 18:39:08 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 29 Mar 2021 18:39:08 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 30 Mar 2021 09:39:06 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 30 Mar 2021 09:39:06 +0800 From: "Tu, Lijuan" To: "Huang, ZhiminX" , "dts@dpdk.org" CC: "Huang, ZhiminX" Thread-Topic: [dts] [PATCH V1 1/2] remove reload ice code Thread-Index: AQHXIf/Vu72qMQTZ8UqpD6Q6IC0ajaqbxdRg Date: Tue, 30 Mar 2021 01:39:06 +0000 Message-ID: References: <1616735292-74549-1-git-send-email-zhiminx.huang@intel.com> <1616735292-74549-2-git-send-email-zhiminx.huang@intel.com> In-Reply-To: <1616735292-74549-2-git-send-email-zhiminx.huang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1 1/2] remove reload ice code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of Zhimin Huang > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B26=1B$BF|=1B(B 13:08 > To: dts@dpdk.org > Cc: Huang, ZhiminX > Subject: [dts] [PATCH V1 1/2] remove reload ice code >=20 > *.cvl_dcf_acl_filter and cvl_limit_value_test remove reload ice code >=20 > Signed-off-by: Zhimin Huang > --- > tests/TestSuite_cvl_dcf_acl_filter.py | 16 ---------------- > tests/TestSuite_cvl_limit_value_test.py | 15 --------------- > 2 files changed, 31 deletions(-) >=20 > diff --git a/tests/TestSuite_cvl_dcf_acl_filter.py > b/tests/TestSuite_cvl_dcf_acl_filter.py > index 826da9c..1d516fc 100644 > --- a/tests/TestSuite_cvl_dcf_acl_filter.py > +++ b/tests/TestSuite_cvl_dcf_acl_filter.py > @@ -749,12 +749,6 @@ class CVLDCFACLFilterTest(TestCase): > self.testpmd_status =3D "close" > #bind pf to kernel > self.bind_nics_driver(self.dut_ports, driver=3D"ice") > - #move comms package to package folder > - self.suite_config =3D rfc.get_suite_config(self) > - comms_package_location =3D > self.suite_config["comms_package_file_location"] > - package_location =3D self.suite_config["package_file_location"] > - self.dut.send_expect("cp %s %s" % (comms_package_location, > package_location), "# ") > - self.re_load_ice_driver() this is part of set_up_all, so I thought the suite is designed for comms pa= ckage, but I saw you remove the replace, is that mean, the suite is also qu= alified to test other ddp packages, e.g. OS package. Could you please explain, why do the changes. Thanks. > #set vf driver > self.vf_driver =3D 'vfio-pci' > self.dut.send_expect("modprobe uio", "# ") @@ -784,16 +778,6 @@ = class > CVLDCFACLFilterTest(TestCase): > port.bind_driver(self.vf_driver) > time.sleep(15) >=20 > - def re_load_ice_driver(self): > - """ > - remove and reload the ice driver > - """ > - ice_driver_file_location =3D self.suite_config["ice_driver_file_= location"] > - self.dut.send_expect("rmmod ice", "# ", 60) > - self.dut.send_expect("insmod %s" % ice_driver_file_location, "# = ", 60) > - self.dut.send_expect("ifconfig %s up" % self.pf0_intf, "# ", 15) > - self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# "= , 15) > - > def set_up(self): > """ > Run before each test case. > diff --git a/tests/TestSuite_cvl_limit_value_test.py > b/tests/TestSuite_cvl_limit_value_test.py > index 77ce016..b806474 100644 > --- a/tests/TestSuite_cvl_limit_value_test.py > +++ b/tests/TestSuite_cvl_limit_value_test.py > @@ -189,15 +189,6 @@ class TestCvlLimitValue(TestCase): > self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0]) > self.dut.destroy_sriov_vfs_by_port(self.dut_ports[1]) >=20 > - def re_load_ice_driver(self): > - """ > - remove and reload the ice driver > - """ > - ice_driver_file_location =3D self.suite_config["ice_driver_file_= location"] > - self.dut.send_expect("rmmod ice", "# ", 15) > - self.dut.send_expect("insmod %s" % ice_driver_file_location, "# = ", 60) > - time.sleep(5) > - > def config_testpmd(self): > self.pmd_output.execute_cmd("set fwd rxonly") > self.pmd_output.execute_cmd("set verbose 1") @@ -813,12 +804,6 @= @ > class TestCvlLimitValue(TestCase): > def test_max_rule_number(self): > #bind pf to kernel > self.bind_nics_driver(self.dut_ports, driver=3D"ice") > - #move comms package to package folder > - self.suite_config =3D rfc.get_suite_config(self) > - comms_package_location =3D > self.suite_config["comms_package_file_location"] > - package_location =3D self.suite_config["package_file_location"] > - self.dut.send_expect("cp %s %s" % (comms_package_location, > package_location), "# ") > - self.re_load_ice_driver() > #set vf driver > self.vf_driver =3D 'vfio-pci' > self.dut.send_expect('modprobe vfio-pci', '#') > -- > 1.8.3.1