test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: yaobing <bingx.y.yao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/flags:case should unbind its own driver
Date: Tue, 25 Dec 2018 03:35:48 +0800	[thread overview]
Message-ID: <bb058fa7-363c-694f-abcd-67c976f92264@intel.com> (raw)
In-Reply-To: <1545648719-57312-1-git-send-email-bingx.y.yao@intel.com>

Applied, thanks


On 2018年12月24日 18:51, yaobing wrote:
> Different environments have their own drivers, and the default driver
> is igb_uio, which should add parameters to pass in its own driver
>
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>   tests/TestSuite_unit_tests_eal.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 74d0dfd..8299b51 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -261,13 +261,13 @@ class TestUnitTestsEal(TestCase):
>           Run eal flags autotest.
>           """
>   
> -        self.dut.unbind_interfaces_linux()
> +        self.dut.unbind_interfaces_linux(driver=self.drivername)
>           self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time)
>           # on FreeBSD need more time than other OS
>           out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
>           self.dut.send_expect("quit", "# ")
>           self.verify("Test OK" in out, "Test failed")
> -        self.dut.bind_interfaces_linux()
> +        self.dut.bind_interfaces_linux(driver=self.drivername)
>   
>       def test_alarm(self):
>           """

      reply	other threads:[~2018-12-24 11:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 10:51 yaobing
2018-12-24 19:35 ` Lijuan Tu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb058fa7-363c-694f-abcd-67c976f92264@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=bingx.y.yao@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).