test suite reviews and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dts@dpdk.org
Subject: [dts] [Bug 715] Remove iavf DPDK code modifications from DPDKdut.build_install_dpdk
Date: Thu, 20 May 2021 12:35:39 +0000	[thread overview]
Message-ID: <bug-715-433@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=715

            Bug ID: 715
           Summary: Remove iavf DPDK code modifications from
                    DPDKdut.build_install_dpdk
           Product: DTS
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: framework
          Assignee: dts@dpdk.org
          Reporter: juraj.linkes@pantheon.tech
  Target Milestone: ---

The code in question is this:
DPDKdut.build_install_dpdk:

        if nic_name in ['fortpark_TLV', 'fortpark_BASE-T']:
            self.send_expect("sed -i '/{ RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID,
IAVF_DEV_ID_ADAPTIVE_VF) },/i { RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID,
IAVF_DEV_ID_X722_VF) },' drivers/net/iavf/iavf_ethdev.c", "# ")
            self.send_expect("sed -i '/I40E_DEV_ID_X722_VF/d'
drivers/net/i40e/i40e_ethdev_vf.c", "# ")
        elif kernel_driver == 'i40e':
            self.send_expect("sed -i '/{ RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID,
IAVF_DEV_ID_ADAPTIVE_VF) },/a { RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID,
IAVF_DEV_ID_VF) },' drivers/net/iavf/iavf_ethdev.c", "# ")
            self.send_expect("sed -i -e '/I40E_DEV_ID_VF/s/0x154C/0x164C/g' 
drivers/net/i40e/base/i40e_devids.h", "# ")

I believe this enables iavf support for VFs with i40e PF driver. We need to
find a way to enable iavf for these devices without modifying DPDK code.

The first thing to do is to investigate whether that's possible with the
current DPDK implementation. If not, we need to agree with DPDK devs on a
proper solution. If that's the case, we'd only make the necessary DTS changes
after that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2021-05-20 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 12:35 bugzilla [this message]
2021-05-27  2:44 ` bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-715-433@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).