test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>,
	 "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add	create_eal_parameters function.
Date: Mon, 16 Mar 2020 03:36:23 +0000	[thread overview]
Message-ID: <c1f7085d43474a8185e22590450465a9@intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE93F0@SHSMSX101.ccr.corp.intel.com>

Hi Lijuan,

Now virtio case migrate to using new memory system, so whether add "socket-mem "or not will not influence memory usage since new memory system can allocate memory when needed, this plan just to align with test plan.

BR,
Yinan

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: 2020年3月3日 15:42
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> So please ask your "BB" to explain. thanks
> 
> > -----Original Message-----
> > From: Zhu, ShuaiX
> > Sent: Tuesday, March 3, 2020 1:51 PM
> > To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>
> > Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > create_eal_parameters function.
> >
> > This is the result given by BB, let delete this parameter.
> >
> > > -----Original Message-----
> > > From: Tu, Lijuan
> > > Sent: Tuesday, March 3, 2020 1:29 PM
> > > To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> > > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > > <shuaix.zhu@intel.com>
> > > Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > > create_eal_parameters function.
> > >
> > > Why remove it , can you add some explanation?
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > > > Sent: Wednesday, February 26, 2020 5:19 PM
> > > > To: dts@dpdk.org
> > > > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > > > <shuaix.zhu@intel.com>
> > > > Subject: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > > > create_eal_parameters function.
> > > >
> > > > Remove parameters:"--socket-mem 1024,1024"
> > > >
> > > > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > > > ---
> > > >  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> > > > b/tests/TestSuite_perf_virtio_user_pvp.py
> > > > index 2073426..12031c3 100644
> > > > --- a/tests/TestSuite_perf_virtio_user_pvp.py
> > > > +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> > > > @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
> > > >              eal_params =
> > > > self.dut.create_eal_parameters(cores=self.core_list_host,
> > > >                              ports=[0], prefix='vhost')
> > > >          command_line_client = self.target + "/app/testpmd %s " + \
> > > > -                        "--socket-mem 1024,1024 "  \
> > > >                          "--vdev
> 'net_vhost0,iface=vhost-net,queues=1' "
> > > + \
> > > >                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
> > > >          command_line_client = command_line_client % (eal_params,
> > > > len(self.core_list_host)-1,
> > > > --
> > > > 2.17.2


      reply	other threads:[~2020-03-16  3:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  9:18 zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
2020-02-27  9:54   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
2020-03-03  5:29 ` Tu, Lijuan
2020-03-03  5:50   ` Zhu, ShuaiX
2020-03-03  7:42     ` Tu, Lijuan
2020-03-16  3:36       ` Wang, Yinan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1f7085d43474a8185e22590450465a9@intel.com \
    --to=yinan.wang@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).