From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05988A0564; Fri, 28 Feb 2020 03:36:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C73C737AF; Fri, 28 Feb 2020 03:36:53 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3F90C2C4F for ; Fri, 28 Feb 2020 03:36:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 18:36:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="227394597" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 27 Feb 2020 18:36:50 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 18:36:47 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 28 Feb 2020 10:36:45 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Fri, 28 Feb 2020 10:36:45 +0800 From: "Xiao, QimaiX" To: "Tu, Lijuan" , "Zhao, HaiyangX" , "dts@dpdk.org" CC: "Zhao, HaiyangX" Thread-Topic: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Thread-Index: AQHV67pCgSLGAko5bEGAwZG3crSHBagv5d9A Date: Fri, 28 Feb 2020 02:36:45 +0000 Message-ID: References: <1582619670-406390-1-git-send-email-haiyangx.zhao@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BBCDFD2@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BBCDFD2@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, Lijuan I consulted lihong that single-file-segments parameter only required on vir= tio side in 2M env, vhost side doesn't need, so it's ok to remove it.=20 Regards, Xiao Qimai > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan > Sent: Tuesday, February 25, 2020 5:01 PM > To: Zhao, HaiyangX ; dts@dpdk.org > Cc: Zhao, HaiyangX > Subject: Re: [dts] [PATCH > V1]tests/TestSuite_virtio_user_for_container_networking: remove > redundant parameter single-file-segments if not 2M env >=20 > Remove single-file-segments, so what will happen, if 2M env ? >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao > > Sent: Tuesday, February 25, 2020 4:35 PM > > To: dts@dpdk.org > > Cc: Zhao, HaiyangX > > Subject: [dts] [PATCH > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > redundant parameter single-file-segments if not 2M env > > > > remove redundant parameter > > > > Signed-off-by: Haiyang Zhao > > --- > > tests/TestSuite_virtio_user_for_container_networking.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/TestSuite_virtio_user_for_container_networking.py > > b/tests/TestSuite_virtio_user_for_container_networking.py > > index ba303b7..1f9a666 100644 > > --- a/tests/TestSuite_virtio_user_for_container_networking.py > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase): > > command_line_user =3D 'docker run -i -t --privileged -v > > %s/vhost- net:/tmp/vhost-net ' + \ > > '-v /mnt/huge:/dev/hugepages ' + \ > > '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %= d ' + \ > > - '-m 1024 --no-pci --file-prefix=3Dcontaine= r --single-file- > > segments ' + \ > > + '-m 1024 --no-pci --file-prefix=3Dcontaine= r > > + ' + \ > > '-- > > vdev=3Dvirtio_user0,mac=3D00:11:22:33:44:10,path=3D/tmp/vhost- > net,queues=3D%d ' > > + \ > > '-- -i --rxq=3D%d --txq=3D%d --nb-cores=3D= %d' > > command_line_user =3D command_line_user % > > (self.container_base_dir, > > -- > > 1.8.3.1