From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2E44B2C54 for ; Tue, 11 Dec 2018 11:32:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 02:32:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,342,1539673200"; d="scan'208";a="128920480" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2018 02:32:07 -0800 To: lihong , dts@dpdk.org References: <1543973812-19241-1-git-send-email-lihongx.ma@intel.com> From: Lijuan Tu Message-ID: Date: Wed, 12 Dec 2018 02:59:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1543973812-19241-1-git-send-email-lihongx.ma@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V1] Use tcpdump_sniff_packets instead of sniff method X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 10:32:09 -0000 Applied, thanks On 2018年12月05日 09:36, lihong wrote: > About the test case test_vxlan_ipv6_checksum_offload,the sniff > method may not work well when add filter arguments, so use > tcpdump_sniff_packets instead of it. > > Signed-off-by: lihong > --- > tests/TestSuite_vxlan.py | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py > index d5a9d77..8de8384 100644 > --- a/tests/TestSuite_vxlan.py > +++ b/tests/TestSuite_vxlan.py > @@ -447,16 +447,14 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > config.create_pcap() > > # remove tempory files > + config.capture_file = "/tmp/sniff_%s.pcap" % self.recv_iface > self.tester.send_expect("rm -rf %s" % config.capture_file, "# ") > # save the capture packet into pcap format > self.tester.scapy_background() > - self.tester.scapy_append( > - 'p=sniff(iface="%s",filter="ether[12:2]!=0x88cc",count=1,timeout=5)' % self.recv_iface) > - self.tester.scapy_append( > - 'wrpcap(\"%s\", p)' % config.capture_file) > - self.tester.scapy_foreground() > > + inst = self.tester.tcpdump_sniff_packets(self.recv_iface, timeout=5) > config.send_pcap(self.tester_iface) > + self.tester.load_tcpdump_sniff_packets(inst) > time.sleep(5) > > # extract the checksum offload from saved pcap file