test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/cvl_dcf_switch_filter_gtpu: modify the execution order of sub cases
@ 2021-09-03  6:23 Jiale Song
  2021-09-29  3:34 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2021-09-03  6:23 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

Because creating rules of the same type will cause rule creation fail, 
adjusting the order of the sub cases can avoid this problem

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_cvl_dcf_switch_filter_gtpu.py | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_cvl_dcf_switch_filter_gtpu.py b/tests/TestSuite_cvl_dcf_switch_filter_gtpu.py
index 052e97b..830c996 100644
--- a/tests/TestSuite_cvl_dcf_switch_filter_gtpu.py
+++ b/tests/TestSuite_cvl_dcf_switch_filter_gtpu.py
@@ -691,15 +691,15 @@ sv_mac_ipv4_gtpu_eh_ipv4_udp_1 = [
     tv_mac_ipv4_gtpu_eh_ipv4_udp_teid_without_mask,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_qfi,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_l3dst,
-    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3src,
-    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3src_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_udp_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3dst_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3dst_l4src,
 ]
 
 sv_mac_ipv4_gtpu_eh_ipv4_udp_2 = [
-    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3dst_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3src,
+    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3src_l4dst,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_l3src_l4src,
-    tv_mac_ipv4_gtpu_eh_ipv4_udp_l3dst_l4src,
-    tv_mac_ipv4_gtpu_eh_ipv4_udp_l4dst,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_l4src,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_l4src_l4dst,
     tv_mac_ipv4_gtpu_eh_ipv4_udp_teid_l4src_l4dst,
@@ -711,6 +711,7 @@ sv_mac_ipv4_gtpu_eh_ipv4_udp_2 = [
     tv_mac_ipv4_gtpu_eh_ipv4_udp_all,
 ]
 
+
 sv_mac_ipv4_gtpu_eh_ipv4_udp = [sv_mac_ipv4_gtpu_eh_ipv4_udp_1, sv_mac_ipv4_gtpu_eh_ipv4_udp_2]
 
 sv_mac_ipv4_gtpu_eh_ipv6_udp_1 = [eval(str(sv).replace('tv_mac_ipv4_gtpu_eh_ipv4', 'tv_mac_ipv4_gtpu_eh_ipv6')
@@ -1062,15 +1063,15 @@ sv_mac_ipv4_gtpu_eh_ipv4_tcp_1 = [
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_teid_without_mask,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_qfi,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3dst,
-    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3src,
-    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3src_l4src,
+    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3dst_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3dst_l4src,
 ]
 
 sv_mac_ipv4_gtpu_eh_ipv4_tcp_2 = [
+    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3src,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3src_l4dst,
-    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3dst_l4src,
-    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3dst_l4dst,
-    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l4dst,
+    tv_mac_ipv4_gtpu_eh_ipv4_tcp_l3src_l4src,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_l4src,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_l4src_l4dst,
     tv_mac_ipv4_gtpu_eh_ipv4_tcp_teid_l4src_l4dst,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/cvl_dcf_switch_filter_gtpu: modify the execution order of sub cases
  2021-09-03  6:23 [dts] [PATCH V1] tests/cvl_dcf_switch_filter_gtpu: modify the execution order of sub cases Jiale Song
@ 2021-09-29  3:34 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-09-29  3:34 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年9月3日 14:24
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_dcf_switch_filter_gtpu: modify the execution
> order of sub cases
> 
> Because creating rules of the same type will cause rule creation fail, adjusting
> the order of the sub cases can avoid this problem
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-29  3:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03  6:23 [dts] [PATCH V1] tests/cvl_dcf_switch_filter_gtpu: modify the execution order of sub cases Jiale Song
2021-09-29  3:34 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).