test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error
  2020-09-27  2:39 [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error xizhan4x
@ 2020-09-27  2:39 ` Zhang, XiX
  2020-10-12  8:37 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, XiX @ 2020-09-27  2:39 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Tested-by: Zhang, XiX <xix.zhang@intel.com>


Regards,
Zhang, Xi
> -----Original Message-----
> From: Zhang, XiX
> Sent: Sunday, September 27, 2020 10:40 AM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts][PATCH V1] tests/TestSuite_cbdma:fixed-session-error


[-- Attachment #2: TestCBDMA.LOG --]
[-- Type: application/octet-stream, Size: 401689 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error
@ 2020-09-27  2:39 xizhan4x
  2020-09-27  2:39 ` Zhang, XiX
  2020-10-12  8:37 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: xizhan4x @ 2020-09-27  2:39 UTC (permalink / raw)
  To: dts; +Cc: xizhan4x

fixed:session error

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_cbdma.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_cbdma.py b/tests/TestSuite_cbdma.py
index 14611f0..9c5fc3a 100644
--- a/tests/TestSuite_cbdma.py
+++ b/tests/TestSuite_cbdma.py
@@ -71,6 +71,7 @@ class TestCBDMA(TestCase):
         self.table_header.append("Updating MAC")
         self.table_header.append("% linerate")
         self.result_table_create(self.table_header)
+        self.send_session = self.dut.new_session("new_session")
 
     def get_core_list(self):
         """
@@ -140,7 +141,6 @@ class TestCBDMA(TestCase):
         num is 2
         '''
         # flush other output
-        self.send_session=self.dut.new_session("new_session")
         target = self.app_path.split("/")
         self.send_session.send_expect(f"cd  {'/'.join(target[0:-1])} ", '# ')
         self.send_session.get_session_before(timeout=1)
@@ -310,7 +310,7 @@ class TestCBDMA(TestCase):
                                         ports=dev_info, prefix='cbdma')
             self.launch_ioatfwd_app(eal_params)
             self.send_and_verify_throughput(check_channel=True)
-            self.dut.send_expect('^c', '# ')
+            self.send_session.send_expect('^c', '# ')
         self.result_table_print()
 
     def test_perf_cbdma_with_diff_update_mac(self):
@@ -330,7 +330,7 @@ class TestCBDMA(TestCase):
         self.launch_ioatfwd_app(eal_params)
         self.send_and_verify_throughput(check_channel=False)
 
-        self.dut.send_expect('^c', '# ')
+        self.send_session.send_expect('^c', '# ')
         self.cbdma_updating_mac = 'disable'
         self.launch_ioatfwd_app(eal_params)
         self.send_and_verify_throughput(check_channel=False)
@@ -353,7 +353,7 @@ class TestCBDMA(TestCase):
         self.launch_ioatfwd_app(eal_params)
         self.send_and_verify_throughput(check_channel=False)
 
-        self.dut.send_expect('^c', '# ')
+        self.send_session.send_expect('^c', '# ')
         self.cbdma_copy_mode = 'sw'
         self.launch_ioatfwd_app(eal_params)
         self.send_and_verify_throughput(check_channel=False)
@@ -363,7 +363,7 @@ class TestCBDMA(TestCase):
         """
         Run after each test case.
         """
-        self.dut.send_expect('^c', '# ')
+        self.send_session.send_expect('^c', '# ')
         self.dut.kill_all()
 
     def tear_down_all(self):
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error
  2020-09-27  2:39 [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error xizhan4x
  2020-09-27  2:39 ` Zhang, XiX
@ 2020-10-12  8:37 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-10-12  8:37 UTC (permalink / raw)
  To: Zhang, XiX, dts; +Cc: Zhang, XiX

> fixed:session error
> 
> Signed-off-by: xizhan4x <xix.zhang@intel.com>
...
> +        self.send_session = self.dut.new_session("new_session")

Destroy your session when it finished his tasks, else it's running till dts quit.
It's bad to see resource waste.

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> Sent: 2020^[$BG/^[(B9^[$B7n^[(B27^[$BF|^[(B 10:40
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error
> 
> ---
>  tests/TestSuite_cbdma.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_cbdma.py b/tests/TestSuite_cbdma.py index
> 14611f0..9c5fc3a 100644
> --- a/tests/TestSuite_cbdma.py
> +++ b/tests/TestSuite_cbdma.py
> @@ -71,6 +71,7 @@ class TestCBDMA(TestCase):
>          self.table_header.append("Updating MAC")
>          self.table_header.append("% linerate")
>          self.result_table_create(self.table_header)
> +        self.send_session = self.dut.new_session("new_session")
> 
>      def get_core_list(self):
>          """
> @@ -140,7 +141,6 @@ class TestCBDMA(TestCase):
>          num is 2
>          '''
>          # flush other output
> -        self.send_session=self.dut.new_session("new_session")
>          target = self.app_path.split("/")
>          self.send_session.send_expect(f"cd  {'/'.join(target[0:-1])} ", '# ')
>          self.send_session.get_session_before(timeout=1)
> @@ -310,7 +310,7 @@ class TestCBDMA(TestCase):
>                                          ports=dev_info, prefix='cbdma')
>              self.launch_ioatfwd_app(eal_params)
>              self.send_and_verify_throughput(check_channel=True)
> -            self.dut.send_expect('^c', '# ')
> +            self.send_session.send_expect('^c', '# ')
>          self.result_table_print()
> 
>      def test_perf_cbdma_with_diff_update_mac(self):
> @@ -330,7 +330,7 @@ class TestCBDMA(TestCase):
>          self.launch_ioatfwd_app(eal_params)
>          self.send_and_verify_throughput(check_channel=False)
> 
> -        self.dut.send_expect('^c', '# ')
> +        self.send_session.send_expect('^c', '# ')
>          self.cbdma_updating_mac = 'disable'
>          self.launch_ioatfwd_app(eal_params)
>          self.send_and_verify_throughput(check_channel=False)
> @@ -353,7 +353,7 @@ class TestCBDMA(TestCase):
>          self.launch_ioatfwd_app(eal_params)
>          self.send_and_verify_throughput(check_channel=False)
> 
> -        self.dut.send_expect('^c', '# ')
> +        self.send_session.send_expect('^c', '# ')
>          self.cbdma_copy_mode = 'sw'
>          self.launch_ioatfwd_app(eal_params)
>          self.send_and_verify_throughput(check_channel=False)
> @@ -363,7 +363,7 @@ class TestCBDMA(TestCase):
>          """
>          Run after each test case.
>          """
> -        self.dut.send_expect('^c', '# ')
> +        self.send_session.send_expect('^c', '# ')
>          self.dut.kill_all()
> 
>      def tear_down_all(self):
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-27  2:39 [dts] [PATCH V1] tests/TestSuite_cbdma:fixed-session-error xizhan4x
2020-09-27  2:39 ` Zhang, XiX
2020-10-12  8:37 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox