Re: [dts] [PATCH V1] test_plans/generic_flow_api: add two test cases

["Tu, Lijuan" <lijuan.tu@intel.com>]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lingli Chen
> Sent: 2021年7月30日 22:10
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts] [PATCH V1] test_plans/generic_flow_api: add two test cases
> 
> add new Test case: i40e create same rule after destroy/ i40e create different
> rule after destroy.
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
>  test_plans/generic_flow_api_test_plan.rst | 48 +++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/test_plans/generic_flow_api_test_plan.rst
> b/test_plans/generic_flow_api_test_plan.rst
> index 71f16187..2c87da44 100644
> --- a/test_plans/generic_flow_api_test_plan.rst
> +++ b/test_plans/generic_flow_api_test_plan.rst
> @@ -1996,3 +1996,51 @@ Test case: Dual vlan(QinQ)
> 
>     3). send packet as step 2 with changed ivlan id, got hash value and queue
> value that output from the testpmd on DUT, the value should be
>     different with the values in step 2 & step 1) & step 2).
> +
> +Test case: Fortville create same rule after destroy
> +===================================================
> +
> +1. Launch the app ``testpmd`` with the following arguments::
> +
> +        ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2,3,4,5,6,7,8 -n 4 -- -i
> --disable-rss --rxq=16 --txq=16
> +        testpmd> set fwd rxonly
> +        testpmd> set verbose 1
> +        testpmd> start
> +
> +2. verify rules can be create after destroy::
> +
> +        testpmd>flow create 0 ingress pattern eth / ipv4 / udp src is 32 / end
> actions queue index 2 / end
> +        testpmd>flow destroy 0 rule 0
> +        testpmd>flow create 0 ingress pattern eth / ipv4 / udp src is
> + 32 / end actions queue index 2 / end

How to verify it?

> +
> +3. send packets match rule::
> +
> +    pkt1 = Ether()/IP()/UDP(sport=32)/Raw('x' * 20)
> +
> +4. send packets not match rule::
> +
> +    pkt2 = Ether()/IP()/UDP(dport=32)/Raw('x' * 20)
> +

What's the purpose of 3 and 4?  I don't see any verification.

Same comments for next test case.

> +Test case: Fortville create different rule after destroy
> +=======================================================
> +
> +1. Launch the app ``testpmd`` with the following arguments::
> +
> +        ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2,3,4,5,6,7,8 -n 4 -- -i
> --disable-rss --rxq=16 --txq=16
> +        testpmd> set fwd rxonly
> +        testpmd> set verbose 1
> +        testpmd> start
> +
> +2. verify rules can be create after destroy::
> +
> +        testpmd>flow create 0 ingress pattern eth / ipv4 / udp src is 32 / end
> actions queue index 2 / end
> +        testpmd>flow destroy 0 rule 0
> +        testpmd>flow create 0 ingress pattern eth / ipv4 / udp dst is
> + 32 / end actions queue index 2 / end
> +
> +3. send packets match rule::
> +
> +    pkt1 = Ether()/IP()/UDP(dport=32)/Raw('x' * 20)
> +
> +4. send packets not match rule::
> +
> +    pkt2 = Ether()/IP()/UDP(sport=32)/Raw('x' * 20)
> --
> 2.32.0