test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dts] [PATCH 4/4] tests/TestSuite_vm_pw_mgmt_policy: change core_mask
Date: Thu, 8 Apr 2021 08:55:25 +0000	[thread overview]
Message-ID: <df94f934f34c4fc2ad445f13cc4871c8@intel.com> (raw)
In-Reply-To: <20210407081807.29110-4-reshma.pattan@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Reshma Pattan
> Sent: 2021年4月7日 16:18
> To: dts@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>
> Subject: [dts] [PATCH 4/4] tests/TestSuite_vm_pw_mgmt_policy: change
> core_mask
> 
> Change the vm_power_manager core mask and guest_vm_power_manager
> core mask.
> 
> Now with dpdk 20.11 the cores used for guest_cli should be enabled in
> vm_power_manager core mask.
> Otherwise vm_power_manager will not grant the access to fetch the
> information for those cores missing in the coremask.
> 
> Relevant DPDK patch
> https://patchwork.dpdk.org/project/dpdk/patch/20210115125250.22416-1-
> david.hunt@intel.com/
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  test_plans/vm_pw_mgmt_policy_test_plan.rst | 4 ++--
>  tests/TestSuite_vm_pw_mgmt_policy.py       | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test_plans/vm_pw_mgmt_policy_test_plan.rst
> b/test_plans/vm_pw_mgmt_policy_test_plan.rst
> index cfbfe962..98894ff5 100644
> --- a/test_plans/vm_pw_mgmt_policy_test_plan.rst
> +++ b/test_plans/vm_pw_mgmt_policy_test_plan.rst
> @@ -172,7 +172,7 @@ Set up testing environment
>      export RTE_TARGET=x86_64-native-linuxapp-gcc
>      make -C examples/vm_power_manager
> 
> -   ./examples/vm_power_manager/build/vm_power_mgr -c 0x7 -n 4
> +   ./examples/vm_power_manager/build/vm_power_mgr -c 0xffff -n 4
> 
>      vmpower> add_vm <vm_name>
>      vmpower> add_channels <vm_name> all @@ -195,7 +195,7 @@ Set up
> testing environment
>      make -C examples/vm_power_manager/guest_cli
> 
>     ./examples/vm_power_manager/guest_cli/build/guest_vm_power_mgr \
> -   -c 0x1f -n 4 --file-prefix=vmpower2 -- -i --vm-name=<vm name> \
> +   -c 0xff -n 4 --file-prefix=vmpower2 -- -i --vm-name=<vm name> \
>     --policy=<policy name> --vcpu-list=<vcpus list> --busy-hours=<time stage>
> 
>      options description::
> diff --git a/tests/TestSuite_vm_pw_mgmt_policy.py
> b/tests/TestSuite_vm_pw_mgmt_policy.py
> index 9abcafd2..ac746180 100644
> --- a/tests/TestSuite_vm_pw_mgmt_policy.py
> +++ b/tests/TestSuite_vm_pw_mgmt_policy.py
> @@ -348,7 +348,7 @@ class TestVmPwMgmtPolicy(TestCase):
>              '-v '
>              '-c {core_mask} '
>              '-n {mem_channel} ').format(**{
> -                'core_mask': self.get_cores_mask("1S/3C/1T"),
> +                'core_mask': '0xffff',

Some server may not have so many cores, prefer to get_cores_mask("all") if need many cores.

>                  'mem_channel': self.dut.get_memory_channels(), })
>          prompt = 'vmpower>'
>          cmd = [' '.join([self.vm_power_mgr, eal_option]), prompt, 30]
> --
> 2.17.1


  reply	other threads:[~2021-04-08  8:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  8:18 [dts] [PATCH 1/4] conf/power_pstate: change core Reshma Pattan
2021-04-07  8:18 ` [dts] [PATCH 2/4] tests/power_bidirection_channel: change core masks Reshma Pattan
2021-04-07  8:18 ` [dts] [PATCH 3/4] tests/power_pbf: change core mask Reshma Pattan
2021-04-07  8:18 ` [dts] [PATCH 4/4] tests/TestSuite_vm_pw_mgmt_policy: change core_mask Reshma Pattan
2021-04-08  8:55   ` Tu, Lijuan [this message]
2021-04-08  9:14     ` Pattan, Reshma
2021-04-12  5:16       ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df94f934f34c4fc2ad445f13cc4871c8@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).