test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH] test_plans/af_xdp_test_plan: remove tests with pmd_zero_copy arg
@ 2022-02-25  9:16 Ciara Loftus
  2022-04-06 11:57 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Ciara Loftus @ 2022-02-25  9:16 UTC (permalink / raw)
  To: dts; +Cc: Ciara Loftus

The 'pmd_zero_copy' vdev arg for the AF_XDP PMD was removed in DPDK
v19.11. Remove it from the AF_XDP test plan as it is no longer relevant.
Zero copy is now automatically used if the kernel headers contain the
XDP_UMEM_UNALIGNED_CHUNK_FLAG flag.

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 test_plans/af_xdp_test_plan.rst | 67 ++-------------------------------
 1 file changed, 3 insertions(+), 64 deletions(-)

diff --git a/test_plans/af_xdp_test_plan.rst b/test_plans/af_xdp_test_plan.rst
index b7feea11..a05de37b 100644
--- a/test_plans/af_xdp_test_plan.rst
+++ b/test_plans/af_xdp_test_plan.rst
@@ -117,23 +117,7 @@ Test case 2: two ports
 4. Send packets by packet generator port0 and port1 with different packet size,
    from 64 bytes to 1518 bytes, check the throughput at port0 and port1.
 
-Test case 3: zero copy
-======================
-
-1. Start the testpmd::
-
-    ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 29,30 -n 6 --no-pci \
-    --vdev net_af_xdp0,iface=enp216s0f0,pmd_zero_copy=1 \
-    -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
-
-2. Assign the kernel core::
-
-    ./set_irq_affinity 34 enp216s0f0
-
-3. Send packets by packet generator with different packet size,
-   from 64 bytes to 1518 bytes, check the throughput.
-
-Test case 4: multiqueue
+Test case 3: multiqueue
 =======================
 
 1. One queue.
@@ -171,52 +155,7 @@ Test case 4: multiqueue
       with different packet size from 64 bytes to 1518 bytes, check the throughput.
       The packets were distributed to the four queues.
 
-Test case 5: multiqueue and zero copy
-=====================================
-
-1. One queue and zero copy.
-
-  1) Set hardware queue::
-
-      ethtool -L enp216s0f0 combined 1
-
-  2) Start the testpmd with one queue::
-
-      ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 29,30 -n 6 --no-pci \
-      --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=1,pmd_zero_copy=1 \
-      -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
-
-  3) Assign the kernel core::
-
-      ./set_irq_affinity 34 enp216s0f0
-
-  4) Send packets with different dst IP address by packet generator
-     with different packet size from 64 bytes to 1518 bytes, check the throughput.
-     Expect the performance is better than non-zero-copy.
-
-2. Four queues and zero copy.
-
-  1) Set hardware queue::
-
-      ethtool -L enp216s0f0 combined 4
-
-  2) Start the testpmd with four queues::
-
-      ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 29,30-33 -n 6 --no-pci \
-      --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=4,pmd_zero_copy=1 \
-      -- -i --nb-cores=4 --rxq=4 --txq=4 --port-topology=loop
-
-  3) Assign the kernel core::
-
-      ./set_irq_affinity 34-37 enp216s0f0
-
-  4) Send packets with different dst IP address by packet generator
-     with different packet size from 64 bytes to 1518 bytes, check the throughput.
-     The packets were distributed to the four queues.
-     Expect the performance of four queues is better than one queue.
-     Expect the performance is better than non-zero-copy.
-
-Test case 6: need_wakeup
+Test case 4: need_wakeup
 ========================
 
 1. Set hardware queue::
@@ -236,7 +175,7 @@ Test case 6: need_wakeup
    to 1518 bytes, check the throughput.
    Expect the performance is better than no need_wakeup.
 
-Test case 7: xdpsock sample performance
+Test case 5: xdpsock sample performance
 =======================================
 
 1. One queue.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] test_plans/af_xdp_test_plan: remove tests with pmd_zero_copy arg
  2022-02-25  9:16 [PATCH] test_plans/af_xdp_test_plan: remove tests with pmd_zero_copy arg Ciara Loftus
@ 2022-04-06 11:57 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2022-04-06 11:57 UTC (permalink / raw)
  To: Loftus, Ciara, dts; +Cc: Loftus, Ciara

> -----Original Message-----
> From: Ciara Loftus <ciara.loftus@intel.com>
> Sent: 2022年2月25日 17:17
> To: dts@dpdk.org
> Cc: Loftus, Ciara <ciara.loftus@intel.com>
> Subject: [PATCH] test_plans/af_xdp_test_plan: remove tests with
> pmd_zero_copy arg
> 
> The 'pmd_zero_copy' vdev arg for the AF_XDP PMD was removed in DPDK
> v19.11. Remove it from the AF_XDP test plan as it is no longer relevant.
> Zero copy is now automatically used if the kernel headers contain the
> XDP_UMEM_UNALIGNED_CHUNK_FLAG flag.
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-06 11:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25  9:16 [PATCH] test_plans/af_xdp_test_plan: remove tests with pmd_zero_copy arg Ciara Loftus
2022-04-06 11:57 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git