test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver
@ 2020-11-03  8:44 Xie wei
  2020-11-03  8:44 ` [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2020-11-03  8:44 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

Update i40e driver to 2.13.10,
vf_vlan_rx: while vlan set filter on, the pkts with random vlan id 1-4095 shall not be received.
add_pvid_vf: while ip link set pf_intf vf 0 vlan 0, the pkts with random vlan id 1-4095 shall not be received.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_vlan.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index a5754117..327c1466 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -273,7 +273,7 @@ class TestVfVlan(TestCase):
         self.vm0_testpmd.execute_cmd("start")
 
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e" or self.kdriver == 'ice':
+        if self.kdriver == 'ice':
             self.verify("received" in out, "Failed to received vlan packet!!!")
         else:
             self.verify(
@@ -395,7 +395,7 @@ class TestVfVlan(TestCase):
 
         # send packet with vlan
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e" or self.kdriver == 'ice':
+        if self.kdriver == 'ice':
             self.verify(
                 "received 1 packets" in out, "Received mismatched vlan packet while vlan filter on")
         else:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify script to fit new I40E driver
  2020-11-03  8:44 [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver Xie wei
@ 2020-11-03  8:44 ` " Xie wei
  2020-11-03  9:03   ` Xie, WeiX
  2020-11-03  9:02 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
  2020-11-11  2:45 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xie wei @ 2020-11-03  8:44 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

Update i40e driver to 2.13.10,
vf_add_pvid: remove vlan, the pkts with random vlan id 1-4095 shall not be received.
vf_vlan_rx: remove vlan, the pkts with vlan 1 shall not be received.
vf_vlan_strip: disable strip, the pkts with random vlan tag shall not be received.
vf_vlan_filter: disable filter, the pkts with random vlan tag shall not be received.
vf_vlan_promisc: disable filter and strip, the pkts with random vlan tag shall not be received. 

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index da925109..adeac42f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -428,8 +428,12 @@ class TestKernelpfIavf(TestCase):
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, "fail to tester received vlan packet!!!")
-        self.verify(self.vf_mac in out, "Failed to received vlan packet!!!")
+        if self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, "fail to tester received vlan packet!!!")
+            self.verify(self.vf_mac in out, "Failed to received vlan packet!!!")
+        else:
+            self.verify(len(receive_pkt) == 1, "fail to tester received vlan packet!!!")
+            self.verify(self.vf_mac not in out, "Received vlan packet!!!")
 
     def send_and_getout(self, vlan=0, pkt_type="UDP"):
 
@@ -493,7 +497,10 @@ class TestKernelpfIavf(TestCase):
 
         # send vlan 1 packet, vf can receive packet
         out = self.send_and_getout(vlan=1, pkt_type="VLAN_UDP")
-        self.verify(self.vf_mac in out, "received vlan 1 packet!!!")
+        if self.kdriver == 'ice':
+            self.verify(self.vf_mac in out, "Not received vlan 1 packet!!!")
+        else:
+            self.verify(self.vf_mac not in out, "Received vlan 1 packet!!!")
 
     def test_vf_vlan_insertion(self):
         self.vm_testpmd.start_testpmd("all")
@@ -538,7 +545,10 @@ class TestKernelpfIavf(TestCase):
         self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
+        if self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, 'Failed to not received vlan packet!!!')
+        else:
+            self.verify(len(receive_pkt) == 1, 'Failed to not received vlan packet!!!')
 
     def test_vf_vlan_filter(self):
         random_vlan = random.randint(2, MAX_VLAN)
@@ -572,7 +582,10 @@ class TestKernelpfIavf(TestCase):
         time.sleep(1)
         tcpdump_out = self.get_tcpdump_package()
         receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
-        self.verify(len(receive_pkt) == 2, 'Failed to received vlan packet!!!')
+        if self.kdriver == 'ice':
+            self.verify(len(receive_pkt) == 2, 'Failed to received vlan packet!!!')
+        else:
+            self.verify(len(receive_pkt) == 1, 'Failed to received vlan packet!!!')
 
     def test_vf_without_jumboframe(self):
         self.tester.send_expect('ifconfig %s mtu %s' % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), '#')
@@ -923,7 +936,10 @@ class TestKernelpfIavf(TestCase):
         self.scapy_send_packet(self.vf_mac, self.tester_intf, vlan_flags=True, count=10)
         out = self.vm_dut.get_session_output()
         packets = len(re.findall('received 1 packets', out))
-        self.verify(packets == 10, "Not receive expected packet")
+        if self.kdriver == 'ice':
+            self.verify(packets == 10, "Not receive expected packet")
+        else:
+            self.verify(packets == 0, "Receive expected packet")
 
         # send 10 untagged packets, and check 10 untagged packets received
         self.scapy_send_packet(self.vf_mac, self.tester_intf, count=10)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver
  2020-11-03  8:44 [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver Xie wei
  2020-11-03  8:44 ` [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
@ 2020-11-03  9:02 ` " Xie, WeiX
  2020-11-11  2:45 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-11-03  9:02 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei

> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, November 3, 2020 4:45 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new
> I40E driver


[-- Attachment #2: TestVfVlan.log --]
[-- Type: application/octet-stream, Size: 151225 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify script to fit new I40E driver
  2020-11-03  8:44 ` [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
@ 2020-11-03  9:03   ` Xie, WeiX
  0 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-11-03  9:03 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, November 3, 2020 4:45 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify script to
> fit new I40E driver

[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 3495350 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver
  2020-11-03  8:44 [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver Xie wei
  2020-11-03  8:44 ` [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
  2020-11-03  9:02 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
@ 2020-11-11  2:45 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-11-11  2:45 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> Update i40e driver to 2.13.10,
> vf_vlan_rx: while vlan set filter on, the pkts with random vlan id 1-4095 shall not
> be received.
> add_pvid_vf: while ip link set pf_intf vf 0 vlan 0, the pkts with random vlan id 1-
> 4095 shall not be received.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Snice VF behavior is based on PF driver, so get driver version first, then check VF behavior.
As far as I understand, if i40e driver is lower than 2.13.10, the result will be failed, even if it is an expected behavior.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03  8:44 [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify script to fit new I40E driver Xie wei
2020-11-03  8:44 ` [dts] [PATCH V2 2/2] tests/TestSuite_kernelpf_iavf:modify " Xie wei
2020-11-03  9:03   ` Xie, WeiX
2020-11-03  9:02 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_vlan:modify " Xie, WeiX
2020-11-11  2:45 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox