From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CD70A0503; Wed, 18 May 2022 16:35:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51A7F40156; Wed, 18 May 2022 16:35:53 +0200 (CEST) Received: from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id D239C400D6 for ; Wed, 18 May 2022 16:35:51 +0200 (CEST) Received: from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw02.pantheon.sk (Proxmox) with ESMTP id 10CC1182DA3; Wed, 18 May 2022 16:35:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=NebxRXZYoLHrtrLGEDdK kFeenHD2ZXPBXWaO82LGpcI=; b=irg7wR9/hlwSW5/ooRKBvLuRKTqpVTLzQlvr Yj0Ve1J774hxX7RCHiGKEd5tU62vAhLjdhRH5rmj3I/haQjCrJpqMCRUBeVW6RnB r1zPdMq0MQzn/pS8TRFpy4QWSDN8ppq9xWZjzSA9QiHMH9wb6XarUUeS9XD3/KfJ ymZF2yZ59kXz9Gi208KAG09a/iPPsIqx9Ev3KFtUF7YxJPrySgtv/UElHkGJYwmo GNMwkbxMD2xbAv+IG54wzBT2XW/Tahynjqh/UXmswmTOYrQdfiqXxl8XM7NRpbGw LO4NEE5K6EDL355/Pco0PAdwKLLBaeTyX7uNuyoGhlyi/eWidQ== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Honnappa Nagarahalli , "thomas@monjalon.net" , "lijuan.tu@intel.com" , "ohilyard@iol.unh.edu" CC: "dts@dpdk.org" , David Marchand , nd , "bruce.richardson@intel.com" Subject: RE: [PATCH v1] cleanup: rename base classes Thread-Topic: [PATCH v1] cleanup: rename base classes Thread-Index: AQHYaSmcWap+KwXNmUSlrGWbyOOn/60iYEmAgAAgLYCAAQ/mgIABHvXA Date: Wed, 18 May 2022 14:35:47 +0000 Message-ID: References: <20220516133340.1056427-1-juraj.linkes@pantheon.tech> <16365457.Ash8RoxBsO@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, May 18, 2022 1:02 AM > To: thomas@monjalon.net; Juraj Linke=B9 ; > lijuan.tu@intel.com; ohilyard@iol.unh.edu > Cc: dts@dpdk.org; David Marchand ; nd > ; bruce.richardson@intel.com > Subject: RE: [PATCH v1] cleanup: rename base classes >=20 > > > > > > > The current naming of the base elements DTS works with is a bit > > > > confusing, which this patch attemps to ameliorate. The basic > > > > elements could be divided into and described in short as follows: > > > > * A node: a broad term encompassing a host where any of the DTS > > > > elements are present. This could be a physical or virtualized > > > > server or a container. > > > > OK > > > > > > * The control node: the host where DTS runs > > > > OK > > > > > > * An SUT (system under test) node: This is where DPDK along with > > > > the tested hardware resides. The system comprises DPDK and the > hardware. > > > > Is there any difference between a SUT and a "tested node"? > > As defined above, the system under test is DPDK with the hardware we're int= erested in testing (usually the devices DPDK works with). I'm not sure what= the definition of a "tested node" is, but what would make senes to me is t= hat the tested node would be the node where the SUT is located (the same as= an SUT node). This definition rests on what a system is and do we apply that to our conte= xt, for example: a regularly interacting or interdependent group of items forming a unified = whole [0] I went with DPDK + the hardware it's using as the unified whole as those ar= e the parts we're interested in, but the unified whole could reasonably mea= n more than just DPDK + it's hardware (or, from another point of view, the = hardware we're testing utilizing DPDK). [0] https://www.merriam-webster.com/dictionary/system > > > > * A traffic generator node: The node where the traffic generator > > > > is present, such as Trex, Scapy or a hardware traffic generator (e.= g. > > > > IXIA) > > > > OK > > > > > > All references to DUT were removed. This is because it was used to > > > > mean both the server where DPDK/NIC are present and the DUT > > > > (device under test, i.e. the NIC) in different contexts. Where > > > > applicable, DUT was replaced with NIC and the rest were replaced > > > > with SUT. With this change, it's clear what's meant and the > > > > abbreviations are very different, which removes that layer of confu= sion. > > > > "NIC" does not mean it is a device under test. > > Also we could have other kind of devices under test, like crypto cards. > May be for other cards, we could use "XxxAccelerator"? We could leave "NI= C" as > is. >=20 NIC is not necessarily a device under test, but a device under test could b= e a NIC in the proper context (such as when the tested device is a NIC, whi= ch is where the references to NICs). Currently, when DTS docs or code mentions a NIC, it's always a NIC that's b= eing tested (and no other device type). In DTS, when DUT refers to a device= , it's always a NIC (meaning that when DTS refers to a NIC, it uses either = NIC or DUT which this change unifies to just NIC). There are references to = other devices, such as QAT, but DUT is never used to refer to non-NIC devic= es. We could use DUT to mean any type of device (NIC, QAT, other accelerators) = being tested, it's just that's not how it's used anywhere in DTS. So the policy that this change brings is basically to refer to device types= (NIC, QAT, etc.) instead of a broad category (DUT). Let us know whether th= is makes sense. > > > > > > Rename the following classes: > > > > Crb -> Node > > > > Dut -> SutNode > > > > Tester -> TrafficGeneratorNode > > > > DPDKdut -> DpdkSut > > > > DPDKtester -> DpdkTrafficGenerator VirtDut -> VirtSut CrbsConf -> > > > > TopologyConf PktgenConf -> PacketGeneratorConf > > > > I think you need to choose between "TrafficGenerator" and > > "PacketGenerator". > +1 for a single term >=20 Agreed. We talked this over and we're going with TrafficGenerator. > > >=20