test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V2] test_plans/dual_vlan: optimize the test steps in the test plan
@ 2022-12-29  6:02 Weiyuan Li
  2023-01-04  1:13 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Weiyuan Li @ 2022-12-29  6:02 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

modify the test plan need to set port stop first when set the tx_vlan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-fix typos.

 test_plans/dual_vlan_test_plan.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index fd953cd9..11dfa332 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -242,7 +242,9 @@ Enable vlan packet forwarding on port ``0`` first::
 
 Insert VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan set 1 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port
@@ -250,7 +252,9 @@ and send 1 packet on port ``A``. Verify that the packet can been received on por
 
 Delete the VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan reset 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts][PATCH V2] test_plans/dual_vlan: optimize the test steps in the test plan
  2022-12-29  6:02 [dts][PATCH V2] test_plans/dual_vlan: optimize the test steps in the test plan Weiyuan Li
@ 2023-01-04  1:13 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-01-04  1:13 UTC (permalink / raw)
  To: dts, Weiyuan Li; +Cc: Weiyuan Li

On Thu, 29 Dec 2022 14:02:32 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> modify the test plan need to set port stop first when set the tx_vlan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-04  1:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29  6:02 [dts][PATCH V2] test_plans/dual_vlan: optimize the test steps in the test plan Weiyuan Li
2023-01-04  1:13 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).