From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB2AEA0C4E; Mon, 8 Nov 2021 16:31:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7492C41154; Mon, 8 Nov 2021 16:31:49 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8F86B40E28 for ; Mon, 8 Nov 2021 16:31:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10161"; a="212975522" X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="212975522" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 07:31:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="499899140" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 08 Nov 2021 07:31:46 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 07:31:45 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 23:31:43 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Mon, 8 Nov 2021 23:31:43 +0800 From: "Tu, Lijuan" To: "Jiale, SongX" , "dts@dpdk.org" CC: "Jiale, SongX" Thread-Topic: [dts] [PATCH V2] tests/iavf_fdir: optimization script Thread-Index: AQHX1F7/ErcZ/dzY+kCftZNtjqUFy6v5v9Fg Date: Mon, 8 Nov 2021 15:31:43 +0000 Message-ID: References: <1636348216-211815-1-git-send-email-songx.jiale@intel.com> In-Reply-To: <1636348216-211815-1-git-send-email-songx.jiale@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/iavf_fdir: optimization script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of Jiale Song > Sent: 2021=1B$BG/=1B(B11=1B$B7n=1B(B8=1B$BF|=1B(B 13:10 > To: dts@dpdk.org > Cc: Jiale, SongX > Subject: [dts] [PATCH V2] tests/iavf_fdir: optimization script >=20 > initialize pf. because pf is not initialized after case test, other case = tests fail >=20 > Signed-off-by: Jiale Song > --- > tests/TestSuite_iavf_fdir.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) mode change 100755 =3D> = 100644 > tests/TestSuite_iavf_fdir.py >=20 > diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py = old mode > 100755 new mode 100644 index fab7cc27..6abb75c5 > --- a/tests/TestSuite_iavf_fdir.py > +++ b/tests/TestSuite_iavf_fdir.py > @@ -7593,6 +7593,7 @@ class TestIAVFFdir(TestCase): > """ > Run before each test case. > """ > + self.dut.restore_interfaces_linux() > self.setup_2pf_4vf_env() > time.sleep(1) > self.launch_testpmd() > @@ -8344,7 +8345,6 @@ class TestIAVFFdir(TestCase): > create same rules on pf and vf, no conflict > """ > self.dut.kill_all() > - self.setup_2pf_4vf_env() Why still call kill_all here ? > self.session_secondary =3D self.dut.new_session() > self.session_third =3D self.dut.new_session() >=20 > @@ -8496,7 +8496,6 @@ class TestIAVFFdir(TestCase): > create same input set but different action rules on pf and vf, n= o conflict. > """ > self.dut.kill_all() > - self.setup_2pf_4vf_env() > self.session_secondary =3D self.dut.new_session() > self.session_third =3D self.dut.new_session() >=20 > @@ -9810,7 +9809,6 @@ class TestIAVFFdir(TestCase): >=20 > def tear_down(self): > # destroy all flow rule on port 0 > - self.dut.kill_all() > self.destroy_env() > if getattr(self, 'session_secondary', None): > self.dut.close_session(self.session_secondary) > -- > 2.17.1