test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhou, JunX W" <junx.w.zhou@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhou, JunX W" <junx.w.zhou@intel.com>
Subject: Re: [dts] [PATCH V1] tests/telemetry: adapt meson build
Date: Thu, 25 Mar 2021 05:55:26 +0000	[thread overview]
Message-ID: <f4e6dd776a56435d8572957bdd616d47@intel.com> (raw)
In-Reply-To: <1616479476-9464-1-git-send-email-junx.w.zhou@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhou Jun
> Sent: 2021年3月23日 14:05
> To: dts@dpdk.org
> Cc: Zhou, JunX W <junx.w.zhou@intel.com>
> Subject: [dts] [PATCH V1] tests/telemetry: adapt meson build
> 
> adapt meson build, need modify compile parameter and recompile  for test
> 
> Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py index
> 7e474bc..8de8fb6 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -49,6 +49,7 @@ class TestTelemetry(TestCase):
> 
> "'s/CONFIG_RTE_LIBRTE_TELEMETRY=n/CONFIG_RTE_LIBRTE_TELEMETRY=y/g
> '"
>              " {}/config/common_base").format(self.target_dir)
>          self.d_a_console(cmd)
> +        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'y'})

Duplicated with your old method, please remove it, thanks

> 
>      def create_query_script(self):
>          '''
> @@ -588,7 +589,8 @@ class TestTelemetry(TestCase):
>          """
>          Run after each test suite.
>          """
> -        pass
> +        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'n'})
> +        self.dut.build_install_dpdk(self.target)
> 
>      def test_basic_connection(self):
>          '''
> --
> 1.8.3.1


      parent reply	other threads:[~2021-03-25  5:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  6:04 Zhou Jun
2021-03-23  6:11 ` Zhou, JunX W
2021-03-23  9:53   ` Zhao, HaiyangX
2021-03-25  5:55 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e6dd776a56435d8572957bdd616d47@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=junx.w.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).