From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F3574256E; Mon, 11 Sep 2023 13:49:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A02F402D6; Mon, 11 Sep 2023 13:49:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D3A4A41133 for ; Tue, 5 Sep 2023 18:00:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693929638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AqlIC6Fox967Q/QJTTuTQzIGJf18RKMuiop5y5IY/3A=; b=GX7mFI0sFVjKVVpr/7c9R0cdHnQbHOaoBJ7BDTvrk5HBajBwa+YyS6Ymw4Li3FqCovwHQj T3PXY04hWtzwbJzyWtxNq76ZaqYGMpgwc9OGY+IWu5poYZj3ABOn4Xcq9ozOnjQK3oM9Fw lKgPoO/VqM1MACH/JqYEc5D8A1aT/tI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-bbBtX4WbMP6xONR11vRDDA-1; Tue, 05 Sep 2023 12:00:35 -0400 X-MC-Unique: bbBtX4WbMP6xONR11vRDDA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 22BFC3C0F677; Tue, 5 Sep 2023 16:00:34 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.32.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878591121314; Tue, 5 Sep 2023 16:00:33 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Patrick Robb , Morten =?utf-8?Q?Br=C3=B8rup?= , Adam Hassick , thomas@monjalon.net, ci@dpdk.org, dts@dpdk.org Subject: Re: Skip tests on Depends-on tag References: <98CBD80474FA8B44BF855DF32C47DC35D87B6D@smartserver.smartshare.dk> Date: Tue, 05 Sep 2023 12:00:33 -0400 In-Reply-To: (David Marchand's message of "Tue, 5 Sep 2023 09:10:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 11 Sep 2023 13:49:49 +0200 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org David Marchand writes: > Hello Patrick, Morten, > > On Tue, Sep 5, 2023 at 3:22=E2=80=AFAM Patrick Robb w= rote: >> >> Thanks for the suggestion. I'm also thinking the community lab should mo= ve to an apply-patchset process like: >> -if commit message contains "depends-on", then: >> -get depends-on series id >> -get referenced patch series and attempt to apply, and if succes= sful then attempt to apply original patch on that. >> -run testing >> >> I see that the github-robot reported a PASS, so they might already be do= ing this. I'll raise it during the next CI meeting and see what the ci grou= p thinks or if they've discussed this before. Maybe there are some issues w= ith this which I'm not thinking of, but we'll see what the group thinks. > > My two cents (and copying Aaron): the ovsrobot (for dpdk) handles some > part of the Depends-on: series-XXX logic, indeed. > https://github.com/ovsrobot/pw-ci/commit/f2a73a46464424e977d4f8877e9a3231= 4e4a0a07 > https://github.com/ovsrobot/pw-ci/commit/3d263267cbd2d0c7b962aaaade981537= 9d03bba2 > > If you look at the 29416 or 29417 series branch history, you'll see > changes from series 29415: > https://github.com/ovsrobot/dpdk/commits/series_29417 Yes - we do handle depends-on as noted. It would be good for the lab to support this as well. Support shouldn't be terribly difficult to provide to the apply process, and it seems it is getting more use lately.