test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
@ 2021-11-11 14:27 Lewei Yang
  2021-11-22 14:15 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Lewei Yang @ 2021-11-11 14:27 UTC (permalink / raw)
  To: dts; +Cc: YangLewei

From: YangLewei <leweix.yang@intel.com>

According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer IPv6 VXLAN"),
this patch added outer UDP checksum,so need set csum hw outer-udp to forward outer IPv6 VXLAN packets.

Signed-off-by: YangLewei <leweix.yang@intel.com>
---
 test_plans/vxlan_test_plan.rst | 1 +
 tests/TestSuite_vxlan.py       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/test_plans/vxlan_test_plan.rst b/test_plans/vxlan_test_plan.rst
index 8af3d8b4..1db5b488 100644
--- a/test_plans/vxlan_test_plan.rst
+++ b/test_plans/vxlan_test_plan.rst
@@ -240,6 +240,7 @@ Enable IP,UDP,TCP,SCTP,VXLAN checksum offload::
     csum set tcp hw 0
     csum set stcp hw 0
     csum set outer-ip hw 0
+    csum set outer-udp hw 0
 
 Send ipv6 packet with valid checksum and check there's no chksum error counter
 increased.
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 1442578d..75b890ee 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -754,6 +754,7 @@ class TestVxlan(TestCase):
         self.dut.send_expect("set fwd csum", "testpmd>", 10)
         self.csum_set_type('outer-ip', self.recv_port)
         self.csum_set_type('udp', self.recv_port)
+        self.csum_set_type('outer-udp', self.recv_port)
         self.csum_set_type('tcp', self.recv_port)
         self.csum_set_type('sctp', self.recv_port)
         self.dut.send_expect("csum parse-tunnel on %d" %
-- 
2.33.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
  2021-11-11 14:27 [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp Lewei Yang
@ 2021-11-22 14:15 ` Tu, Lijuan
  2021-11-23  6:20   ` Jiang, YuX
  0 siblings, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2021-11-22 14:15 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月11日 22:28
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
> 
> From: YangLewei <leweix.yang@intel.com>
> 
> According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer IPv6
> VXLAN"), this patch added outer UDP checksum,so need set csum hw outer-udp
> to forward outer IPv6 VXLAN packets.
> 
> Signed-off-by: YangLewei <leweix.yang@intel.com>

Only test plan changed, or forgot test script ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
  2021-11-22 14:15 ` Tu, Lijuan
@ 2021-11-23  6:20   ` Jiang, YuX
  2021-11-23 13:51     ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Jiang, YuX @ 2021-11-23  6:20 UTC (permalink / raw)
  To: Tu, Lijuan, Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, November 22, 2021 10:16 PM
> To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> outer-udp
> 
> > -----Original Message-----
> > From: Lewei Yang <leweix.yang@intel.com>
> > Sent: 2021年11月11日 22:28
> > To: dts@dpdk.org
> > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> > outer-udp
> >
> > From: YangLewei <leweix.yang@intel.com>
> >
> > According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer
> > IPv6 VXLAN"), this patch added outer UDP checksum,so need set csum hw
> > outer-udp to forward outer IPv6 VXLAN packets.
> >
> > Signed-off-by: YangLewei <leweix.yang@intel.com>
> 
> Only test plan changed, or forgot test script ?
Test plan and test suite both have been changed in this patch. Pls double check and merge them if possible. Thanks a lot.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
  2021-11-23  6:20   ` Jiang, YuX
@ 2021-11-23 13:51     ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-11-23 13:51 UTC (permalink / raw)
  To: Jiang, YuX, Yang, LeweiX, dts; +Cc: Yang, LeweiX



> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: 2021年11月23日 14:21
> To: Tu, Lijuan <lijuan.tu@intel.com>; Yang, LeweiX <leweix.yang@intel.com>;
> dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-
> udp
> 
> > -----Original Message-----
> > From: Tu, Lijuan <lijuan.tu@intel.com>
> > Sent: Monday, November 22, 2021 10:16 PM
> > To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org
> > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add
> > set outer-udp
> >
> > > -----Original Message-----
> > > From: Lewei Yang <leweix.yang@intel.com>
> > > Sent: 2021年11月11日 22:28
> > > To: dts@dpdk.org
> > > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > > Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> > > outer-udp
> > >
> > > From: YangLewei <leweix.yang@intel.com>
> > >
> > > According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer
> > > IPv6 VXLAN"), this patch added outer UDP checksum,so need set csum
> > > hw outer-udp to forward outer IPv6 VXLAN packets.
> > >
> > > Signed-off-by: YangLewei <leweix.yang@intel.com>
> >
> > Only test plan changed, or forgot test script ?
> Test plan and test suite both have been changed in this patch. Pls double check
> and merge them if possible. Thanks a lot.

Applied


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-23 13:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 14:27 [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp Lewei Yang
2021-11-22 14:15 ` Tu, Lijuan
2021-11-23  6:20   ` Jiang, YuX
2021-11-23 13:51     ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git