From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: x-fn-spp@sl.ntt-tx.co.jp
Cc: spp@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp, ferruh.yigit@intel.com
Subject: Re: [spp] [PATCH 0/2] doc:Fix error and improve document under spp_vf
Date: Wed, 9 May 2018 15:33:07 +0900 [thread overview]
Message-ID: <00b1168e-1a4e-1464-da3f-ce60a879290e@lab.ntt.co.jp> (raw)
In-Reply-To: <201805090543.w495hLmK012138@imss04.silk.ntt-tx.co.jp>
On 2018/05/09 14:43, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hideyuki-Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
>
> Hello, this patch set fix and improve document related to spp_vf.
>
> Hideyuki-Yamashita (2):
> doc: Fix document error under spp_vf directory
> doc: Improve document under spp_vf directory
Hideyuki,
Thank you for your first contribution!
I would like to review your patches. However, could you update them before because commit messages are not appripriate? You need
to start subject from "docs: " (not "doc: ") and follow lowercase, "Fix" should be "fix" and also "Improve" should be "improve".
Could you make updated patches with version number "2" with -v option like as following example?
$ git format-patch d63ef8c -o ~/patch/ -v 2
Please refer DPDK contribution guide for details.
http://dpdk.org/doc/guides/contributing/patches.html
Thanks,
Yasufumi
>
> docs/guides/spp_vf/gsg/build.rst | 53 ++++++++++++++----
> docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++--------------
> 2 files changed, 91 insertions(+), 51 deletions(-)
>
--
Yasufumi Ogawa
NTT Network Service Systems Labs
next prev parent reply other threads:[~2018-05-09 6:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 5:43 x-fn-spp
2018-05-09 6:33 ` Yasufumi Ogawa [this message]
2018-05-09 6:57 ` [spp] [PATCH v2 0/2] doc:fix " x-fn-spp
2018-05-16 8:49 ` [spp] [PATCH v3 0/2] docs:fix " x-fn-spp
2018-05-17 4:00 ` Yasufumi Ogawa
2018-05-17 6:41 ` [spp] [PATCH v4 " x-fn-spp
2018-05-17 8:18 ` [spp] [PATCH v5 " x-fn-spp
2018-05-17 9:46 ` Yasufumi Ogawa
2018-05-24 12:54 ` Ferruh Yigit
2018-05-17 8:18 ` [spp] [PATCH v5 1/2] docs: fix document error under spp_vf directory x-fn-spp
2018-05-17 8:18 ` [spp] [PATCH v5 2/2] docs: improve document " x-fn-spp
2018-05-17 6:41 ` [spp] [PATCH v4 1/2] docs: fix document error " x-fn-spp
2018-05-17 6:41 ` [spp] [PATCH v4 2/2] docs: improve document " x-fn-spp
2018-05-16 8:49 ` [spp] [PATCH v3 1/2] docs: fix document error " x-fn-spp
2018-05-16 8:49 ` [spp] [PATCH v3 2/2] docs: improve document " x-fn-spp
2018-05-09 6:58 ` [spp] [PATCH v2 1/2] docs: fix document error " x-fn-spp
2018-05-11 3:44 ` Yasufumi Ogawa
2018-05-09 6:58 ` [spp] [PATCH v2 2/2] docs: improve document " x-fn-spp
2018-05-11 4:23 ` Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00b1168e-1a4e-1464-da3f-ce60a879290e@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).