From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 24A3611D4 for ; Wed, 9 May 2018 08:34:33 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w496YVeP020027; Wed, 9 May 2018 15:34:31 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id B3458EA7A04; Wed, 9 May 2018 15:34:31 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id A6592EA79AC; Wed, 9 May 2018 15:34:31 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 993184005E9; Wed, 9 May 2018 15:34:31 +0900 (JST) References: <201805090543.w495hLmK012138@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <00b1168e-1a4e-1464-da3f-ce60a879290e@lab.ntt.co.jp> Date: Wed, 9 May 2018 15:33:07 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201805090543.w495hLmK012138@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: spp@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp, ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 0/2] doc:Fix error and improve document under spp_vf X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 06:34:34 -0000 On 2018/05/09 14:43, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki-Yamashita > > Hello, this patch set fix and improve document related to spp_vf. > > Hideyuki-Yamashita (2): > doc: Fix document error under spp_vf directory > doc: Improve document under spp_vf directory Hideyuki, Thank you for your first contribution! I would like to review your patches. However, could you update them before because commit messages are not appripriate? You need to start subject from "docs: " (not "doc: ") and follow lowercase, "Fix" should be "fix" and also "Improve" should be "improve". Could you make updated patches with version number "2" with -v option like as following example? $ git format-patch d63ef8c -o ~/patch/ -v 2 Please refer DPDK contribution guide for details. http://dpdk.org/doc/guides/contributing/patches.html Thanks, Yasufumi > > docs/guides/spp_vf/gsg/build.rst | 53 ++++++++++++++---- > docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++-------------- > 2 files changed, 91 insertions(+), 51 deletions(-) > -- Yasufumi Ogawa NTT Network Service Systems Labs