Soft Patch Panel
 help / color / mirror / Atom feed
* [spp] [PATCH 0/2] Fix bug for patch not found error
@ 2018-05-15  1:20 ogawa.yasufumi
  2018-05-15  1:20 ` [spp] [PATCH 1/2] spp_nfv: fix bug for patching PMDs ogawa.yasufumi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: ogawa.yasufumi @ 2018-05-15  1:20 UTC (permalink / raw)
  To: ferruh.yigit, spp; +Cc: Yasufumi Ogawa

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Hi,

This patch is for fixing a bug of patch command. In SPP controller, it
is failed to patch to pcap or nullpmd for not found error. To fix the
bug, add pcap and nullpmd to definition of port types.

Thanks,
Yasufumi


Yasufumi Ogawa (2):
  spp_nfv: fix bug for patching PMDs
  controller: fix bug for patching PMDs

 src/controller/shell.py | 2 +-
 src/nfv/nfv.c           | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [spp] [PATCH 1/2] spp_nfv: fix bug for patching PMDs
  2018-05-15  1:20 [spp] [PATCH 0/2] Fix bug for patch not found error ogawa.yasufumi
@ 2018-05-15  1:20 ` ogawa.yasufumi
  2018-05-15  1:20 ` [spp] [PATCH 2/2] controller: " ogawa.yasufumi
  2018-05-24 12:56 ` [spp] [PATCH 0/2] Fix bug for patch not found error Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: ogawa.yasufumi @ 2018-05-15  1:20 UTC (permalink / raw)
  To: ferruh.yigit, spp; +Cc: Yasufumi Ogawa

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This patch is for adding pcap and nullpmd PMDs to portmap struct to
avoid an 'not found' error for them and working not correctly.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/nfv/nfv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/nfv/nfv.c b/src/nfv/nfv.c
index e4e98ee..d90b40b 100644
--- a/src/nfv/nfv.c
+++ b/src/nfv/nfv.c
@@ -41,6 +41,8 @@ struct porttype_map portmap[] = {
 	{ .port_name = "phy",   .port_type = PHY, },
 	{ .port_name = "ring",  .port_type = RING, },
 	{ .port_name = "vhost", .port_type = VHOST, },
+	{ .port_name = "pcap", .port_type = PCAP, },
+	{ .port_name = "nullpmd", .port_type = NULLPMD, },
 	{ .port_name = NULL,    .port_type = UNDEF, },
 };
 
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [spp] [PATCH 2/2] controller: fix bug for patching PMDs
  2018-05-15  1:20 [spp] [PATCH 0/2] Fix bug for patch not found error ogawa.yasufumi
  2018-05-15  1:20 ` [spp] [PATCH 1/2] spp_nfv: fix bug for patching PMDs ogawa.yasufumi
@ 2018-05-15  1:20 ` ogawa.yasufumi
  2018-05-24 12:56 ` [spp] [PATCH 0/2] Fix bug for patch not found error Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: ogawa.yasufumi @ 2018-05-15  1:20 UTC (permalink / raw)
  To: ferruh.yigit, spp; +Cc: Yasufumi Ogawa

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

It is for adding pcap and nullpmd to PORT_TYPES variable to avoid an
'not found' error for them and working not correctly.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/controller/shell.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controller/shell.py b/src/controller/shell.py
index 137c42b..adcdb14 100644
--- a/src/controller/shell.py
+++ b/src/controller/shell.py
@@ -29,7 +29,7 @@ class Shell(cmd.Cmd, object):
     CMD_NOTREADY = "NOTREADY"
     CMD_ERROR = "ERROR"
 
-    PORT_TYPES = ['phy', 'ring', 'vhost']
+    PORT_TYPES = ['phy', 'ring', 'vhost', 'pcap', 'nullpmd']
 
     PRI_CMDS = ['status', 'exit', 'clear']
     SEC_CMDS = ['status', 'exit', 'forward', 'stop', 'add', 'patch', 'del']
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [spp] [PATCH 0/2] Fix bug for patch not found error
  2018-05-15  1:20 [spp] [PATCH 0/2] Fix bug for patch not found error ogawa.yasufumi
  2018-05-15  1:20 ` [spp] [PATCH 1/2] spp_nfv: fix bug for patching PMDs ogawa.yasufumi
  2018-05-15  1:20 ` [spp] [PATCH 2/2] controller: " ogawa.yasufumi
@ 2018-05-24 12:56 ` Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-05-24 12:56 UTC (permalink / raw)
  To: ogawa.yasufumi, spp

On 5/15/2018 2:20 AM, ogawa.yasufumi@lab.ntt.co.jp wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> 
> Hi,
> 
> This patch is for fixing a bug of patch command. In SPP controller, it
> is failed to patch to pcap or nullpmd for not found error. To fix the
> bug, add pcap and nullpmd to definition of port types.
> 
> Thanks,
> Yasufumi
> 
> 
> Yasufumi Ogawa (2):
>   spp_nfv: fix bug for patching PMDs
>   controller: fix bug for patching PMDs

Series applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-24 12:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15  1:20 [spp] [PATCH 0/2] Fix bug for patch not found error ogawa.yasufumi
2018-05-15  1:20 ` [spp] [PATCH 1/2] spp_nfv: fix bug for patching PMDs ogawa.yasufumi
2018-05-15  1:20 ` [spp] [PATCH 2/2] controller: " ogawa.yasufumi
2018-05-24 12:56 ` [spp] [PATCH 0/2] Fix bug for patch not found error Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).