From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 93E27343C for ; Thu, 9 Aug 2018 04:45:23 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w792jMPf006544; Thu, 9 Aug 2018 11:45:22 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id A78F7EA75A9; Thu, 9 Aug 2018 11:45:22 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 9CF0DEA752E; Thu, 9 Aug 2018 11:45:22 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 96E4B4007A6; Thu, 9 Aug 2018 11:45:22 +0900 (JST) References: <201808020831.w728V9N5031675@imss03.silk.ntt-tx.co.jp> <201808090038.w790c6aE022190@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <0694f113-5838-b49d-ee98-2f22fa658653@lab.ntt.co.jp> Date: Thu, 9 Aug 2018 11:43:10 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201808090038.w790c6aE022190@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com Cc: spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH v2 1/1] spp_vf: fix initializing bug of forwarder X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 02:45:25 -0000 On 2018/08/09 9:38, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki Yamashita > > clear_forward_info() always initializes path[0] of g_forward_info[id]. > It is a bug and causes stopping forwarding accidentally if path[0] is > referenced by spp_forward(). > > This patch changes initializing as path[info->upd_index] instead of 0. > It also includes refactoring to be simple by using local vars. Hi Hideyuki, Thanks for revising. Could you also update commit message for the change. Thanks, Yasufumi > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > src/vf/spp_forward.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/src/vf/spp_forward.c b/src/vf/spp_forward.c > index 0a43608..03bda10 100644 > --- a/src/vf/spp_forward.c > +++ b/src/vf/spp_forward.c > @@ -49,13 +49,6 @@ spp_forward_init(void) > } > } > > -/* Clear info for one element. */ > -static void > -clear_forward_info(int id) > -{ > - memset(&g_forward_info[id].path, 0x00, sizeof(struct forward_path)); > -} > - > /* Update forward info */ > int > spp_forward_update(struct spp_component_info *component) > @@ -84,7 +77,7 @@ spp_forward_update(struct spp_component_info *component) > return -1; > } > > - clear_forward_info(component->component_id); > + memset(path, 0x00, sizeof(struct forward_path)); > > RTE_LOG(INFO, FORWARD, > "Component[%d] Start update component. (name = %s, type = %d)\n", > -- Yasufumi Ogawa NTT Network Service Systems Labs